[
https://issues.apache.org/jira/browse/LUCENE-10078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508034#comment-17508034
]
Anand Kotriwal commented on LUCENE-10078:
-
I like the idea of using {_}minMerge
mocobeta commented on a change in pull request #740:
URL: https://github.com/apache/lucene/pull/740#discussion_r828874471
##
File path:
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/util/UnknownDictionaryWriter.java
##
@@ -56,9 +59,14 @@ public void putInvoke
rmuir commented on pull request #672:
URL: https://github.com/apache/lucene/pull/672#issuecomment-1070626144
I like it! to me it looks much cleaner than before. sorry for the huge
delay, i missed the notification.
--
This is an automated message from the Apache Git Service.
To respond to
Mayya Sharipova created LUCENE-10471:
Summary: Increase the number of dims for KNN vectors to 2048
Key: LUCENE-10471
URL: https://issues.apache.org/jira/browse/LUCENE-10471
Project: Lucene - Core
rmuir commented on a change in pull request #740:
URL: https://github.com/apache/lucene/pull/740#discussion_r828972652
##
File path:
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/UnknownMorphData.java
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache So
[
https://issues.apache.org/jira/browse/LUCENE-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayya Sharipova updated LUCENE-10471:
-
Description:
The current maximum allowed number of dimensions is equal to 1024. But we
[
https://issues.apache.org/jira/browse/LUCENE-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayya Sharipova updated LUCENE-10471:
-
Description:
The current maximum allowed number of dimensions is equal to 1024. But we
mocobeta commented on a change in pull request #740:
URL: https://github.com/apache/lucene/pull/740#discussion_r828980178
##
File path:
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/UnknownMorphData.java
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache
mocobeta commented on pull request #740:
URL: https://github.com/apache/lucene/pull/740#issuecomment-107076
I think I finished what I'd like to make changes in kuromoji and nori.
Now, `ConnectionCosts`/`ConnectionCostsWriter` and
`CharacterDefinition`/`CharacterDefinitionWriter` are
[
https://issues.apache.org/jira/browse/LUCENE-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508140#comment-17508140
]
Robert Muir commented on LUCENE-10471:
--
I don't "strongly object" but I question t
rmuir commented on a change in pull request #740:
URL: https://github.com/apache/lucene/pull/740#discussion_r829016828
##
File path:
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/util/TokenInfoDictionaryEntryWriter.java
##
@@ -0,0 +1,221 @@
+/*
+ * Licensed t
mocobeta commented on a change in pull request #740:
URL: https://github.com/apache/lucene/pull/740#discussion_r829051989
##
File path:
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/util/TokenInfoDictionaryEntryWriter.java
##
@@ -0,0 +1,221 @@
+/*
+ * License
janhoy merged pull request #2647:
URL: https://github.com/apache/lucene-solr/pull/2647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsu
mocobeta commented on pull request #740:
URL: https://github.com/apache/lucene/pull/740#issuecomment-1070917923
The core dictionary logic is split into two modules (analysis-common and
analysis-kuromoji/nori), I manually tested the tokenizers work with Java
modules - for now luke app is a
[
https://issues.apache.org/jira/browse/LUCENE-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508196#comment-17508196
]
Tomoko Uchida commented on LUCENE-10461:
I have closed the pr. Perhaps I was to
[
https://issues.apache.org/jira/browse/LUCENE-10418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508250#comment-17508250
]
ASF subversion and git services commented on LUCENE-10418:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508252#comment-17508252
]
ASF subversion and git services commented on LUCENE-10418:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508253#comment-17508253
]
ASF subversion and git services commented on LUCENE-10418:
--
Co
jpountz merged pull request #672:
URL: https://github.com/apache/lucene/pull/672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
jpountz commented on pull request #672:
URL: https://github.com/apache/lucene/pull/672#issuecomment-1070993075
Thanks Robert!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
[
https://issues.apache.org/jira/browse/LUCENE-10418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-10418.
---
Fix Version/s: 9.2
Resolution: Fixed
> Improve Query rewriting for non-scoring claus
uschindler commented on pull request #740:
URL: https://github.com/apache/lucene/pull/740#issuecomment-1071008332
I like the idea to remove the code duplication and have only one
implementation.
On the other hand, if you look at LOC before/after: +1,818 −1,492
We now have 326 line
uschindler edited a comment on pull request #740:
URL: https://github.com/apache/lucene/pull/740#issuecomment-1071008332
I like the idea to remove the code duplication and have only one
implementation.
On the other hand, if you look at LOC before/after: +1,818 −1,492
We now have 3
[
https://issues.apache.org/jira/browse/LUCENE-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508272#comment-17508272
]
Dawid Weiss commented on LUCENE-10461:
--
I agree what's currently there is not perf
[
https://issues.apache.org/jira/browse/LUCENE-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuting Gan updated LUCENE-10467:
Description:
Currently, there are different behaviors from subclass that implements and
overrid
mocobeta commented on pull request #740:
URL: https://github.com/apache/lucene/pull/740#issuecomment-1071100941
About the increased number of lines, the majority of them are license
headers and documentation.
There are added 22 files (to sort out interfaces) and removed 4 files - each
l
mocobeta edited a comment on pull request #740:
URL: https://github.com/apache/lucene/pull/740#issuecomment-1071100941
About the increased number of lines, the majority of them are license
headers and documentation.
There are added 22 files (to sort out interfaces) and removed 4 files -
gsmiller commented on a change in pull request #747:
URL: https://github.com/apache/lucene/pull/747#discussion_r829161071
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java
##
@@ -143,9 +146,49 @@ private FacetResult getPat
mocobeta edited a comment on pull request #740:
URL: https://github.com/apache/lucene/pull/740#issuecomment-1071100941
About the increased number of lines, the majority of them are license
headers and documentation.
There are added 22 files (to sort out interfaces) and removed 4 files -
Julie Tibshirani created LUCENE-10472:
-
Summary: TestMatchAllDocsQuery#testEarlyTermination fails total
hits assertion
Key: LUCENE-10472
URL: https://issues.apache.org/jira/browse/LUCENE-10472
Pro
Julie Tibshirani created LUCENE-10473:
-
Summary: Address slow BaseSpatialTestCase#testRandomBigruns
Key: LUCENE-10473
URL: https://issues.apache.org/jira/browse/LUCENE-10473
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-10473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julie Tibshirani updated LUCENE-10473:
--
Summary: Address slow BaseSpatialTestCase#testRandomBig runs (was: Address
slow Base
[
https://issues.apache.org/jira/browse/LUCENE-10473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508422#comment-17508422
]
Robert Muir commented on LUCENE-10473:
--
I'm not sure about BaseSpatialTestCase, bu
[
https://issues.apache.org/jira/browse/LUCENE-10473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508427#comment-17508427
]
Julie Tibshirani commented on LUCENE-10473:
---
Sorry, I wrote that description
[
https://issues.apache.org/jira/browse/LUCENE-10473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julie Tibshirani updated LUCENE-10473:
--
Description:
While working on the 9.1 release, we noticed the smoke tester sometimes
[
https://issues.apache.org/jira/browse/LUCENE-10473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julie Tibshirani updated LUCENE-10473:
--
Summary: Address slow testRandomBig runs (was: Address slow
BaseSpatialTestCase#test
[
https://issues.apache.org/jira/browse/LUCENE-10473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julie Tibshirani updated LUCENE-10473:
--
Description:
While working on the 9.1 release, we noticed the smoke tester sometimes
[
https://issues.apache.org/jira/browse/LUCENE-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508446#comment-17508446
]
Marc D'Mello commented on LUCENE-10204:
---
[~gsmiller] and I discussed this issue a
[
https://issues.apache.org/jira/browse/LUCENE-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508446#comment-17508446
]
Marc D'Mello edited comment on LUCENE-10204 at 3/17/22, 9:56 PM:
Yuti-G commented on a change in pull request #747:
URL: https://github.com/apache/lucene/pull/747#discussion_r829320811
##
File path: lucene/facet/src/java/org/apache/lucene/facet/Facets.java
##
@@ -48,4 +48,13 @@ public abstract FacetResult getTopChildren(int topN, String
dim
[
https://issues.apache.org/jira/browse/LUCENE-10416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508465#comment-17508465
]
Uihyun Kim commented on LUCENE-10416:
-
[~tomoko] [~uschindler] Thank you for review
Yuti-G commented on a change in pull request #747:
URL: https://github.com/apache/lucene/pull/747#discussion_r829346533
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java
##
@@ -414,4 +505,101 @@ public int compare(FacetRes
[
https://issues.apache.org/jira/browse/LUCENE-10416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508478#comment-17508478
]
Uwe Schindler commented on LUCENE-10416:
Thank you for confirming. We applied t
[
https://issues.apache.org/jira/browse/LUCENE-10473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508589#comment-17508589
]
Dawid Weiss commented on LUCENE-10473:
--
Maybe we can mark them monster tests or so
44 matches
Mail list logo
