mocobeta commented on a change in pull request #740:
URL: https://github.com/apache/lucene/pull/740#discussion_r828874471
##########
File path:
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/util/UnknownDictionaryWriter.java
##########
@@ -56,9 +59,14 @@ public void putInvokeDefinition(String characterClassName,
int invoke, int group
characterDefinition.putInvokeDefinition(characterClassName, invoke, group,
length);
}
- @Override
+ // @Override
Review comment:
No, it looks the interfaces were still work-in-progress.
I think an abstract method should be added to the base dictionary writer
class.
https://github.com/apache/lucene/pull/740/commits/7d4351417a0bb96e647525cae6eb8124e0805016
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
