[GitHub] [lucene] spyk commented on pull request #380: LUCENE-10171 - Fix dictionary-based OpenNLPLemmatizerFilterFactory caching issue

2022-03-08 Thread GitBox
spyk commented on pull request #380: URL: https://github.com/apache/lucene/pull/380#issuecomment-1061732060 > I'd be willing to take care of adding it, if you'd prefer. The CHANGES.txt file changes often and gets conflicts which, although trivial, can be kind of annoying. At this point it'

[GitHub] [lucene] msokolov merged pull request #735: Fix: typo + +minScore.

2022-03-08 Thread GitBox
msokolov merged pull request #735: URL: https://github.com/apache/lucene/pull/735 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Commented] (LUCENE-10457) LuceneTestCase.createTempDir could randomly return symbolic links

2022-03-08 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502990#comment-17502990 ] Robert Muir commented on LUCENE-10457: -- Sorry, a symbolic link is a whole differen

[jira] [Commented] (LUCENE-10457) LuceneTestCase.createTempDir could randomly return symbolic links

2022-03-08 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17503016#comment-17503016 ] Mike Drob commented on LUCENE-10457: > Sorry, a symbolic link is a whole different

[GitHub] [lucene] magibney merged pull request #380: LUCENE-10171 - Fix dictionary-based OpenNLPLemmatizerFilterFactory caching issue

2022-03-08 Thread GitBox
magibney merged pull request #380: URL: https://github.com/apache/lucene/pull/380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Commented] (LUCENE-10171) Caching issue on dictionary-based OpenNLPLemmatizerFilterFactory

2022-03-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17503082#comment-17503082 ] ASF subversion and git services commented on LUCENE-10171: -- Co

[GitHub] [lucene] magibney commented on pull request #380: LUCENE-10171 - Fix dictionary-based OpenNLPLemmatizerFilterFactory caching issue

2022-03-08 Thread GitBox
magibney commented on pull request #380: URL: https://github.com/apache/lucene/pull/380#issuecomment-1062061030 Merged to `main` and backported to `branch_9x`; this should be available as of release 9.1. Thanks @spyk! -- This is an automated message from the Apache Git Service. To res

[jira] [Commented] (LUCENE-10171) Caching issue on dictionary-based OpenNLPLemmatizerFilterFactory

2022-03-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17503097#comment-17503097 ] ASF subversion and git services commented on LUCENE-10171: -- Co

[jira] [Resolved] (LUCENE-10171) Caching issue on dictionary-based OpenNLPLemmatizerFilterFactory

2022-03-08 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Gibney resolved LUCENE-10171. - Fix Version/s: 9.1 Lucene Fields: (was: New,Patch Available) Assignee: Mi

[jira] [Updated] (LUCENE-10371) Make IndexRearranger able to arrange segment into a determined order

2022-03-08 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julie Tibshirani updated LUCENE-10371: -- Fix Version/s: 9.1 > Make IndexRearranger able to arrange segment into a determined o

[jira] [Updated] (LUCENE-10236) CombinedFieldsQuery to use fieldAndWeights.values() when constructing MultiNormsLeafSimScorer for scoring

2022-03-08 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julie Tibshirani updated LUCENE-10236: -- Fix Version/s: 9.1 > CombinedFieldsQuery to use fieldAndWeights.values() when constru

[jira] [Updated] (LUCENE-10339) Add require derective for jdk.management to core's module descriptor.

2022-03-08 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julie Tibshirani updated LUCENE-10339: -- Fix Version/s: 9.1 10.0 (main) > Add require derective for jdk.man

[GitHub] [lucene] vigyasharma commented on a change in pull request #633: [WIP] LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

2022-03-08 Thread GitBox
vigyasharma commented on a change in pull request #633: URL: https://github.com/apache/lucene/pull/633#discussion_r822174425 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfos.java ## @@ -352,6 +352,14 @@ public FieldDimensions(int dimensionCount, int indexD

[GitHub] [lucene] vigyasharma commented on a change in pull request #633: [WIP] LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

2022-03-08 Thread GitBox
vigyasharma commented on a change in pull request #633: URL: https://github.com/apache/lucene/pull/633#discussion_r822174617 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -3121,147 +3125,265 @@ private void validateMergeReader(CodecReader lea

[GitHub] [lucene] vigyasharma commented on a change in pull request #633: [WIP] LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

2022-03-08 Thread GitBox
vigyasharma commented on a change in pull request #633: URL: https://github.com/apache/lucene/pull/633#discussion_r822175645 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -3121,147 +3125,265 @@ private void validateMergeReader(CodecReader lea

[GitHub] [lucene] vigyasharma commented on a change in pull request #633: [WIP] LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

2022-03-08 Thread GitBox
vigyasharma commented on a change in pull request #633: URL: https://github.com/apache/lucene/pull/633#discussion_r822184400 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -3121,147 +3125,265 @@ private void validateMergeReader(CodecReader lea

[GitHub] [lucene] vigyasharma commented on a change in pull request #633: [WIP] LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

2022-03-08 Thread GitBox
vigyasharma commented on a change in pull request #633: URL: https://github.com/apache/lucene/pull/633#discussion_r822184400 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -3121,147 +3125,265 @@ private void validateMergeReader(CodecReader lea

[GitHub] [lucene] vigyasharma commented on a change in pull request #633: [WIP] LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

2022-03-08 Thread GitBox
vigyasharma commented on a change in pull request #633: URL: https://github.com/apache/lucene/pull/633#discussion_r822185980 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -3121,147 +3125,265 @@ private void validateMergeReader(CodecReader lea

[GitHub] [lucene] vigyasharma commented on a change in pull request #633: [WIP] LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

2022-03-08 Thread GitBox
vigyasharma commented on a change in pull request #633: URL: https://github.com/apache/lucene/pull/633#discussion_r822189054 ## File path: lucene/core/src/java/org/apache/lucene/index/MergePolicy.java ## @@ -567,6 +605,21 @@ public abstract MergeSpecification findMerges(

[GitHub] [lucene] vigyasharma commented on a change in pull request #633: [WIP] LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

2022-03-08 Thread GitBox
vigyasharma commented on a change in pull request #633: URL: https://github.com/apache/lucene/pull/633#discussion_r822190688 ## File path: lucene/core/src/java/org/apache/lucene/index/MergePolicy.java ## @@ -813,12 +866,24 @@ protected final boolean verbose(MergeContext mergeC

[GitHub] [lucene] vigyasharma commented on a change in pull request #633: [WIP] LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

2022-03-08 Thread GitBox
vigyasharma commented on a change in pull request #633: URL: https://github.com/apache/lucene/pull/633#discussion_r822195662 ## File path: lucene/core/src/java/org/apache/lucene/index/NoMergePolicy.java ## @@ -39,6 +40,11 @@ public MergeSpecification findMerges( return nul

[GitHub] [lucene] vigyasharma commented on pull request #633: [WIP] LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

2022-03-08 Thread GitBox
vigyasharma commented on pull request #633: URL: https://github.com/apache/lucene/pull/633#issuecomment-1062441177 Thanks for reviewing this @mikemccand ! I've addressed the ones that had minor changes, and am working on the larger ones. > What remains to bring this out of WIP?

[jira] [Commented] (LUCENE-10448) MergeRateLimiter doesn't always limit instant rate.

2022-03-08 Thread kkewwei (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17503238#comment-17503238 ] kkewwei commented on LUCENE-10448: -- In our product, the instant rate of writing is 200

[jira] [Commented] (LUCENE-10457) LuceneTestCase.createTempDir could randomly return symbolic links

2022-03-08 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17503290#comment-17503290 ] Robert Muir commented on LUCENE-10457: -- {quote} In what ways? If you pass a symlin

[jira] [Commented] (LUCENE-10457) LuceneTestCase.createTempDir could randomly return symbolic links

2022-03-08 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17503322#comment-17503322 ] Dawid Weiss commented on LUCENE-10457: -- On the one hand I'm with Mike – it should

[jira] [Comment Edited] (LUCENE-10457) LuceneTestCase.createTempDir could randomly return symbolic links

2022-03-08 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17503322#comment-17503322 ] Dawid Weiss edited comment on LUCENE-10457 at 3/9/22, 6:32 AM: --

[GitHub] [lucene] mogui commented on a change in pull request #679: Monitor Improvements LUCENE-10422

2022-03-08 Thread GitBox
mogui commented on a change in pull request #679: URL: https://github.com/apache/lucene/pull/679#discussion_r822356271 ## File path: lucene/monitor/src/java/org/apache/lucene/monitor/ReadonlyQueryIndex.java ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [lucene] mogui commented on a change in pull request #679: Monitor Improvements LUCENE-10422

2022-03-08 Thread GitBox
mogui commented on a change in pull request #679: URL: https://github.com/apache/lucene/pull/679#discussion_r822356271 ## File path: lucene/monitor/src/java/org/apache/lucene/monitor/ReadonlyQueryIndex.java ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundatio