[jira] [Assigned] (LUCENE-10353) Add null injection to analyzer integration tests (e.g. TestRandomChains)

2022-01-05 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler reassigned LUCENE-10353: -- Assignee: Uwe Schindler > Add null injection to analyzer integration tests (e.g. Tes

[jira] [Commented] (LUCENE-10353) Add null injection to analyzer integration tests (e.g. TestRandomChains)

2022-01-05 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469150#comment-17469150 ] Uwe Schindler commented on LUCENE-10353: This is one example I found on first t

[jira] [Commented] (LUCENE-10353) Add null injection to analyzer integration tests (e.g. TestRandomChains)

2022-01-05 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469148#comment-17469148 ] Uwe Schindler commented on LUCENE-10353: Hi, I did some quick test on my branch

[GitHub] [lucene] jpountz commented on a change in pull request #583: LUCENE-10354: Clarify contract of codec APIs with missing/disabled fields.

2022-01-05 Thread GitBox
jpountz commented on a change in pull request #583: URL: https://github.com/apache/lucene/pull/583#discussion_r778690428 ## File path: lucene/core/src/java/org/apache/lucene/codecs/FieldsProducer.java ## @@ -42,6 +45,14 @@ protected FieldsProducer() {} */ public abstract

[GitHub] [lucene] uschindler commented on a change in pull request #571: LUCENE-10328: Module path for compiling and running tests is wrong

2022-01-05 Thread GitBox
uschindler commented on a change in pull request #571: URL: https://github.com/apache/lucene/pull/571#discussion_r778683708 ## File path: gradle/validation/validate-source-patterns.gradle ## @@ -154,12 +154,11 @@ class ValidateSourcePatternsTask extends DefaultTask { (~$

[GitHub] [lucene] uschindler commented on a change in pull request #571: LUCENE-10328: Module path for compiling and running tests is wrong

2022-01-05 Thread GitBox
uschindler commented on a change in pull request #571: URL: https://github.com/apache/lucene/pull/571#discussion_r778695887 ## File path: gradle/java/modules.gradle ## @@ -27,194 +29,167 @@ allprojects { modularity.inferModulePath.set(false) } -// Map conventi

[jira] [Created] (LUCENE-10357) Ghost fields and postings/points

2022-01-05 Thread Adrien Grand (Jira)
Adrien Grand created LUCENE-10357: - Summary: Ghost fields and postings/points Key: LUCENE-10357 URL: https://issues.apache.org/jira/browse/LUCENE-10357 Project: Lucene - Core Issue Type: Task

[GitHub] [lucene] jpountz commented on a change in pull request #583: LUCENE-10354: Clarify contract of codec APIs with missing/disabled fields.

2022-01-05 Thread GitBox
jpountz commented on a change in pull request #583: URL: https://github.com/apache/lucene/pull/583#discussion_r778696246 ## File path: lucene/core/src/java/org/apache/lucene/codecs/FieldsProducer.java ## @@ -42,6 +45,14 @@ protected FieldsProducer() {} */ public abstract

[GitHub] [lucene] spyk commented on pull request #380: LUCENE-10171 - Fix dictionary-based OpenNLPLemmatizerFilterFactory caching issue

2022-01-05 Thread GitBox
spyk commented on pull request #380: URL: https://github.com/apache/lucene/pull/380#issuecomment-1005559984 @magibney @alessandrobenedetti could you please check and review the above? Also, wondering if it could/should be backported to 8.x versions. The same patch should work almost as

[GitHub] [lucene] dweiss commented on pull request #571: LUCENE-10328: Module path for compiling and running tests is wrong

2022-01-05 Thread GitBox
dweiss commented on pull request #571: URL: https://github.com/apache/lucene/pull/571#issuecomment-1005569699 Please take a look at this comment/ chart, Uwe. https://issues.apache.org/jira/browse/LUCENE-10328?focusedCommentId=17468676&page=com.atlassian.jira.plugin.system.issuetabpanels%

[GitHub] [lucene] dweiss commented on a change in pull request #571: LUCENE-10328: Module path for compiling and running tests is wrong

2022-01-05 Thread GitBox
dweiss commented on a change in pull request #571: URL: https://github.com/apache/lucene/pull/571#discussion_r778714972 ## File path: gradle/validation/validate-source-patterns.gradle ## @@ -154,12 +154,11 @@ class ValidateSourcePatternsTask extends DefaultTask { (~$/\n\

[GitHub] [lucene] dweiss commented on a change in pull request #571: LUCENE-10328: Module path for compiling and running tests is wrong

2022-01-05 Thread GitBox
dweiss commented on a change in pull request #571: URL: https://github.com/apache/lucene/pull/571#discussion_r778715231 ## File path: lucene/core.tests/src/java/module-info.java ## @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * c

[GitHub] [lucene] dweiss commented on a change in pull request #571: LUCENE-10328: Module path for compiling and running tests is wrong

2022-01-05 Thread GitBox
dweiss commented on a change in pull request #571: URL: https://github.com/apache/lucene/pull/571#discussion_r778718571 ## File path: gradle/java/modules.gradle ## @@ -27,194 +29,167 @@ allprojects { modularity.inferModulePath.set(false) } -// Map convention c

[GitHub] [lucene] rmuir commented on pull request #582: LUCENE-10352: Convert TestAllAnalyzersHaveFactories and TestRandomChains to a global integration test and discover classes to check from module

2022-01-05 Thread GitBox
rmuir commented on pull request #582: URL: https://github.com/apache/lucene/pull/582#issuecomment-1005594207 > The name does not matter, only the suffix `.tests` matters. It kind of matters, I just think we should do this consistently. If you really like `integration.tests` name, tha

[GitHub] [lucene] rmuir commented on pull request #582: LUCENE-10352: Convert TestAllAnalyzersHaveFactories and TestRandomChains to a global integration test and discover classes to check from module

2022-01-05 Thread GitBox
rmuir commented on pull request #582: URL: https://github.com/apache/lucene/pull/582#issuecomment-1005594826 > @rmuir I found a failure: In both these failures I see the `JapaneseIterationMarkCharFilter`. Maybe shitlist this temporarily until we have time to debug why it messes up of

[GitHub] [lucene] uschindler commented on pull request #582: LUCENE-10352: Convert TestAllAnalyzersHaveFactories and TestRandomChains to a global integration test and discover classes to check from mo

2022-01-05 Thread GitBox
uschindler commented on pull request #582: URL: https://github.com/apache/lucene/pull/582#issuecomment-1005597114 > > The name does not matter, only the suffix `.tests` matters. > > It kind of matters, I just think we should do this consistently. If you really like `integration.tests

[GitHub] [lucene] uschindler commented on pull request #582: LUCENE-10352: Convert TestAllAnalyzersHaveFactories and TestRandomChains to a global integration test and discover classes to check from mo

2022-01-05 Thread GitBox
uschindler commented on pull request #582: URL: https://github.com/apache/lucene/pull/582#issuecomment-1005597708 > > @rmuir I found a failure: > > In both these failures I see the `JapaneseIterationMarkCharFilter`. Maybe shitlist this temporarily until we have time to debug why it m

[GitHub] [lucene] rmuir commented on pull request #582: LUCENE-10352: Convert TestAllAnalyzersHaveFactories and TestRandomChains to a global integration test and discover classes to check from module

2022-01-05 Thread GitBox
rmuir commented on pull request #582: URL: https://github.com/apache/lucene/pull/582#issuecomment-1005600771 > Sure, I can move the classes around no issue. But then analysis.test would be top-level next to the analysis subdirectory. If this is fine to you, I will do. ok, this makes

[GitHub] [lucene] uschindler commented on pull request #582: LUCENE-10352: Convert TestAllAnalyzersHaveFactories and TestRandomChains to a global integration test and discover classes to check from mo

2022-01-05 Thread GitBox
uschindler commented on pull request #582: URL: https://github.com/apache/lucene/pull/582#issuecomment-1005601990 Another failure: ``` 2> stage 0: e<[2-3] +1> ek<[4-6] +1> oy<[8-10] +1> 1<[11-12] +1> zzkuxp<[13-19] +1> 2> stage 1: e<[2-3] +1> ek<[4-6] +1> oy<[8-10] +1> 1<[1

[GitHub] [lucene] uschindler edited a comment on pull request #582: LUCENE-10352: Convert TestAllAnalyzersHaveFactories and TestRandomChains to a global integration test and discover classes to check

2022-01-05 Thread GitBox
uschindler edited a comment on pull request #582: URL: https://github.com/apache/lucene/pull/582#issuecomment-1005601990 Another failure: ``` 2> stage 0: e<[2-3] +1> ek<[4-6] +1> oy<[8-10] +1> 1<[11-12] +1> zzkuxp<[13-19] +1> 2> stage 1: e<[2-3] +1> ek<[4-6] +1> oy<[8-10] +

[jira] [Commented] (LUCENE-10353) Add null injection to analyzer integration tests (e.g. TestRandomChains)

2022-01-05 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469220#comment-17469220 ] Robert Muir commented on LUCENE-10353: -- +1, this sounds good to me. Then we can ad

[jira] [Created] (LUCENE-10358) TestRandomChains fails with incorrect offsets or causes IndexOutOfBounds

2022-01-05 Thread Uwe Schindler (Jira)
Uwe Schindler created LUCENE-10358: -- Summary: TestRandomChains fails with incorrect offsets or causes IndexOutOfBounds Key: LUCENE-10358 URL: https://issues.apache.org/jira/browse/LUCENE-10358 Projec

[jira] [Created] (LUCENE-10359) TestRandomChains fails with incorrect offsets or causes IndexOutOfBounds for KoreanTokenizer

2022-01-05 Thread Uwe Schindler (Jira)
Uwe Schindler created LUCENE-10359: -- Summary: TestRandomChains fails with incorrect offsets or causes IndexOutOfBounds for KoreanTokenizer Key: LUCENE-10359 URL: https://issues.apache.org/jira/browse/LUCENE-10359

[jira] [Updated] (LUCENE-10358) JapaneseIterationMarkCharFilter: TestRandomChains fails with incorrect offsets or causes IndexOutOfBounds

2022-01-05 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-10358: --- Summary: JapaneseIterationMarkCharFilter: TestRandomChains fails with incorrect offsets or

[jira] [Updated] (LUCENE-10359) KoreanTokenizer: TestRandomChains fails with incorrect offsets

2022-01-05 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-10359: --- Component/s: modules/analysis > KoreanTokenizer: TestRandomChains fails with incorrect offs

[jira] [Updated] (LUCENE-10359) KoreanTokenizer: TestRandomChains fails with incorrect offsets

2022-01-05 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-10359: --- Summary: KoreanTokenizer: TestRandomChains fails with incorrect offsets (was: TestRandomCh

[jira] [Commented] (LUCENE-10359) KoreanTokenizer: TestRandomChains fails with incorrect offsets

2022-01-05 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469228#comment-17469228 ] Uwe Schindler commented on LUCENE-10359: Reproduce line: gradlew :lucene:analys

[jira] [Created] (LUCENE-10360) BeiderMorseFilter: TestRandomChains fails with IndexOutOfBounds on empty term text

2022-01-05 Thread Uwe Schindler (Jira)
Uwe Schindler created LUCENE-10360: -- Summary: BeiderMorseFilter: TestRandomChains fails with IndexOutOfBounds on empty term text Key: LUCENE-10360 URL: https://issues.apache.org/jira/browse/LUCENE-10360

[jira] [Commented] (LUCENE-10359) KoreanTokenizer: TestRandomChains fails with incorrect offsets

2022-01-05 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469269#comment-17469269 ] Robert Muir commented on LUCENE-10359: -- This one may be KoreanNumberFilter in the

[jira] [Created] (LUCENE-10361) KoreanNumberFilter messes up offsets

2022-01-05 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10361: Summary: KoreanNumberFilter messes up offsets Key: LUCENE-10361 URL: https://issues.apache.org/jira/browse/LUCENE-10361 Project: Lucene - Core Issue Type: Bu

[GitHub] [lucene] dweiss commented on pull request #582: LUCENE-10352: Convert TestAllAnalyzersHaveFactories and TestRandomChains to a global integration test and discover classes to check from module

2022-01-05 Thread GitBox
dweiss commented on pull request #582: URL: https://github.com/apache/lucene/pull/582#issuecomment-1005656661 > The name does not matter, only the suffix .tests matters. The "*.tests" convention for project naming is primarily used to exclude these subprojects from being published as

[jira] [Commented] (LUCENE-10360) BeiderMorseFilter: TestRandomChains fails with IndexOutOfBounds on empty term text

2022-01-05 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469286#comment-17469286 ] Uwe Schindler commented on LUCENE-10360: It fails also in other modes with empt

[jira] [Created] (LUCENE-10362) JapaneseNumberFilter messes up offsets

2022-01-05 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10362: Summary: JapaneseNumberFilter messes up offsets Key: LUCENE-10362 URL: https://issues.apache.org/jira/browse/LUCENE-10362 Project: Lucene - Core Issue Type:

[jira] [Created] (LUCENE-10363) JapaneseCompletionFilter messes up offsets

2022-01-05 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10363: Summary: JapaneseCompletionFilter messes up offsets Key: LUCENE-10363 URL: https://issues.apache.org/jira/browse/LUCENE-10363 Project: Lucene - Core Issue Ty

[GitHub] [lucene] rmuir commented on pull request #582: LUCENE-10352: Convert TestAllAnalyzersHaveFactories and TestRandomChains to a global integration test and discover classes to check from module

2022-01-05 Thread GitBox
rmuir commented on pull request #582: URL: https://github.com/apache/lucene/pull/582#issuecomment-1005689664 I successfully got 100 runs of this test to pass: ``` ./gradlew :lucene:analysis:integration.tests:beast -Dtests.dups=100 --tests TestRandomChains -Dtests.nightly=true ```

[GitHub] [lucene] uschindler commented on pull request #582: LUCENE-10352: Convert TestAllAnalyzersHaveFactories and TestRandomChains to a global integration test and discover classes to check from mo

2022-01-05 Thread GitBox
uschindler commented on pull request #582: URL: https://github.com/apache/lucene/pull/582#issuecomment-1005692965 It is similar now for me. I will now move the integration package around and then wait for another round. Otherwise I think it is ready. -- This is an automated messag

[GitHub] [lucene] uschindler commented on pull request #582: LUCENE-10352: Convert TestAllAnalyzersHaveFactories and TestRandomChains to a global integration test and discover classes to check from mo

2022-01-05 Thread GitBox
uschindler commented on pull request #582: URL: https://github.com/apache/lucene/pull/582#issuecomment-1005694530 I wanted to originally backport this to 9.x. I am just afraid that the two branches get too different (there are many changes in this PR). hat do you think? Maybe on 9.x

[GitHub] [lucene] uschindler edited a comment on pull request #582: LUCENE-10352: Convert TestAllAnalyzersHaveFactories and TestRandomChains to a global integration test and discover classes to check

2022-01-05 Thread GitBox
uschindler edited a comment on pull request #582: URL: https://github.com/apache/lucene/pull/582#issuecomment-1005694530 I wanted to originally backport this to 9.x. I am just afraid that the two branches get too different (there are many changes in this PR). @rmuir what do you think

[GitHub] [lucene] jpountz commented on pull request #579: LUCENE-10283: Bump minimum required Java version to 17.

2022-01-05 Thread GitBox
jpountz commented on pull request #579: URL: https://github.com/apache/lucene/pull/579#issuecomment-1005698705 Precommit now passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [lucene] uschindler commented on pull request #582: LUCENE-10352: Convert TestAllAnalyzersHaveFactories and TestRandomChains to a global integration test and discover classes to check from mo

2022-01-05 Thread GitBox
uschindler commented on pull request #582: URL: https://github.com/apache/lucene/pull/582#issuecomment-1005701356 I moved the project now. If you git pull, clean all before, otherwise it will find leftover files on precommit -- This is an automated message from the Apache Git Service. To

[GitHub] [lucene] rmuir commented on pull request #582: LUCENE-10352: Convert TestAllAnalyzersHaveFactories and TestRandomChains to a global integration test and discover classes to check from module

2022-01-05 Thread GitBox
rmuir commented on pull request #582: URL: https://github.com/apache/lucene/pull/582#issuecomment-1005704825 if we can backport it, it is ideal. What is the harm? It is just tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [lucene] uschindler commented on pull request #582: LUCENE-10352: Convert TestAllAnalyzersHaveFactories and TestRandomChains to a global integration test and discover classes to check from mo

2022-01-05 Thread GitBox
uschindler commented on pull request #582: URL: https://github.com/apache/lucene/pull/582#issuecomment-1005709567 > if we can backport it, it is ideal. What is the harm? It is just tests. and it is running more often! :-) -- This is an automated message from the Apache Git Service.

[GitHub] [lucene] rmuir commented on a change in pull request #579: LUCENE-10283: Bump minimum required Java version to 17.

2022-01-05 Thread GitBox
rmuir commented on a change in pull request #579: URL: https://github.com/apache/lucene/pull/579#discussion_r778841370 ## File path: lucene/core/src/java/org/apache/lucene/util/LegacySecurityManager.java ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [lucene] ywelsch commented on a change in pull request #539: LUCENE-10291: Only read/write postings when there is at least one indexed field

2022-01-05 Thread GitBox
ywelsch commented on a change in pull request #539: URL: https://github.com/apache/lucene/pull/539#discussion_r778843210 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfos.java ## @@ -200,6 +204,11 @@ public boolean hasFreq() { return hasFreq; } +

[GitHub] [lucene] jpountz commented on a change in pull request #579: LUCENE-10283: Bump minimum required Java version to 17.

2022-01-05 Thread GitBox
jpountz commented on a change in pull request #579: URL: https://github.com/apache/lucene/pull/579#discussion_r778843532 ## File path: lucene/core/src/java/org/apache/lucene/util/LegacySecurityManager.java ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [lucene] ywelsch commented on a change in pull request #539: LUCENE-10291: Only read/write postings when there is at least one indexed field

2022-01-05 Thread GitBox
ywelsch commented on a change in pull request #539: URL: https://github.com/apache/lucene/pull/539#discussion_r778845058 ## File path: lucene/core/src/java/org/apache/lucene/index/SegmentMerger.java ## @@ -203,8 +203,13 @@ private void mergeTerms(SegmentWriteState segmentWrite

[GitHub] [lucene] rmuir commented on a change in pull request #579: LUCENE-10283: Bump minimum required Java version to 17.

2022-01-05 Thread GitBox
rmuir commented on a change in pull request #579: URL: https://github.com/apache/lucene/pull/579#discussion_r778849776 ## File path: lucene/core/src/java/org/apache/lucene/util/LegacySecurityManager.java ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [lucene] ywelsch commented on a change in pull request #539: LUCENE-10291: Only read/write postings when there is at least one indexed field

2022-01-05 Thread GitBox
ywelsch commented on a change in pull request #539: URL: https://github.com/apache/lucene/pull/539#discussion_r778852727 ## File path: lucene/core/src/test/org/apache/lucene/codecs/TestMinimalCodec.java ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [lucene] ywelsch commented on a change in pull request #539: LUCENE-10291: Only read/write postings when there is at least one indexed field

2022-01-05 Thread GitBox
ywelsch commented on a change in pull request #539: URL: https://github.com/apache/lucene/pull/539#discussion_r778853159 ## File path: lucene/core/src/test/org/apache/lucene/codecs/TestMinimalCodec.java ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [lucene] ywelsch commented on a change in pull request #539: LUCENE-10291: Only read/write postings when there is at least one indexed field

2022-01-05 Thread GitBox
ywelsch commented on a change in pull request #539: URL: https://github.com/apache/lucene/pull/539#discussion_r778853488 ## File path: lucene/core/src/test/org/apache/lucene/codecs/TestMinimalCodec.java ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [lucene] ywelsch commented on a change in pull request #539: LUCENE-10291: Only read/write postings when there is at least one indexed field

2022-01-05 Thread GitBox
ywelsch commented on a change in pull request #539: URL: https://github.com/apache/lucene/pull/539#discussion_r778853694 ## File path: lucene/core/src/test/org/apache/lucene/codecs/TestMinimalCodec.java ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [lucene] ywelsch commented on a change in pull request #539: LUCENE-10291: Only read/write postings when there is at least one indexed field

2022-01-05 Thread GitBox
ywelsch commented on a change in pull request #539: URL: https://github.com/apache/lucene/pull/539#discussion_r778853977 ## File path: lucene/core/src/test/org/apache/lucene/codecs/TestMinimalCodec.java ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [lucene] jpountz merged pull request #584: LUCENE-10355: Remove EMPTY LongValues in favor of LongValues#ZEROS

2022-01-05 Thread GitBox
jpountz merged pull request #584: URL: https://github.com/apache/lucene/pull/584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[jira] [Commented] (LUCENE-10355) Remove EMPTY LongValues in favor of LongValues#ZERO

2022-01-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469338#comment-17469338 ] ASF subversion and git services commented on LUCENE-10355: -- Co

[GitHub] [lucene] rmuir commented on pull request #579: LUCENE-10283: Bump minimum required Java version to 17.

2022-01-05 Thread GitBox
rmuir commented on pull request #579: URL: https://github.com/apache/lucene/pull/579#issuecomment-1005729803 > I've been wondering what to do with the security manager. If we're on Java 17, where it's officially deprecated, perhaps we should just get rid of it? I know it sounds terrible bu

[GitHub] [lucene] jpountz commented on a change in pull request #579: LUCENE-10283: Bump minimum required Java version to 17.

2022-01-05 Thread GitBox
jpountz commented on a change in pull request #579: URL: https://github.com/apache/lucene/pull/579#discussion_r778860305 ## File path: lucene/core/src/java/org/apache/lucene/util/LegacySecurityManager.java ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (LUCENE-10355) Remove EMPTY LongValues in favor of LongValues#ZERO

2022-01-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469349#comment-17469349 ] ASF subversion and git services commented on LUCENE-10355: -- Co

[jira] [Resolved] (LUCENE-10355) Remove EMPTY LongValues in favor of LongValues#ZERO

2022-01-05 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10355. --- Resolution: Fixed Thanks [~gf2121] ! > Remove EMPTY LongValues in favor of LongValues#ZERO

[jira] [Updated] (LUCENE-10355) Remove EMPTY LongValues in favor of LongValues#ZERO

2022-01-05 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-10355: -- Fix Version/s: 9.1 > Remove EMPTY LongValues in favor of LongValues#ZERO > --

[GitHub] [lucene] jpountz merged pull request #573: LUCENE-10343: Remove MyRandom in favor of test framework random

2022-01-05 Thread GitBox
jpountz merged pull request #573: URL: https://github.com/apache/lucene/pull/573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[jira] [Commented] (LUCENE-10343) Remove MyRandom in favor of test framework random

2022-01-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469353#comment-17469353 ] ASF subversion and git services commented on LUCENE-10343: -- Co

[GitHub] [lucene] uschindler merged pull request #582: LUCENE-10352: Convert TestAllAnalyzersHaveFactories and TestRandomChains to a global integration test and discover classes to check from module s

2022-01-05 Thread GitBox
uschindler merged pull request #582: URL: https://github.com/apache/lucene/pull/582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[GitHub] [lucene] jpountz commented on pull request #545: LUCENE-10319: make ForUtil#BLOCK_SIZE changeable

2022-01-05 Thread GitBox
jpountz commented on pull request #545: URL: https://github.com/apache/lucene/pull/545#issuecomment-1005739072 I'm a bit torn as this also makes the code harder to read with all these constants with complex names. -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (LUCENE-10352) Convert TestAllAnalyzersHaveFactories and TestRandomChains to a global integration test and discover classes to check from module system

2022-01-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469354#comment-17469354 ] ASF subversion and git services commented on LUCENE-10352: -- Co

[GitHub] [lucene] dweiss commented on pull request #579: LUCENE-10283: Bump minimum required Java version to 17.

2022-01-05 Thread GitBox
dweiss commented on pull request #579: URL: https://github.com/apache/lucene/pull/579#issuecomment-1005744351 I do have the same concerns but at the same time - if they remove the security manager entirely in, say, JDK 17+X then the code will stop compiling/ working anyway. Maybe these con

[jira] [Commented] (LUCENE-10352) Convert TestAllAnalyzersHaveFactories and TestRandomChains to a global integration test and discover classes to check from module system

2022-01-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469362#comment-17469362 ] ASF subversion and git services commented on LUCENE-10352: -- Co

[GitHub] [lucene] jpountz commented on pull request #541: LUCENE-10315: Speed up BKD leaf block ids codec by a 512 ints ForUtil

2022-01-05 Thread GitBox
jpountz commented on pull request #541: URL: https://github.com/apache/lucene/pull/541#issuecomment-1005745531 Nice. I wonder if we need to specialize for so many numbers of bits per value like we do for postings, or if we should only specialize for a few numbers of bits per value that are

[jira] [Resolved] (LUCENE-10352) Convert TestAllAnalyzersHaveFactories and TestRandomChains to a global integration test and discover classes to check from module system

2022-01-05 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler resolved LUCENE-10352. Fix Version/s: 9.1 10.0 (main) Resolution: Fixed We opened seve

[GitHub] [lucene] jpountz commented on a change in pull request #534: LUCENE-10183: KnnVectorsWriter#writeField to take KnnVectorsReader instead of VectorValues

2022-01-05 Thread GitBox
jpountz commented on a change in pull request #534: URL: https://github.com/apache/lucene/pull/534#discussion_r778880348 ## File path: lucene/core/src/test/org/apache/lucene/codecs/perfield/TestPerFieldKnnVectorsFormat.java ## @@ -172,9 +171,14 @@ public KnnVectorsWriter field

[GitHub] [lucene] uschindler commented on a change in pull request #579: LUCENE-10283: Bump minimum required Java version to 17.

2022-01-05 Thread GitBox
uschindler commented on a change in pull request #579: URL: https://github.com/apache/lucene/pull/579#discussion_r778881181 ## File path: lucene/core/src/java/org/apache/lucene/util/LegacySecurityManager.java ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [lucene] jpountz merged pull request #525: Modernize release announcement text.

2022-01-05 Thread GitBox
jpountz merged pull request #525: URL: https://github.com/apache/lucene/pull/525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [lucene] rmuir commented on pull request #579: LUCENE-10283: Bump minimum required Java version to 17.

2022-01-05 Thread GitBox
rmuir commented on pull request #579: URL: https://github.com/apache/lucene/pull/579#issuecomment-1005755345 I don't think the code is going to stop compiling, instead you will just "lose protection"? > In Java 18 and later, we will degrade other Security Manager APIs so that they

[GitHub] [lucene] jpountz merged pull request #529: Use CDN to download source release.

2022-01-05 Thread GitBox
jpountz merged pull request #529: URL: https://github.com/apache/lucene/pull/529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[jira] [Commented] (LUCENE-10343) Remove MyRandom in favor of test framework random

2022-01-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469370#comment-17469370 ] ASF subversion and git services commented on LUCENE-10343: -- Co

[GitHub] [lucene] uschindler commented on a change in pull request #579: LUCENE-10283: Bump minimum required Java version to 17.

2022-01-05 Thread GitBox
uschindler commented on a change in pull request #579: URL: https://github.com/apache/lucene/pull/579#discussion_r778883566 ## File path: lucene/misc/src/java/org/apache/lucene/misc/store/HardlinkCopyDirectoryWrapper.java ## @@ -66,7 +67,7 @@ public void copyFrom(Directory fro

[GitHub] [lucene] uschindler commented on a change in pull request #579: LUCENE-10283: Bump minimum required Java version to 17.

2022-01-05 Thread GitBox
uschindler commented on a change in pull request #579: URL: https://github.com/apache/lucene/pull/579#discussion_r778884007 ## File path: lucene/misc/src/java/org/apache/lucene/misc/store/HardlinkCopyDirectoryWrapper.java ## @@ -66,7 +67,7 @@ public void copyFrom(Directory fro

[jira] [Resolved] (LUCENE-10343) Remove MyRandom in favor of test framework random

2022-01-05 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10343. --- Fix Version/s: 9.1 Resolution: Fixed > Remove MyRandom in favor of test framework ra

[GitHub] [lucene] dweiss commented on pull request #579: LUCENE-10283: Bump minimum required Java version to 17.

2022-01-05 Thread GitBox
dweiss commented on pull request #579: URL: https://github.com/apache/lucene/pull/579#issuecomment-1005762127 Thanks for the pointer, Robert. I wonder what the "acceptable level" criteria are. ;) -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [lucene] rmuir commented on pull request #579: LUCENE-10283: Bump minimum required Java version to 17.

2022-01-05 Thread GitBox
rmuir commented on pull request #579: URL: https://github.com/apache/lucene/pull/579#issuecomment-1005769579 > Thanks for the pointer, Robert. I wonder what the "acceptable level" criteria are. ;) I wonder too, i searched some commonly used java libraries mainline branches (`guava`,

[jira] [Commented] (LUCENE-10157) Add Additional Indri Search Engine Functionality to Lucene

2022-01-05 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469380#comment-17469380 ] Adrien Grand commented on LUCENE-10157: --- If you don't mind, I would like to move

[GitHub] [lucene] jpountz merged pull request #539: LUCENE-10291: Only read/write postings when there is at least one indexed field

2022-01-05 Thread GitBox
jpountz merged pull request #539: URL: https://github.com/apache/lucene/pull/539 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[jira] [Commented] (LUCENE-10291) Only read/write postings when there is at least one indexed field

2022-01-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469383#comment-17469383 ] ASF subversion and git services commented on LUCENE-10291: -- Co

[GitHub] [lucene] ywelsch commented on pull request #539: LUCENE-10291: Only read/write postings when there is at least one indexed field

2022-01-05 Thread GitBox
ywelsch commented on pull request #539: URL: https://github.com/apache/lucene/pull/539#issuecomment-1005809668 Thanks @jpountz! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [lucene] uschindler commented on pull request #571: LUCENE-10328: Module path for compiling and running tests is wrong

2022-01-05 Thread GitBox
uschindler commented on pull request #571: URL: https://github.com/apache/lucene/pull/571#issuecomment-1005827412 > Please take a look at this comment/ chart, Uwe. https://issues.apache.org/jira/browse/LUCENE-10328?focusedCommentId=17468676&page=com.atlassian.jira.plugin.system.issuetabpane

[jira] [Commented] (LUCENE-10291) Only read/write postings when there is at least one indexed field

2022-01-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469389#comment-17469389 ] ASF subversion and git services commented on LUCENE-10291: -- Co

[jira] [Commented] (LUCENE-10291) Only read/write postings when there is at least one indexed field

2022-01-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469390#comment-17469390 ] ASF subversion and git services commented on LUCENE-10291: -- Co

[jira] [Resolved] (LUCENE-10291) Only read/write postings when there is at least one indexed field

2022-01-05 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10291. --- Fix Version/s: 9.1 Resolution: Fixed > Only read/write postings when there is at lea

[jira] [Commented] (LUCENE-10291) Only read/write postings when there is at least one indexed field

2022-01-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469388#comment-17469388 ] ASF subversion and git services commented on LUCENE-10291: -- Co

[jira] [Commented] (LUCENE-10291) Only read/write postings when there is at least one indexed field

2022-01-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469391#comment-17469391 ] ASF subversion and git services commented on LUCENE-10291: -- Co

[jira] [Commented] (LUCENE-10291) Only read/write postings when there is at least one indexed field

2022-01-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469392#comment-17469392 ] ASF subversion and git services commented on LUCENE-10291: -- Co

[GitHub] [lucene] uschindler commented on a change in pull request #571: LUCENE-10328: Module path for compiling and running tests is wrong

2022-01-05 Thread GitBox
uschindler commented on a change in pull request #571: URL: https://github.com/apache/lucene/pull/571#discussion_r778921454 ## File path: gradle/java/modules.gradle ## @@ -27,194 +29,167 @@ allprojects { modularity.inferModulePath.set(false) } -// Map conventi

[jira] [Commented] (LUCENE-10157) Add Additional Indri Search Engine Functionality to Lucene

2022-01-05 Thread Cameron VandenBerg (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469393#comment-17469393 ] Cameron VandenBerg commented on LUCENE-10157: - Hi [~jpountz], I would reall

[GitHub] [lucene] uschindler commented on a change in pull request #571: LUCENE-10328: Module path for compiling and running tests is wrong

2022-01-05 Thread GitBox
uschindler commented on a change in pull request #571: URL: https://github.com/apache/lucene/pull/571#discussion_r778922786 ## File path: gradle/java/modules.gradle ## @@ -27,194 +29,167 @@ allprojects { modularity.inferModulePath.set(false) } -// Map conventi

[GitHub] [lucene] uschindler commented on pull request #571: LUCENE-10328: Module path for compiling and running tests is wrong

2022-01-05 Thread GitBox
uschindler commented on pull request #571: URL: https://github.com/apache/lucene/pull/571#issuecomment-1005839073 I think you have to solve the conflicts caused by the change for running "gradlew beast". I leave that up to you. Maybe it works better after this branch is merged. -- This

[GitHub] [lucene] uschindler commented on a change in pull request #571: LUCENE-10328: Module path for compiling and running tests is wrong

2022-01-05 Thread GitBox
uschindler commented on a change in pull request #571: URL: https://github.com/apache/lucene/pull/571#discussion_r778924772 ## File path: gradle/documentation/render-javadoc.gradle ## @@ -57,7 +57,7 @@ allprojects { outputDir = project.javadoc.destinationDir } -

[GitHub] [lucene] uschindler commented on a change in pull request #571: LUCENE-10328: Module path for compiling and running tests is wrong

2022-01-05 Thread GitBox
uschindler commented on a change in pull request #571: URL: https://github.com/apache/lucene/pull/571#discussion_r778926381 ## File path: gradle/documentation/render-javadoc.gradle ## @@ -57,7 +57,7 @@ allprojects { outputDir = project.javadoc.destinationDir } -

[GitHub] [lucene] mayya-sharipova commented on pull request #536: Don't store graph offsets for HNSW graph

2022-01-05 Thread GitBox
mayya-sharipova commented on pull request #536: URL: https://github.com/apache/lucene/pull/536#issuecomment-1005844307 I've also run the comparison on a bigger dataset: deep-image-96-angular of 10M docs. M: 16; efConstruction: 500 Disk size before the change: 4.2G; after change: 4

[GitHub] [lucene] uschindler commented on a change in pull request #571: LUCENE-10328: Module path for compiling and running tests is wrong

2022-01-05 Thread GitBox
uschindler commented on a change in pull request #571: URL: https://github.com/apache/lucene/pull/571#discussion_r778930571 ## File path: gradle/java/modules.gradle ## @@ -27,194 +29,167 @@ allprojects { modularity.inferModulePath.set(false) } -// Map conventi

[GitHub] [lucene] uschindler commented on a change in pull request #571: LUCENE-10328: Module path for compiling and running tests is wrong

2022-01-05 Thread GitBox
uschindler commented on a change in pull request #571: URL: https://github.com/apache/lucene/pull/571#discussion_r778931152 ## File path: gradle/java/modules.gradle ## @@ -27,194 +29,167 @@ allprojects { modularity.inferModulePath.set(false) } -// Map conventi

[GitHub] [lucene] uschindler commented on a change in pull request #571: LUCENE-10328: Module path for compiling and running tests is wrong

2022-01-05 Thread GitBox
uschindler commented on a change in pull request #571: URL: https://github.com/apache/lucene/pull/571#discussion_r778925282 ## File path: gradle/documentation/render-javadoc.gradle ## @@ -57,7 +57,7 @@ allprojects { outputDir = project.javadoc.destinationDir } -

  1   2   >