ywelsch commented on a change in pull request #539: URL: https://github.com/apache/lucene/pull/539#discussion_r778853488
########## File path: lucene/core/src/test/org/apache/lucene/codecs/TestMinimalCodec.java ########## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.codecs; + +import static com.carrotsearch.randomizedtesting.RandomizedTest.randomBoolean; + +import java.io.IOException; +import org.apache.lucene.analysis.MockAnalyzer; +import org.apache.lucene.document.Document; +import org.apache.lucene.document.StoredField; +import org.apache.lucene.index.DirectoryReader; +import org.apache.lucene.index.IndexWriter; +import org.apache.lucene.index.IndexWriterConfig; +import org.apache.lucene.search.MatchAllDocsQuery; +import org.apache.lucene.store.BaseDirectoryWrapper; +import org.apache.lucene.util.LuceneTestCase; +import org.apache.lucene.util.TestUtil; + +/** + * Tests to ensure that {@link Codec}s won't need to implement all formats in case where only a + * small subset of Lucene's functionality is used. + */ +public class TestMinimalCodec extends LuceneTestCase { + + public void testMinimalCodec() throws IOException { + runMinimalCodecTest(false, false); + runMinimalCodecTest(false, true); + runMinimalCodecTest(true, true); + runMinimalCodecTest(true, false); + } + + private void runMinimalCodecTest(boolean useCompoundFile, boolean useDeletes) throws IOException { + try (BaseDirectoryWrapper dir = newDirectory()) { + dir.setCheckIndexOnClose(false); // MinimalCodec is not registered with SPI + + IndexWriterConfig writerConfig = + newIndexWriterConfig(new MockAnalyzer(random())) + .setCodec(new MinimalCodec(useCompoundFile, useDeletes)) + .setUseCompoundFile(useCompoundFile); + if (!useCompoundFile) { + writerConfig.getMergePolicy().setNoCFSRatio(0.0); + writerConfig.getMergePolicy().setMaxCFSSegmentSizeMB(Double.POSITIVE_INFINITY); + } + + int expectedNumDocs = 0; + try (IndexWriter writer = new IndexWriter(dir, writerConfig)) { + writer.addDocument(basicDocument()); + expectedNumDocs += 1; + writer.flush(); // create second segment + if (useDeletes && randomBoolean()) { + writer.deleteDocuments(new MatchAllDocsQuery()); + expectedNumDocs = 0; + } + writer.addDocument(basicDocument()); + expectedNumDocs += 1; + writer.forceMerge(1); // test merges + if (useDeletes && randomBoolean()) { + writer.deleteDocuments(new MatchAllDocsQuery()); Review comment: I've removed all this in d0a9f8c. It wasn't necessary to test my livedocs changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
