dweiss commented on a change in pull request #571:
URL: https://github.com/apache/lucene/pull/571#discussion_r778714972
##########
File path: gradle/validation/validate-source-patterns.gradle
##########
@@ -154,12 +154,11 @@ class ValidateSourcePatternsTask extends DefaultTask {
(~$/\n\s*var\s+.*=.*<>.*/$) : 'Diamond operators should not be used with
var'
]
- def found = 0;
def violations = new TreeSet();
def reportViolation = { f, name ->
- logger.error('{}: {}', name, f);
- violations.add(name);
- found++;
+ String msg = String.format(Locale.ROOT, "%s: %s", f, name)
Review comment:
Yes. There are a few of these unrelated small things piggybacked here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
