[
https://issues.apache.org/jira/browse/LUCENE-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465582#comment-17465582
]
Tomoko Uchida commented on LUCENE-10339:
I run a little sanity check code. Alth
[
https://issues.apache.org/jira/browse/LUCENE-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465582#comment-17465582
]
Tomoko Uchida edited comment on LUCENE-10339 at 12/27/21, 8:47 AM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465582#comment-17465582
]
Tomoko Uchida edited comment on LUCENE-10339 at 12/27/21, 8:49 AM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465583#comment-17465583
]
ASF subversion and git services commented on LUCENE-10338:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465585#comment-17465585
]
ASF subversion and git services commented on LUCENE-10338:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465590#comment-17465590
]
Uwe Schindler commented on LUCENE-10339:
I can explain this:
You can reflectiv
[
https://issues.apache.org/jira/browse/LUCENE-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465598#comment-17465598
]
Tomoko Uchida commented on LUCENE-10339:
{quote}It looks like the hotspot VM lo
[
https://issues.apache.org/jira/browse/LUCENE-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465603#comment-17465603
]
Tomoko Uchida commented on LUCENE-10339:
If that's the case, once the PR gains
mocobeta commented on a change in pull request #568:
URL: https://github.com/apache/lucene/pull/568#discussion_r775411413
##
File path: lucene/core/src/java/module-info.java
##
@@ -19,6 +19,7 @@
@SuppressWarnings("module") // the test framework is compiled after the core...
m
[
https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465416#comment-17465416
]
Feng Guo edited comment on LUCENE-10334 at 12/27/21, 9:35 AM:
---
[
https://issues.apache.org/jira/browse/LUCENE-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465625#comment-17465625
]
Uwe Schindler commented on LUCENE-10339:
bq. Thank you - if this is "undocument
[
https://issues.apache.org/jira/browse/LUCENE-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465632#comment-17465632
]
Uwe Schindler commented on LUCENE-10339:
The optional declaration won't change
uschindler commented on a change in pull request #568:
URL: https://github.com/apache/lucene/pull/568#discussion_r775421284
##
File path: lucene/core/src/java/module-info.java
##
@@ -19,6 +19,7 @@
@SuppressWarnings("module") // the test framework is compiled after the core...
uschindler commented on a change in pull request #568:
URL: https://github.com/apache/lucene/pull/568#discussion_r775421284
##
File path: lucene/core/src/java/module-info.java
##
@@ -19,6 +19,7 @@
@SuppressWarnings("module") // the test framework is compiled after the core...
uschindler commented on a change in pull request #568:
URL: https://github.com/apache/lucene/pull/568#discussion_r775421284
##
File path: lucene/core/src/java/module-info.java
##
@@ -19,6 +19,7 @@
@SuppressWarnings("module") // the test framework is compiled after the core...
[
https://issues.apache.org/jira/browse/LUCENE-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465644#comment-17465644
]
Tomoko Uchida commented on LUCENE-10339:
I should have explained more clearly.
gf2121 removed a comment on pull request #557:
URL: https://github.com/apache/lucene/pull/557#issuecomment-999516790
Hi @rmuir @jpountz , Thanks a lot for all talking about this! ~~I think we
**probably** find out a better way there:~~
--
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465655#comment-17465655
]
Dawid Weiss commented on LUCENE-10328:
--
Filed a draft PR that passes check here:
h
mocobeta merged pull request #568:
URL: https://github.com/apache/lucene/pull/568
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
[
https://issues.apache.org/jira/browse/LUCENE-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465658#comment-17465658
]
ASF subversion and git services commented on LUCENE-10339:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465659#comment-17465659
]
ASF subversion and git services commented on LUCENE-10339:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida resolved LUCENE-10339.
Resolution: Fixed
> Add require derective for jdk.management to core's module descriptor.
[
https://issues.apache.org/jira/browse/LUCENE-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465671#comment-17465671
]
Tomoko Uchida commented on LUCENE-10339:
I pushed it to main and branch_9x. Tha
[
https://issues.apache.org/jira/browse/LUCENE-8739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465718#comment-17465718
]
Praveen Nishchal commented on LUCENE-8739:
--
Added dictionary support for Zstand
[
https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465416#comment-17465416
]
Feng Guo edited comment on LUCENE-10334 at 12/27/21, 11:42 AM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465760#comment-17465760
]
Uwe Schindler commented on LUCENE-10339:
bq. Can I ask a silly question... from
Uwe Schindler created LUCENE-10342:
--
Summary: Add (very limited) java.util.logging to Lucene Core
Key: LUCENE-10342
URL: https://issues.apache.org/jira/browse/LUCENE-10342
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465762#comment-17465762
]
Uwe Schindler commented on LUCENE-10339:
bq. I think it would be good to emit i
[
https://issues.apache.org/jira/browse/LUCENE-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-10342:
---
Priority: Critical (was: Major)
> Add (very limited) java.util.logging to Lucene Core
> --
[
https://issues.apache.org/jira/browse/LUCENE-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-10342:
---
Description:
At the moment we have some parts in Lucene where we check for features of the
[
https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465416#comment-17465416
]
Feng Guo edited comment on LUCENE-10334 at 12/27/21, 2:30 PM:
---
[
https://issues.apache.org/jira/browse/LUCENE-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-10342:
---
Description:
At the moment we have some parts in Lucene where we check for features of the
[
https://issues.apache.org/jira/browse/LUCENE-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465770#comment-17465770
]
Dawid Weiss commented on LUCENE-10342:
--
I'm fine with adding such warnings.
> Add
[
https://issues.apache.org/jira/browse/LUCENE-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465783#comment-17465783
]
Uwe Schindler commented on LUCENE-10342:
I'd like to add: On normal circumstanc
[
https://issues.apache.org/jira/browse/LUCENE-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465783#comment-17465783
]
Uwe Schindler edited comment on LUCENE-10342 at 12/27/21, 3:15 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465784#comment-17465784
]
Tomoko Uchida commented on LUCENE-10339:
{quote}Sure,answer: It depends. Most p
[
https://issues.apache.org/jira/browse/LUCENE-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465786#comment-17465786
]
Uwe Schindler commented on LUCENE-10342:
In my personal opinion, I'd also want
[
https://issues.apache.org/jira/browse/LUCENE-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465788#comment-17465788
]
Uwe Schindler commented on LUCENE-10342:
Oh, I just noticed: we already have so
[
https://issues.apache.org/jira/browse/LUCENE-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465795#comment-17465795
]
Tomoko Uchida commented on LUCENE-10342:
Some analysis modules that take user-p
[
https://issues.apache.org/jira/browse/LUCENE-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465796#comment-17465796
]
Uwe Schindler commented on LUCENE-10342:
bq. Some analysis modules that take us
[
https://issues.apache.org/jira/browse/LUCENE-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465798#comment-17465798
]
Tomoko Uchida commented on LUCENE-10342:
Sorry, I mean that if core has such lo
[
https://issues.apache.org/jira/browse/LUCENE-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465807#comment-17465807
]
Uwe Schindler commented on LUCENE-10342:
I won't add a logging utility, just a
[
https://issues.apache.org/jira/browse/LUCENE-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465807#comment-17465807
]
Uwe Schindler edited comment on LUCENE-10342 at 12/27/21, 4:33 PM:
--
Feng Guo created LUCENE-10343:
-
Summary: Remove MyRandom in favor of test framework random
Key: LUCENE-10343
URL: https://issues.apache.org/jira/browse/LUCENE-10343
Project: Lucene - Core
Issue T
uschindler opened a new pull request #572:
URL: https://github.com/apache/lucene/pull/572
Also give hints how to fix. This also removes the hard requirement to
"jdk.unsupported" module. This now causes Luke (it's a good test to log the
warning in the UI -> @mocobeta).
See https://i
[
https://issues.apache.org/jira/browse/LUCENE-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465810#comment-17465810
]
Uwe Schindler commented on LUCENE-10342:
PR: https://github.com/apache/lucene/p
uschindler commented on a change in pull request #572:
URL: https://github.com/apache/lucene/pull/572#discussion_r775574824
##
File path:
lucene/test-framework/src/java/org/apache/lucene/tests/util/LuceneTestCase.java
##
@@ -554,7 +554,7 @@ public boolean shouldCache(Query que
gf2121 commented on a change in pull request #570:
URL: https://github.com/apache/lucene/pull/570#discussion_r775575279
##
File path:
lucene/core/src/test/org/apache/lucene/util/packed/TestDirectForward.java
##
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the Apache Software Foundati
uschindler commented on pull request #572:
URL: https://github.com/apache/lucene/pull/572#issuecomment-1001653961
@dweiss: The core modular test still succeeeds, although the jdk.unsupported
module is not added with "requires", but "requires static". I have no idea why
this is so. Could it
[
https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Feng Guo updated LUCENE-10334:
--
Description:
Previous talk is here: [https://github.com/apache/lucene/pull/557]
This is trying to ad
dweiss commented on pull request #572:
URL: https://github.com/apache/lucene/pull/572#issuecomment-1001709855
bq. Could it be that Gradle adds jdk.unsupported by default when starting
test runner?
You can run gradle with debug option and see what the test worker command
line is, I r
uschindler commented on pull request #572:
URL: https://github.com/apache/lucene/pull/572#issuecomment-1001711869
> bq. Could it be that Gradle adds jdk.unsupported by default when starting
test runner?
>
> You can run gradle with debug option and see what the test worker command
li
uschindler commented on pull request #572:
URL: https://github.com/apache/lucene/pull/572#issuecomment-1001711979
I added a for-convenience InfoStream implementation using JUL logging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dweiss commented on pull request #572:
URL: https://github.com/apache/lucene/pull/572#issuecomment-1001716181
bq. If I remove the requires directive completey, it fails. So it looks like
the following is happening: the ALL-MODULE-PATH makes it visible to the module
layer. Because it is vis
uschindler commented on pull request #572:
URL: https://github.com/apache/lucene/pull/572#issuecomment-1001719710
> bq. If I remove the requires directive completey, it fails. So it looks
like the following is happening: the ALL-MODULE-PATH makes it visible to the
module layer. Because it
dweiss commented on pull request #572:
URL: https://github.com/apache/lucene/pull/572#issuecomment-1001722359
The rules are described in java.lang.module package - it seems that "Step 1"
they talk about when discussing requires static would resolve static modules in
the presence of any aut
dweiss commented on pull request #572:
URL: https://github.com/apache/lucene/pull/572#issuecomment-1001725659
Yeah, something is pulling that module into the set of loaded modules.
Interesting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
rmuir commented on a change in pull request #572:
URL: https://github.com/apache/lucene/pull/572#discussion_r775699604
##
File path: lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java
##
@@ -343,6 +344,9 @@ private IOException convertMapFailedIOException(
CL
rmuir commented on a change in pull request #572:
URL: https://github.com/apache/lucene/pull/572#discussion_r77571
##
File path: lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java
##
@@ -343,6 +344,9 @@ private IOException convertMapFailedIOException(
CL
[
https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465310#comment-17465310
]
Feng Guo edited comment on LUCENE-10334 at 12/28/21, 4:22 AM:
---
[
https://issues.apache.org/jira/browse/LUCENE-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465964#comment-17465964
]
Tomoko Uchida commented on LUCENE-10339:
True - "jdk.management" and "java.mana
[
https://issues.apache.org/jira/browse/LUCENE-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465979#comment-17465979
]
Tomoko Uchida commented on LUCENE-10339:
It seems "requires [static] jdk.manage
62 matches
Mail list logo
