dweiss commented on pull request #572: URL: https://github.com/apache/lucene/pull/572#issuecomment-1001716181
bq. If I remove the requires directive completey, it fails. So it looks like the following is happening: the ALL-MODULE-PATH makes it visible to the module layer. Because it is visible there, the JDK adds it and the optional dependency gets resolved and satisfied. But I am just guessing. Hmm... but isn't requires static going to include the module, if it's available in the module graph (even if it's not explicitly added)? If you remove it completely - it fails and this seems to be fine. If you add it as a requires static, it should be included because it is available in the pool of modules. I think it works as intended? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
