uschindler commented on a change in pull request #568:
URL: https://github.com/apache/lucene/pull/568#discussion_r775421284
##########
File path: lucene/core/src/java/module-info.java
##########
@@ -19,6 +19,7 @@
@SuppressWarnings("module") // the test framework is compiled after the core...
module org.apache.lucene.core {
requires jdk.unsupported; // this is needed for MMapDirectory to unmap
+ requires static jdk.management; // this is needed to make RamUsageEstimator
correctly works
Review comment:
We should also add comment that it is optional, but recommended.
I don't like the term "static" as it does not imply "optional" to the user.
But that's java's decision, I just hate it. Does anybody know what "static"
means in this context, maybe my English is missing context?!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]