[
https://issues.apache.org/jira/browse/LUCENE-10319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461367#comment-17461367
]
Feng Guo edited comment on LUCENE-10319 at 12/19/21, 9:25 AM:
---
[
https://issues.apache.org/jira/browse/LUCENE-10327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462148#comment-17462148
]
ASF subversion and git services commented on LUCENE-10327:
--
Co
Dawid Weiss created LUCENE-10328:
Summary: Module path for compiling and running tests is empty
Key: LUCENE-10328
URL: https://issues.apache.org/jira/browse/LUCENE-10328
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462152#comment-17462152
]
Dawid Weiss commented on LUCENE-10328:
--
I'm not so sure it'll be possible to place
[
https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462153#comment-17462153
]
Dawid Weiss commented on LUCENE-10328:
--
Exactly.
{code:java}
> Task :lucene:codecs
[
https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462157#comment-17462157
]
Uwe Schindler commented on LUCENE-10328:
To make this work we must use Patch-Mo
[
https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462157#comment-17462157
]
Uwe Schindler edited comment on LUCENE-10328 at 12/19/21, 11:51 AM:
-
[
https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462158#comment-17462158
]
Uwe Schindler commented on LUCENE-10328:
bq. Maven does it, I was part of the m
[
https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462159#comment-17462159
]
Dawid Weiss commented on LUCENE-10328:
--
I would rather fix the test framework to b
[
https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462160#comment-17462160
]
Uwe Schindler commented on LUCENE-10328:
Still test tests of a module itself ne
[
https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462166#comment-17462166
]
Dawid Weiss commented on LUCENE-10328:
--
True. You can work around this by placing
[
https://issues.apache.org/jira/browse/LUCENE-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida reassigned LUCENE-8930:
-
Assignee: (was: Tomoko Uchida)
> Integrate Luke app health check to nightly tests (
[
https://issues.apache.org/jira/browse/LUCENE-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462167#comment-17462167
]
Dawid Weiss commented on LUCENE-10301:
--
I started playing by just moving stuff. St
[
https://issues.apache.org/jira/browse/LUCENE-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462168#comment-17462168
]
Tomoko Uchida commented on LUCENE-8930:
---
Thank you - the work seems almost complet
[
https://issues.apache.org/jira/browse/LUCENE-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462170#comment-17462170
]
Dawid Weiss commented on LUCENE-8930:
-
Please do continue, Tomoko. I don't think it'
[
https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462220#comment-17462220
]
Uwe Schindler commented on LUCENE-10328:
bq. True. You can work around this by
[
https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462220#comment-17462220
]
Uwe Schindler edited comment on LUCENE-10328 at 12/19/21, 3:48 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462220#comment-17462220
]
Uwe Schindler edited comment on LUCENE-10328 at 12/19/21, 3:48 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462220#comment-17462220
]
Uwe Schindler edited comment on LUCENE-10328 at 12/19/21, 3:48 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462223#comment-17462223
]
Dawid Weiss commented on LUCENE-10328:
--
Sure. I find this sequence quite reasonabl
apanimesh061 commented on a change in pull request #412:
URL: https://github.com/apache/lucene/pull/412#discussion_r771973219
##
File path:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java
##
@@ -360,14 +451,104 @@ public UnifiedHighlight
apanimesh061 commented on a change in pull request #412:
URL: https://github.com/apache/lucene/pull/412#discussion_r771974822
##
File path:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java
##
@@ -383,6 +564,15 @@ public UnifiedHighlighter
apanimesh061 commented on a change in pull request #412:
URL: https://github.com/apache/lucene/pull/412#discussion_r771974831
##
File path:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java
##
@@ -97,6 +97,23 @@
public static final in
apanimesh061 commented on pull request #412:
URL: https://github.com/apache/lucene/pull/412#issuecomment-997424641
@dsmiley I've made the suggested modifications.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
dsmiley merged pull request #412:
URL: https://github.com/apache/lucene/pull/412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
[
https://issues.apache.org/jira/browse/LUCENE-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462242#comment-17462242
]
ASF subversion and git services commented on LUCENE-10197:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462243#comment-17462243
]
ASF subversion and git services commented on LUCENE-10197:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved LUCENE-10197.
---
Fix Version/s: 9.1
Resolution: Fixed
Woohoo; thanks Animesh!
> UnifiedHighlighter s
[
https://issues.apache.org/jira/browse/LUCENE-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462291#comment-17462291
]
Animesh Pandey commented on LUCENE-10197:
-
Thanks a lot David for helping me ou
[
https://issues.apache.org/jira/browse/LUCENE-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462291#comment-17462291
]
Animesh Pandey edited comment on LUCENE-10197 at 12/19/21, 8:22 PM:
-
[
https://issues.apache.org/jira/browse/LUCENE-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462295#comment-17462295
]
David Smiley commented on LUCENE-10197:
---
Both paths are viable (do now or do late
zacharymorn commented on pull request #534:
URL: https://github.com/apache/lucene/pull/534#issuecomment-997458442
Hi @jpountz @msokolov @jtibshirani , just want to check back on this and see
if the changes look good?
--
This is an automated message from the Apache Git Service.
To respond
zacharymorn commented on pull request #456:
URL: https://github.com/apache/lucene/pull/456#issuecomment-997458592
> > Hmm actually this issue was fixed in 9.0.0, I think?
>
> This change entry is for
[07ee3ba#diff-27a1984493254d0af3e9c50caee47443abbbdc79a87b4c348300bcb317a0a5b2](http
zacharymorn commented on pull request #418:
URL: https://github.com/apache/lucene/pull/418#issuecomment-997460370
> > These numbers are super interesting. Let's go with the approach of you
baseline for now since it performs better, sorry for putting you on a track
that performs worse. :)
[
https://issues.apache.org/jira/browse/LUCENE-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462301#comment-17462301
]
Dawid Weiss commented on LUCENE-10301:
--
[https://github.com/apache/lucene/pull/551
mikemccand commented on pull request #456:
URL: https://github.com/apache/lucene/pull/456#issuecomment-997473896
Aha, perfect, looks great! +1 to push. Sorry for the delay @zacharymorn.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
mikemccand commented on pull request #518:
URL: https://github.com/apache/lucene/pull/518#issuecomment-997480562
> Take your time and enjoy the complexity of setting this up! ;-)
LOL! OK I will try to test this @uschindler :)
--
This is an automated message from the Apache Git Ser
zacharymorn commented on pull request #456:
URL: https://github.com/apache/lucene/pull/456#issuecomment-997616583
> Aha, perfect, looks great! +1 to push. Sorry for the delay @zacharymorn.
No problem! Thanks for the review and approval!
--
This is an automated message from the Apac
zacharymorn merged pull request #456:
URL: https://github.com/apache/lucene/pull/456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubs
[
https://issues.apache.org/jira/browse/LUCENE-10236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462398#comment-17462398
]
ASF subversion and git services commented on LUCENE-10236:
--
Co
zacharymorn commented on pull request #444:
URL: https://github.com/apache/lucene/pull/444#issuecomment-997621234
> Will backport this to 8.11 and 8x.
Hi @jimczi @jtibshirani @mikemccand, just to confirm as I saw there was a
thread on the proper handling of `branch_8x`, this change s
[
https://issues.apache.org/jira/browse/LUCENE-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462434#comment-17462434
]
Tomoko Uchida commented on LUCENE-8930:
---
I will try to take a look this week. I mi
42 matches
Mail list logo
