[
https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462157#comment-17462157
]
Uwe Schindler edited comment on LUCENE-10328 at 12/19/21, 11:51 AM:
--------------------------------------------------------------------
To make this work we must use Patch-Module to inject test-framework into core.
Also when running tests, the test classes of the tested module must be patched
inside the tested module itself. This is why module patching was invented:
patch test classes into the module where they belong to, so they can access
private code.
I think that's doable (Maven does it, I was part of the meetings with Mark
Reinhold and Alan Bateman). We just need a hack for test framework:
- test-framework must be patched into core
- tests of a module must be patched into the module actually tested.
was (Author: thetaphi):
To make this work we must use Patch-Module to inject test-framework into core.
Also when running tests, the test classes of the tested module must be patched
inside the tested module itself. This is why module patching was invented:
patch test classes into the module where they belong to, so they can access
private code.
I think that's doable (Maven does it, I was part of the meetings with Mark
Reinhold and Alan Bateman). We just need a hack for test framework:
- test framework must be patched into core
- test of a module must be patched into the module actually tested.
> Module path for compiling and running tests is empty
> ----------------------------------------------------
>
> Key: LUCENE-10328
> URL: https://issues.apache.org/jira/browse/LUCENE-10328
> Project: Lucene - Core
> Issue Type: Sub-task
> Reporter: Dawid Weiss
> Priority: Major
> Attachments: image-2021-12-19-12-29-21-737.png
>
>
> Uwe noticed that the module path for compiling and running tests is empty -
> indeed, the modular configurations we create for the test sourceset do not
> inherit from their main counterparts. This is not a standard thing created
> for a sourceset - the test-main connection link is created by gradle's java
> plugin. We need to do a similar thing for modular configurations.
> !image-2021-12-19-12-29-21-737.png|width=490,height=280!
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
