[
https://issues.apache.org/jira/browse/LUCENE-10234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451609#comment-17451609
]
Adrien Grand commented on LUCENE-10234:
---
[~uschindler] [~dweiss] It looks like th
jpountz commented on a change in pull request #438:
URL: https://github.com/apache/lucene/pull/438#discussion_r759955885
##
File path:
lucene/core/src/java/org/apache/lucene/util/DocBaseBitSetIterator.java
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation
jpountz commented on pull request #438:
URL: https://github.com/apache/lucene/pull/438#issuecomment-983424947
Can you also add a CHANGES entry?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
[
https://issues.apache.org/jira/browse/LUCENE-9619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451626#comment-17451626
]
Adrien Grand commented on LUCENE-9619:
--
Thanks for explaining, I had misunderstood
[
https://issues.apache.org/jira/browse/LUCENE-10234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451627#comment-17451627
]
Dawid Weiss commented on LUCENE-10234:
--
I'm looking.
> Add automatic module name
[
https://issues.apache.org/jira/browse/LUCENE-10234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451633#comment-17451633
]
ASF subversion and git services commented on LUCENE-10234:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451635#comment-17451635
]
Dawid Weiss commented on LUCENE-10234:
--
I've committed the correction to the main
mocobeta commented on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-983437872
I just added the module descriptor for analysis-common for PoC. (It's
actually not a merge request, but let me know if other analysis modules'
module-info should be added in a sim
[
https://issues.apache.org/jira/browse/LUCENE-10234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451646#comment-17451646
]
Dawid Weiss commented on LUCENE-10234:
--
I accidentally ran on main and received th
[
https://issues.apache.org/jira/browse/LUCENE-10234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451648#comment-17451648
]
ASF subversion and git services commented on LUCENE-10234:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-9619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451654#comment-17451654
]
Ignacio Vera commented on LUCENE-9619:
--
PR is here: https://github.com/apache/lucen
mocobeta commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r760003976
##
File path: lucene/analysis/common/src/java-module/module-info.java
##
@@ -0,0 +1,202 @@
+module lucene.analysis.common {
Review comment:
ah sorry
mocobeta commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r760004851
##
File path: lucene/analysis/common/src/java-module/module-info.java
##
@@ -0,0 +1,202 @@
+module lucene.analysis.common {
Review comment:
```sugge
[
https://issues.apache.org/jira/browse/LUCENE-10234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451667#comment-17451667
]
ASF subversion and git services commented on LUCENE-10234:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451666#comment-17451666
]
Dawid Weiss commented on LUCENE-10234:
--
SUCCESS! [0:09:44.638025] on branch_9_0.
uschindler commented on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-983474638
Hi @mocobeta, could you merge in "main" before adding the module-infos to
get the new module names?
--
This is an automated message from the Apache Git Service.
To respond to
mocobeta commented on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-983477848
Ah yes, will do so next time. I resolved the conflict manually, this time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
mocobeta commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r760033097
##
File path: lucene/luke/src/java-module/module-info.java
##
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
iverase opened a new pull request #498:
URL: https://github.com/apache/lucene/pull/498
Use interval tree to speed up query execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
uschindler commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r760035701
##
File path: lucene/luke/src/java-module/module-info.java
##
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
Ignacio Vera created LUCENE-10275:
-
Summary: Use interval tree in MultiRangeQuery
Key: LUCENE-10275
URL: https://issues.apache.org/jira/browse/LUCENE-10275
Project: Lucene - Core
Issue Type:
uschindler commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r760039970
##
File path: lucene/luke/src/java-module/module-info.java
##
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
[
https://issues.apache.org/jira/browse/LUCENE-10234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451694#comment-17451694
]
Adrien Grand commented on LUCENE-10234:
---
bq. I accidentally ran on main and recei
mocobeta commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r760046354
##
File path: lucene/luke/src/java-module/module-info.java
##
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
[
https://issues.apache.org/jira/browse/LUCENE-10234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451695#comment-17451695
]
Adrien Grand commented on LUCENE-10234:
---
Actually Dawid identified the problem: 8
rmuir merged pull request #491:
URL: https://github.com/apache/lucene/pull/491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
[
https://issues.apache.org/jira/browse/LUCENE-10270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451700#comment-17451700
]
ASF subversion and git services commented on LUCENE-10270:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451701#comment-17451701
]
ASF subversion and git services commented on LUCENE-10270:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir resolved LUCENE-10270.
--
Resolution: Fixed
> Improve MIGRATE.md
> --
>
> Key: LUCENE-1
dweiss commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r760060709
##
File path: lucene/luke/src/java-module/module-info.java
##
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
mocobeta merged pull request #496:
URL: https://github.com/apache/lucene/pull/496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
gf2121 commented on a change in pull request #438:
URL: https://github.com/apache/lucene/pull/438#discussion_r760082305
##
File path:
lucene/core/src/java/org/apache/lucene/util/DocBaseBitSetIterator.java
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (
gf2121 commented on a change in pull request #438:
URL: https://github.com/apache/lucene/pull/438#discussion_r760082798
##
File path: lucene/core/src/java/org/apache/lucene/util/bkd/DocIdsWriter.java
##
@@ -18,23 +18,32 @@
import java.io.IOException;
import org.apache.lucen
gf2121 commented on pull request #438:
URL: https://github.com/apache/lucene/pull/438#issuecomment-983562338
@jpountz Thanks a lot for the great advices! I have fixed them and added a
CHANGES entry.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
[
https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Feng Guo updated LUCENE-10233:
--
Description:
In low cardinality points cases, id blocks will usually store doc ids that have
the sam
sonatype-lift[bot] commented on a change in pull request #438:
URL: https://github.com/apache/lucene/pull/438#discussion_r760188396
##
File path: lucene/core/src/java/org/apache/lucene/util/bkd/DocIdsWriter.java
##
@@ -85,10 +103,64 @@ static void writeDocIds(int[] docIds, int
mocobeta commented on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-983653505
I happened to have free time this week, I think I'll be able to complete all
lucene/analysis module descriptors.
Have a question - do we expose all existing packages for now? Or
mocobeta edited a comment on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-983653505
I happened to have free time this week, I think I'll be able to complete all
lucene/analysis module descriptors.
Have a question - do we expose all existing packages for
jpountz merged pull request #438:
URL: https://github.com/apache/lucene/pull/438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
[
https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451865#comment-17451865
]
ASF subversion and git services commented on LUCENE-10233:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451870#comment-17451870
]
Tomoko Uchida commented on LUCENE-10261:
With a series of recent commits on mai
[
https://issues.apache.org/jira/browse/LUCENE-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451873#comment-17451873
]
Dawid Weiss commented on LUCENE-10261:
--
There are ways to scan modules as well...
jpountz commented on pull request #438:
URL: https://github.com/apache/lucene/pull/438#issuecomment-983728887
The backport has some test failures that look related to the change of
endianness, I'm seeing DocIdsWriter write longs in a given byte order and then
read them in the opposite byte
dweiss commented on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-983738619
For this PR I think we should strive for full openness, simulating classpath
pretty much 1:1. A follow-up, once this is integrated, would be to start
limiting the scope of packages.
uschindler commented on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-983743592
> I happened to have free time this week, I think I'll be able to complete
all lucene/analysis module descriptors. Have a question - do we expose all
existing packages for now?
dweiss commented on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-983749260
> Javadoc should only show exported packages, so hiding some would make them
at moment still appear in javadocs.
Yeah... there's more to it than just javadoc... Lots of tiny t
Angadpreet Nagpal created LUCENE-10276:
--
Summary: Turning LRUQueryCache On selectively for only a few query
classes
Key: LUCENE-10276
URL: https://issues.apache.org/jira/browse/LUCENE-10276
Proje
rmuir commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r760348297
##
File path: lucene/analysis/common/src/java-module/module-info.java
##
@@ -0,0 +1,217 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
gf2121 opened a new pull request #499:
URL: https://github.com/apache/lucene/pull/499
This is a follow up of #438. I find that `intersector` has some 'inversing'
usage, we can use ` AND NOT ` to speed up the bitset situation.
--
This is an automated message from the Apache Git Service.
T
dweiss commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r760361043
##
File path: lucene/analysis/common/src/java-module/module-info.java
##
@@ -0,0 +1,217 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
[
https://issues.apache.org/jira/browse/LUCENE-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451924#comment-17451924
]
Adrien Grand commented on LUCENE-10276:
---
Actually KnnQuery is unlikely to get eve
jpountz merged pull request #468:
URL: https://github.com/apache/lucene/pull/468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
[
https://issues.apache.org/jira/browse/LUCENE-10253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451925#comment-17451925
]
ASF subversion and git services commented on LUCENE-10253:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-10253.
---
Fix Version/s: 10.0 (main)
Resolution: Fixed
> Remove BadApple test annotation
> ---
[
https://issues.apache.org/jira/browse/LUCENE-10275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451932#comment-17451932
]
Adrien Grand commented on LUCENE-10275:
---
+1
> Use interval tree in MultiRangeQue
[
https://issues.apache.org/jira/browse/LUCENE-10269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451935#comment-17451935
]
Adrien Grand commented on LUCENE-10269:
---
Actually the fact the we require values
jpountz commented on pull request #418:
URL: https://github.com/apache/lucene/pull/418#issuecomment-983918448
> from the perf results so far, it seems using the most weighted field to
decide on the leading impacts may not yield the best result
> Are you trying to see if perf tests can be
[
https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451947#comment-17451947
]
Feng Guo commented on LUCENE-10233:
---
Hi [~jpountz] I find that {{intersector}} has so
rmuir commented on pull request #497:
URL: https://github.com/apache/lucene/pull/497#issuecomment-983925740
> What version are you targeting for the removal? 10.0?
i was thinking to just deprecate, we could revisit the deprecation for 11?
--
This is an automated message from the A
jpountz commented on pull request #497:
URL: https://github.com/apache/lucene/pull/497#issuecomment-983926628
:+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
Dawid Weiss created LUCENE-10277:
Summary: Add a sanity check of consistency between services
provided by the modular and classpath layer
Key: LUCENE-10277
URL: https://issues.apache.org/jira/browse/LUCENE-10277
sonatype-lift[bot] commented on a change in pull request #499:
URL: https://github.com/apache/lucene/pull/499#discussion_r760497387
##
File path:
lucene/core/src/java/org/apache/lucene/document/LatLonPointDistanceQuery.java
##
@@ -295,6 +295,12 @@ public void visit(int docID)
rmuir merged pull request #497:
URL: https://github.com/apache/lucene/pull/497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
[
https://issues.apache.org/jira/browse/LUCENE-10273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451986#comment-17451986
]
ASF subversion and git services commented on LUCENE-10273:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451998#comment-17451998
]
ASF subversion and git services commented on LUCENE-10273:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir resolved LUCENE-10273.
--
Fix Version/s: 9.1
Resolution: Fixed
> Deprecate SpanishMinimalStemFilter in favor of
dweiss commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r760554212
##
File path: lucene/analysis/common/src/java-module/module-info.java
##
@@ -0,0 +1,217 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
TomMD commented on a change in pull request #499:
URL: https://github.com/apache/lucene/pull/499#discussion_r760557339
##
File path: lucene/core/src/java/org/apache/lucene/util/FixedBitSet.java
##
@@ -351,16 +351,34 @@ private void and(final long[] otherArr, final int
otherNum
[
https://issues.apache.org/jira/browse/LUCENE-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452037#comment-17452037
]
Michael Sokolov commented on LUCENE-10276:
--
The way we are using at Amazon sco
rmuir opened a new pull request #500:
URL: https://github.com/apache/lucene/pull/500
Recently when running tests, I noticed slowest-test/suite times were
dominated by term vectors merging tests:
Here's a typical run:
```
The slowest tests (exceeding 500 ms) during this run:
thelabdude merged pull request #2617:
URL: https://github.com/apache/lucene-solr/pull/2617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-
thelabdude merged pull request #2619:
URL: https://github.com/apache/lucene-solr/pull/2619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-
[
https://issues.apache.org/jira/browse/LUCENE-9809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved LUCENE-9809.
-
Resolution: Fixed
Closing, as there has just been a lucene 9.0 release. Please open other issue
Robert Muir created LUCENE-10278:
Summary: BKD TestDocIdsWriter.testRandom failure
Key: LUCENE-10278
URL: https://issues.apache.org/jira/browse/LUCENE-10278
Project: Lucene - Core
Issue Type:
rmuir opened a new pull request #501:
URL: https://github.com/apache/lucene/pull/501
DocIdsWriter is not prepared for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
rmuir commented on pull request #501:
URL: https://github.com/apache/lucene/pull/501#issuecomment-984207707
@jpountz the new logic you added in LUCENE-10233 triggers the AIOOBE for a
0-sized array.
This line:
```
if (strictlySorted && (docIds[start + count - 1] - docIds[start]
mocobeta commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r760701062
##
File path: lucene/analysis/common/src/java-module/module-info.java
##
@@ -0,0 +1,217 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
mocobeta commented on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-984219402
OK, we'll expose all packages for the first step; then I think we can rely
on the `jdeps` tool to correctly list all existing packages. (I once did it in
LUCENE-9623.)
--
This
mocobeta edited a comment on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-984219402
OK, we'll expose all packages for the first step; then I think we can rely
on the `jdeps` tool to correctly list all existing packages and services. (I
once did it in LUCEN
mocobeta edited a comment on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-984219402
OK, we'll expose all packages for the first step; then I think we can rely
on the `jdeps` tool to correctly list all existing packages and services. (I
once did it in LUCEN
mocobeta edited a comment on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-984219402
OK, we'll expose all packages for the first step; then I think we can rely
on the `jdeps` tool to correctly list all existing packages and services. (I
once did it in LUCEN
mocobeta edited a comment on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-984219402
OK, we'll expose all packages for the first step; then I think we can rely
on the `jdeps` tool to correctly list all existing packages and services. (I
once did it in LUCEN
mocobeta commented on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-984256325
It's not related to here at all, I've encountered `:checkWorkingCopyClean
FAILED` when running some tasks even if `git status` says the branch tree is
clean, so I always have to a
mocobeta edited a comment on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-984256325
It's not related to here at all, I've encountered `:checkWorkingCopyClean
FAILED` when running some tasks even if `git status` says the branch tree is
clean, so I always ha
mocobeta edited a comment on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-984256325
It's not related to here at all, I've encountered `:checkWorkingCopyClean
FAILED` when running some tasks even if `git status` says the branch tree is
clean, so I always ha
mocobeta edited a comment on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-984219402
OK, we'll expose all packages for the first step; then I think we can rely
on the `jdeps` tool to correctly list all existing packages and services. (I
once did it in LUCEN
[
https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452214#comment-17452214
]
ASF subversion and git services commented on LUCENE-10233:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452217#comment-17452217
]
Adrien Grand commented on LUCENE-10233:
---
This change causes issues with backward-
mocobeta commented on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-984371151
I think we'd need a temporal utility to list all existing packages.
https://github.com/dweiss/lucene/pull/3
--
This is an automated message from the Apache Git Servic
89 matches
Mail list logo
