TomMD commented on a change in pull request #499: URL: https://github.com/apache/lucene/pull/499#discussion_r760557339
########## File path: lucene/core/src/java/org/apache/lucene/util/FixedBitSet.java ########## @@ -351,16 +351,34 @@ private void and(final long[] otherArr, final int otherNumWords) { } } + public void andNot(DocIdSetIterator iter) throws IOException { + if (BitSetIterator.getFixedBitSetOrNull(iter) != null) { + checkUnpositioned(iter); + final FixedBitSet bits = BitSetIterator.getFixedBitSetOrNull(iter); + andNot(bits); Review comment: Hurm. This is wrong because the check was done on line 355. I'll take this back to the team and see if we can improve the result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org