[
https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Feng Guo updated LUCENE-10233:
--
Attachment: SparseFixedBitSet.png
> Store docIds as bitset when leafCardinality = 1 to speed up addAl
[
https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445792#comment-17445792
]
Feng Guo commented on LUCENE-10233:
---
Hi [~jpountz], Would you like to give me some su
iverase commented on a change in pull request #7:
URL: https://github.com/apache/lucene/pull/7#discussion_r752128672
##
File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java
##
@@ -328,31 +288,97 @@ public Relation compare(byte[] minPackedValue, byte[]
maxP
jpountz commented on a change in pull request #7:
URL: https://github.com/apache/lucene/pull/7#discussion_r752133629
##
File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java
##
@@ -328,31 +288,97 @@ public Relation compare(byte[] minPackedValue, byte[]
maxP
janhoy opened a new pull request #2612:
URL: https://github.com/apache/lucene-solr/pull/2612
* Request .html as text/xml, .css as text/plain and .js as
application/javascript
* Highlight css as txt (crashed browser)
* Set extension to 'xml' for managed-schema instead of 'text/xml'
-
janhoy merged pull request #2612:
URL: https://github.com/apache/lucene-solr/pull/2612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsu
iverase commented on a change in pull request #7:
URL: https://github.com/apache/lucene/pull/7#discussion_r752168490
##
File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java
##
@@ -328,31 +288,97 @@ public Relation compare(byte[] minPackedValue, byte[]
maxP
[
https://issues.apache.org/jira/browse/LUCENE-10231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Feng Guo updated LUCENE-10231:
--
Priority: Minor (was: Major)
> Do not cache too large PointInSetQueries
> --
janhoy commented on pull request #2604:
URL: https://github.com/apache/lucene-solr/pull/2604#issuecomment-972859726
@dsmiley I wrapped this up for 8x branch, added changes entry, made the JIRA
public and ready to merge this. Any other feedback?
--
This is an automated message from the Ap
[
https://issues.apache.org/jira/browse/LUCENE-10162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445924#comment-17445924
]
Quentin Pradet commented on LUCENE-10162:
-
This is very interesting, as I've be
[
https://issues.apache.org/jira/browse/LUCENE-10162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445929#comment-17445929
]
Adrien Grand commented on LUCENE-10162:
---
bq. Is it correct to assume that this is
gsmiller commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r752270520
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##
@@ -409,9 +410,26 @@ private void processFacetFields(
indexDrillDo
gsmiller commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r752271392
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetUtils.java
##
@@ -81,4 +82,17 @@ public long cost() {
}
};
}
+
+ /**
+ *
rmuir commented on a change in pull request #452:
URL: https://github.com/apache/lucene/pull/452#discussion_r752274558
##
File path:
dev-tools/missing-doclet/src/main/java/org/apache/lucene/missingdoclet/MissingDoclet.java
##
@@ -331,7 +331,6 @@ private boolean hasInheritedJav
dweiss commented on a change in pull request #452:
URL: https://github.com/apache/lucene/pull/452#discussion_r752281787
##
File path:
dev-tools/missing-doclet/src/main/java/org/apache/lucene/missingdoclet/MissingDoclet.java
##
@@ -331,7 +331,6 @@ private boolean hasInheritedJa
gsmiller commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r752290342
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/CachedOrdinalsReader.java
##
@@ -45,7 +45,11 @@
*
* NOTE: create one instance of t
rmuir commented on a change in pull request #452:
URL: https://github.com/apache/lucene/pull/452#discussion_r752297406
##
File path:
dev-tools/missing-doclet/src/main/java/org/apache/lucene/missingdoclet/MissingDoclet.java
##
@@ -331,7 +331,6 @@ private boolean hasInheritedJav
gsmiller commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r752298802
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/OrdinalMappingLeafReader.java
##
@@ -107,6 +113,64 @@ public BytesRef binaryValue() {
costin opened a new pull request #453:
URL: https://github.com/apache/lucene/pull/453
Add VarHandle variants for `Packed64` to investigate whether using
VarHandles
improved performance or not.
This PR introduces two new Packed64 variants:
~ Packed64LongLong
Same as Packed64
rmuir commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r752303321
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/OrdinalMappingLeafReader.java
##
@@ -107,6 +113,64 @@ public BytesRef binaryValue() {
[
https://issues.apache.org/jira/browse/LUCENE-10162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445971#comment-17445971
]
Artem Prigoda commented on LUCENE-10162:
Ah, and I tried to create a new Field
rmuir commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r752328265
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/OrdinalMappingLeafReader.java
##
@@ -107,6 +113,64 @@ public BytesRef binaryValue() {
gsmiller commented on pull request #443:
URL: https://github.com/apache/lucene/pull/443#issuecomment-972948547
> Maybe clarify that full index rebuild means start a new 9.x index and
index all your documents. I.e. merely re-indexing all docs into your previous
(8.x created) index is not su
gsmiller commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r752335273
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FastTaxonomyFacetCounts.java
##
@@ -69,31 +69,34 @@ public FastTaxonomyFacetCounts(
gsmiller commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r752355654
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/OrdinalMappingLeafReader.java
##
@@ -107,6 +113,64 @@ public BytesRef binaryValue() {
spyk commented on a change in pull request #380:
URL: https://github.com/apache/lucene/pull/380#discussion_r752359873
##
File path:
lucene/analysis/opennlp/src/java/org/apache/lucene/analysis/opennlp/tools/OpenNLPOpsFactory.java
##
@@ -169,11 +169,14 @@ public static String ge
jpountz merged pull request #450:
URL: https://github.com/apache/lucene/pull/450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
reta commented on pull request #450:
URL: https://github.com/apache/lucene/pull/450#issuecomment-972980540
Thank you @jpountz !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
[
https://issues.apache.org/jira/browse/LUCENE-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445993#comment-17445993
]
ASF subversion and git services commented on LUCENE-10242:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-10242.
---
Fix Version/s: 9.0
Resolution: Fixed
Thank you!
> The TopScoreDocCollector::createS
[
https://issues.apache.org/jira/browse/LUCENE-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445994#comment-17445994
]
ASF subversion and git services commented on LUCENE-10242:
--
Co
costin commented on pull request #453:
URL: https://github.com/apache/lucene/pull/453#issuecomment-972988872
I've tested `Packed64LongByte` multiple times against `TestPackedInts` and
it seems to pass. Note that I've focused mainly on the `get` and `set` methods
and removed the specialized
jpountz commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r752375283
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FastTaxonomyFacetCounts.java
##
@@ -69,31 +69,34 @@ public FastTaxonomyFacetCounts(
[
https://issues.apache.org/jira/browse/LUCENE-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446004#comment-17446004
]
ASF subversion and git services commented on LUCENE-10242:
--
Co
magibney commented on a change in pull request #380:
URL: https://github.com/apache/lucene/pull/380#discussion_r752385177
##
File path:
lucene/analysis/opennlp/src/java/org/apache/lucene/analysis/opennlp/tools/OpenNLPOpsFactory.java
##
@@ -169,11 +169,14 @@ public static Strin
costin commented on pull request #453:
URL: https://github.com/apache/lucene/pull/453#issuecomment-972999769
Adding a few more info to this ticket regarding the underlying assembly.
The p64lb method is the shortest, followed by p64 and p64ll.
```
= C1
gsmiller commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r752406697
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FastTaxonomyFacetCounts.java
##
@@ -69,31 +69,34 @@ public FastTaxonomyFacetCounts(
[
https://issues.apache.org/jira/browse/LUCENE-10122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446030#comment-17446030
]
Adrien Grand commented on LUCENE-10122:
---
It looks like this change is missing fro
jpountz commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r752431752
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FastTaxonomyFacetCounts.java
##
@@ -69,31 +69,34 @@ public FastTaxonomyFacetCounts(
[
https://issues.apache.org/jira/browse/LUCENE-10208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446041#comment-17446041
]
ASF subversion and git services commented on LUCENE-10208:
--
Co
spyk commented on a change in pull request #380:
URL: https://github.com/apache/lucene/pull/380#discussion_r752443863
##
File path:
lucene/analysis/opennlp/src/java/org/apache/lucene/analysis/opennlp/tools/OpenNLPOpsFactory.java
##
@@ -169,11 +169,14 @@ public static String ge
magibney commented on a change in pull request #380:
URL: https://github.com/apache/lucene/pull/380#discussion_r752448693
##
File path:
lucene/analysis/opennlp/src/java/org/apache/lucene/analysis/opennlp/tools/OpenNLPOpsFactory.java
##
@@ -169,11 +169,14 @@ public static Strin
[
https://issues.apache.org/jira/browse/LUCENE-10208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446050#comment-17446050
]
ASF subversion and git services commented on LUCENE-10208:
--
Co
zhaih commented on a change in pull request #442:
URL: https://github.com/apache/lucene/pull/442#discussion_r752459454
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/TaxonomyIndexArrays.java
##
@@ -130,6 +125,46 @@ private void initParents(Index
zhaih opened a new pull request #454:
URL: https://github.com/apache/lucene/pull/454
# Note
PR towards branch_9x, mostly the same as
https://github.com/apache/lucene/pull/442, adding one additional assertion to
make sure when checking the index version the index is not empty
# Ch
[
https://issues.apache.org/jira/browse/LUCENE-10122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446058#comment-17446058
]
Haoyu Zhai commented on LUCENE-10122:
-
Ah Thanks [~jpountz] for reminding, I forgot
msokolov commented on pull request #264:
URL: https://github.com/apache/lucene/pull/264#issuecomment-973094350
> I still suggest we refrain from reviewing this PR in detail
oops, I only read that at the end; still and all I don't have much to say;
this area of the code is fairly new
msokolov commented on a change in pull request #416:
URL: https://github.com/apache/lucene/pull/416#discussion_r752476787
##
File path: lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraph.java
##
@@ -56,31 +59,50 @@
public final class HnswGraph extends KnnGraphValues {
msokolov commented on a change in pull request #416:
URL: https://github.com/apache/lucene/pull/416#discussion_r752477271
##
File path: lucene/core/src/java/org/apache/lucene/index/KnnGraphValues.java
##
@@ -32,25 +33,41 @@
protected KnnGraphValues() {}
/**
- * Move t
gsmiller commented on pull request #443:
URL: https://github.com/apache/lucene/pull/443#issuecomment-973151611
For posterity, I re-ran benchmarks with this most recent change, comparing
against `branch_9_0` as a baseline (so it includes all the back-compat checks
and such). Results still l
gsmiller commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r752525277
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FastTaxonomyFacetCounts.java
##
@@ -69,31 +69,34 @@ public FastTaxonomyFacetCounts(
gsmiller commented on pull request #443:
URL: https://github.com/apache/lucene/pull/443#issuecomment-973173432
OK, I believe this change is good-to-go now. I _think_ I've addressed all
the feedback so far and just did another benchmark run to make sure all the
performance benefits are stil
gsmiller commented on a change in pull request #442:
URL: https://github.com/apache/lucene/pull/442#discussion_r752558188
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyWriter.java
##
@@ -92,15 +93,18 @@
private final Directo
costin commented on pull request #453:
URL: https://github.com/apache/lucene/pull/453#issuecomment-973193877
Thanks to @jpountz I've added two more tests beside JMH.
`PackedRandomTest` which does a brute force for testing performance of
random locations instead of consecutive ones. Surpr
Andriy Redko created LUCENE-10244:
-
Summary: Please consider opening MultiCollector::getCollectors for
public use
Key: LUCENE-10244
URL: https://issues.apache.org/jira/browse/LUCENE-10244
Project: Luc
costin edited a comment on pull request #453:
URL: https://github.com/apache/lucene/pull/453#issuecomment-973193877
Thanks to @jpountz I've added two more tests beside JMH.
`PackedRandomTest` which does a brute force for testing performance of
random locations instead of consecutive ones
[
https://issues.apache.org/jira/browse/LUCENE-10244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446118#comment-17446118
]
Andriy Redko commented on LUCENE-10244:
---
https://github.com/apache/lucene/pull/45
reta opened a new pull request #455:
URL: https://github.com/apache/lucene/pull/455
Signed-off-by: Andriy Redko
# Description
The usage of `MultiCollector` sometimes is very convenient along with
`CollectorManager` instances (as an alternative to `MultiCollectorManage
reta commented on pull request #455:
URL: https://github.com/apache/lucene/pull/455#issuecomment-973198716
@jpountz if you don't mind taking a look, really appreciate it, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
mayya-sharipova edited a comment on pull request #416:
URL: https://github.com/apache/lucene/pull/416#issuecomment-972170715
@jtibshirani Thanks for your extensive review. I've tried to address some
comments, and some comments I think we still need to discuss
> does it have an impact
thelabdude opened a new pull request #2613:
URL: https://github.com/apache/lucene-solr/pull/2613
backport of https://github.com/apache/solr/pull/404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/LUCENE-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446161#comment-17446161
]
Robert Muir commented on LUCENE-10243:
--
I tried this out on top of LUCENE-10239 br
thelabdude merged pull request #2613:
URL: https://github.com/apache/lucene-solr/pull/2613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-
rmuir commented on pull request #452:
URL: https://github.com/apache/lucene/pull/452#issuecomment-973323310
For convenience of reviewing: here is the diff between default skeleton and
"buffer-expansion-disabled" skeleton. It is kinda the only way to review it
since we brought in all the up
thelabdude opened a new pull request #2614:
URL: https://github.com/apache/lucene-solr/pull/2614
backport of https://github.com/apache/lucene-solr/pull/2613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
thelabdude merged pull request #2614:
URL: https://github.com/apache/lucene-solr/pull/2614
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-
LifeIsStrange commented on pull request #2012:
URL: https://github.com/apache/lucene-solr/pull/2012#issuecomment-973596388
@vthacker any update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
zacharymorn merged pull request #444:
URL: https://github.com/apache/lucene/pull/444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubs
[
https://issues.apache.org/jira/browse/LUCENE-10236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446291#comment-17446291
]
ASF subversion and git services commented on LUCENE-10236:
--
Co
zacharymorn commented on pull request #444:
URL: https://github.com/apache/lucene/pull/444#issuecomment-973796460
Will backport this to 8.11 and 8x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
iverase merged pull request #7:
URL: https://github.com/apache/lucene/pull/7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lu
[
https://issues.apache.org/jira/browse/LUCENE-9820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446335#comment-17446335
]
ASF subversion and git services commented on LUCENE-9820:
-
Commi
iverase opened a new pull request #457:
URL: https://github.com/apache/lucene/pull/457
backport of #7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
[
https://issues.apache.org/jira/browse/LUCENE-9820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera resolved LUCENE-9820.
--
Fix Version/s: 9.1
Assignee: Ignacio Vera
Resolution: Fixed
> Separate logic f
iverase merged pull request #457:
URL: https://github.com/apache/lucene/pull/457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
[
https://issues.apache.org/jira/browse/LUCENE-9820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446338#comment-17446338
]
ASF subversion and git services commented on LUCENE-9820:
-
Commi
zacharymorn commented on a change in pull request #418:
URL: https://github.com/apache/lucene/pull/418#discussion_r752930339
##
File path:
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/CombinedFieldQuery.java
##
@@ -441,6 +491,273 @@ public boolean isCacheable(LeafR
77 matches
Mail list logo
