[GitHub] [lucene] dweiss commented on pull request #355: LUCENE-9997 Revisit smoketester for 9.0 build

2021-10-13 Thread GitBox
dweiss commented on pull request #355: URL: https://github.com/apache/lucene/pull/355#issuecomment-941984730 > I find bugs in the gradle build, Please ping me if you do! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [lucene] dweiss commented on a change in pull request #372: LUCENE-9488: rewrite distribution assembly, signing and checksum generation

2021-10-13 Thread GitBox
dweiss commented on a change in pull request #372: URL: https://github.com/apache/lucene/pull/372#discussion_r727758713 ## File path: lucene/distribution/build.gradle ## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[GitHub] [lucene] janhoy commented on pull request #355: LUCENE-9997 Revisit smoketester for 9.0 build

2021-10-13 Thread GitBox
janhoy commented on pull request #355: URL: https://github.com/apache/lucene/pull/355#issuecomment-941990831 > Please ping me if you do! Ping https://github.com/apache/lucene/pull/372#discussion_r727608870 -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [lucene] markrmiller commented on pull request #365: GameGenie:1990JMH

2021-10-13 Thread GitBox
markrmiller commented on pull request #365: URL: https://github.com/apache/lucene/pull/365#issuecomment-941999570 Yeah, unrelated to anything but the water cooler, another branch makes the most sense, but I had unusual alterior motives to start using an organization for a few things.

[GitHub] [lucene] dweiss commented on a change in pull request #372: LUCENE-9488: rewrite distribution assembly, signing and checksum generation

2021-10-13 Thread GitBox
dweiss commented on a change in pull request #372: URL: https://github.com/apache/lucene/pull/372#discussion_r727789350 ## File path: lucene/distribution/binary-release.gradle ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co

[jira] [Created] (LUCENE-10170) Regression in stored fields compression in 9.0

2021-10-13 Thread Adrien Grand (Jira)
Adrien Grand created LUCENE-10170: - Summary: Regression in stored fields compression in 9.0 Key: LUCENE-10170 URL: https://issues.apache.org/jira/browse/LUCENE-10170 Project: Lucene - Core Is

[GitHub] [lucene] jpountz opened a new pull request #377: LUCENE-10170: Restore compression speed for LZ4.

2021-10-13 Thread GitBox
jpountz opened a new pull request #377: URL: https://github.com/apache/lucene/pull/377 A slowdown had been introduced in LUCENE-7521. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [lucene] mrkm4ntr opened a new pull request #378: Remove redundant null check in Replica Node

2021-10-13 Thread GitBox
mrkm4ntr opened a new pull request #378: URL: https://github.com/apache/lucene/pull/378 In commit method, mgr is already used without null check before this null check. # Description Please provide a short description of the changes you're making with this pull re

[jira] [Commented] (LUCENE-10170) Regression in stored fields compression in 9.0

2021-10-13 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17428077#comment-17428077 ] Adrien Grand commented on LUCENE-10170: --- I attached a pull request that gets comp

[GitHub] [lucene] janhoy commented on a change in pull request #372: LUCENE-9488: rewrite distribution assembly, signing and checksum generation

2021-10-13 Thread GitBox
janhoy commented on a change in pull request #372: URL: https://github.com/apache/lucene/pull/372#discussion_r727839901 ## File path: lucene/distribution/build.gradle ## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[GitHub] [lucene] janhoy commented on a change in pull request #372: LUCENE-9488: rewrite distribution assembly, signing and checksum generation

2021-10-13 Thread GitBox
janhoy commented on a change in pull request #372: URL: https://github.com/apache/lucene/pull/372#discussion_r727840200 ## File path: lucene/distribution/binary-release.gradle ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co

[GitHub] [lucene] janhoy commented on pull request #372: LUCENE-9488: rewrite distribution assembly, signing and checksum generation

2021-10-13 Thread GitBox
janhoy commented on pull request #372: URL: https://github.com/apache/lucene/pull/372#issuecomment-942078856 I am now able to run the smoke tester on the freshly built artifacts, and it validates checksums, unpacks, runs demo indexer etc. Currently it is complaining about the src pac

[GitHub] [lucene] jpountz commented on a change in pull request #7: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

2021-10-13 Thread GitBox
jpountz commented on a change in pull request #7: URL: https://github.com/apache/lucene/pull/7#discussion_r727845012 ## File path: lucene/core/src/java/org/apache/lucene/index/PointValues.java ## @@ -331,6 +450,9 @@ public long estimateDocCount(IntersectVisitor visitor) { /*

[GitHub] [lucene] janhoy commented on a change in pull request #355: LUCENE-9997 Revisit smoketester for 9.0 build

2021-10-13 Thread GitBox
janhoy commented on a change in pull request #355: URL: https://github.com/apache/lucene/pull/355#discussion_r727854794 ## File path: lucene/demo/src/java/org/apache/lucene/demo/IndexFiles.java ## @@ -175,7 +175,7 @@ public static void main(String[] args) throws Exception {

[GitHub] [lucene] iverase commented on a change in pull request #7: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

2021-10-13 Thread GitBox
iverase commented on a change in pull request #7: URL: https://github.com/apache/lucene/pull/7#discussion_r727868879 ## File path: lucene/test-framework/src/java/org/apache/lucene/index/AssertingLeafReader.java ## @@ -1090,6 +1090,13 @@ private void assertStats(int maxDoc) {

[GitHub] [lucene] iverase commented on a change in pull request #7: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

2021-10-13 Thread GitBox
iverase commented on a change in pull request #7: URL: https://github.com/apache/lucene/pull/7#discussion_r727870901 ## File path: lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java ## @@ -372,6 +372,12 @@ private void checkAndThrow() { } }

[GitHub] [lucene] dweiss commented on pull request #372: LUCENE-9488: rewrite distribution assembly, signing and checksum generation

2021-10-13 Thread GitBox
dweiss commented on pull request #372: URL: https://github.com/apache/lucene/pull/372#issuecomment-942106263 > Is there a default ENV.VAR I could have used in place of this? You can set project properties (-P) with environment variables, this is an unrelated Gradle feature, see here:

[GitHub] [lucene] iverase commented on a change in pull request #7: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

2021-10-13 Thread GitBox
iverase commented on a change in pull request #7: URL: https://github.com/apache/lucene/pull/7#discussion_r727874074 ## File path: lucene/core/src/java/org/apache/lucene/index/PointValues.java ## @@ -227,8 +228,56 @@ protected PointValues() {} CELL_CROSSES_QUERY }; +

[GitHub] [lucene] iverase commented on a change in pull request #7: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

2021-10-13 Thread GitBox
iverase commented on a change in pull request #7: URL: https://github.com/apache/lucene/pull/7#discussion_r727882079 ## File path: lucene/core/src/java/org/apache/lucene/index/PointValues.java ## @@ -331,6 +450,9 @@ public long estimateDocCount(IntersectVisitor visitor) { /*

[GitHub] [lucene] janhoy commented on pull request #372: LUCENE-9488: rewrite distribution assembly, signing and checksum generation

2021-10-13 Thread GitBox
janhoy commented on pull request #372: URL: https://github.com/apache/lucene/pull/372#issuecomment-942118171 > I think you could provide the default in the python script. The script can check a few common locations. If a user has a non-standard location, we can ask the RM to configur

[GitHub] [lucene] iverase commented on pull request #7: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

2021-10-13 Thread GitBox
iverase commented on pull request #7: URL: https://github.com/apache/lucene/pull/7#issuecomment-942120304 >> If I understand correctly, you're introducing the new API but not removing the old one, just giving it a default implementation based on the new API? Yes, I still think the i

[GitHub] [lucene] dweiss merged pull request #372: LUCENE-9488: rewrite distribution assembly, signing and checksum generation

2021-10-13 Thread GitBox
dweiss merged pull request #372: URL: https://github.com/apache/lucene/pull/372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[GitHub] [lucene] dweiss commented on pull request #372: LUCENE-9488: rewrite distribution assembly, signing and checksum generation

2021-10-13 Thread GitBox
dweiss commented on pull request #372: URL: https://github.com/apache/lucene/pull/372#issuecomment-942125808 Thanks, Jan. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[jira] [Commented] (LUCENE-9488) Update release process to work with Gradle.

2021-10-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17428116#comment-17428116 ] ASF subversion and git services commented on LUCENE-9488: - Commi

[jira] [Resolved] (LUCENE-9488) Update release process to work with Gradle.

2021-10-13 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9488. - Fix Version/s: main (9.0) Resolution: Fixed > Update release process to work with Gradle.

[jira] [Commented] (LUCENE-9488) Update release process to work with Gradle.

2021-10-13 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17428118#comment-17428118 ] Jan Høydahl commented on LUCENE-9488: - Thanks a lot Dawid, Mike, Uwe, Hoss for this

[GitHub] [lucene] jpountz commented on a change in pull request #7: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

2021-10-13 Thread GitBox
jpountz commented on a change in pull request #7: URL: https://github.com/apache/lucene/pull/7#discussion_r727905294 ## File path: lucene/core/src/java/org/apache/lucene/index/PointValues.java ## @@ -331,6 +450,9 @@ public long estimateDocCount(IntersectVisitor visitor) { /*

[GitHub] [lucene] jpountz commented on pull request #7: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

2021-10-13 Thread GitBox
jpountz commented on pull request #7: URL: https://github.com/apache/lucene/pull/7#issuecomment-942138814 +1 to making these implementations final -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [lucene] iverase commented on a change in pull request #7: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

2021-10-13 Thread GitBox
iverase commented on a change in pull request #7: URL: https://github.com/apache/lucene/pull/7#discussion_r727977619 ## File path: lucene/core/src/java/org/apache/lucene/index/PointValues.java ## @@ -331,6 +450,9 @@ public long estimateDocCount(IntersectVisitor visitor) { /*

[GitHub] [lucene] iverase commented on pull request #7: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

2021-10-13 Thread GitBox
iverase commented on pull request #7: URL: https://github.com/apache/lucene/pull/7#issuecomment-94003 I made the implementations final. I think we need some thought on: * `AssertingIntersectVisitor` as it was built in a world where it would only be used for Intersects. * `Exi

[GitHub] [lucene] mikemccand merged pull request #346: LUCENE-10103 Make QueryCache respect Accountable queries

2021-10-13 Thread GitBox
mikemccand merged pull request #346: URL: https://github.com/apache/lucene/pull/346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[jira] [Commented] (LUCENE-10103) QueryCache not estimating query size properly

2021-10-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17428204#comment-17428204 ] ASF subversion and git services commented on LUCENE-10103: -- Co

[GitHub] [lucene] janhoy commented on pull request #355: LUCENE-9997 Revisit smoketester for 9.0 build

2021-10-13 Thread GitBox
janhoy commented on pull request #355: URL: https://github.com/apache/lucene/pull/355#issuecomment-942298139 I intend to merge what we have so far, and then let others submit smaller followup PRs. With the recent build improvements in #372 and the cleanup in wizard from #344, and th

[GitHub] [lucene] janhoy merged pull request #355: LUCENE-9997 Revisit smoketester for 9.0 build

2021-10-13 Thread GitBox
janhoy merged pull request #355: URL: https://github.com/apache/lucene/pull/355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] [Commented] (LUCENE-9997) Revisit smoketester for 9.0 build

2021-10-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17428215#comment-17428215 ] ASF subversion and git services commented on LUCENE-9997: - Commi

[jira] [Commented] (LUCENE-10107) Jar manifest Implementation Version is too long

2021-10-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17428216#comment-17428216 ] ASF subversion and git services commented on LUCENE-10107: -- Co

[jira] [Commented] (LUCENE-9997) Revisit smoketester for 9.0 build

2021-10-13 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17428220#comment-17428220 ] Jan Høydahl commented on LUCENE-9997: - [~rcmuir] Do you want to keep this Jira open

[jira] [Commented] (LUCENE-10103) QueryCache not estimating query size properly

2021-10-13 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17428222#comment-17428222 ] Michael McCandless commented on LUCENE-10103: - Thanks [~zhai7631] – I just

[jira] [Comment Edited] (LUCENE-10069) HNSW can miss results with very large k

2021-10-13 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404690#comment-17404690 ] Michael Sokolov edited comment on LUCENE-10069 at 10/13/21, 2:25 PM:

[jira] [Created] (LUCENE-10171) Caching issue on dictionary-based OpenNLPLemmatizerFilterFactory

2021-10-13 Thread Spyros Kapnissis (Jira)
Spyros Kapnissis created LUCENE-10171: - Summary: Caching issue on dictionary-based OpenNLPLemmatizerFilterFactory Key: LUCENE-10171 URL: https://issues.apache.org/jira/browse/LUCENE-10171 Project:

[GitHub] [lucene] spyk opened a new pull request #380: LUCENE-10171 - Fix dictionary-based OpenNLPLemmatizerFilterFactory caching issue

2021-10-13 Thread GitBox
spyk opened a new pull request #380: URL: https://github.com/apache/lucene/pull/380 # Description When providing a lemmas.txt dictionary file, OpenNLPLemmatizerFilterFactory caches internally only the string format of the dictionary, and not the DictionaryLemmatizer object. This res

[jira] [Resolved] (LUCENE-5548) Improve flexibility and testability of the classification module

2021-10-13 Thread Tommaso Teofili (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-5548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tommaso Teofili resolved LUCENE-5548. - Resolution: Fixed > Improve flexibility and testability of the classification module > -

[jira] [Created] (LUCENE-10172) Minor code improvements to classification module

2021-10-13 Thread Tommaso Teofili (Jira)
Tommaso Teofili created LUCENE-10172: Summary: Minor code improvements to classification module Key: LUCENE-10172 URL: https://issues.apache.org/jira/browse/LUCENE-10172 Project: Lucene - Core

[jira] [Commented] (LUCENE-9488) Update release process to work with Gradle.

2021-10-13 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17428351#comment-17428351 ] Chris M. Hostetter commented on LUCENE-9488: {quote}It's because of the comm

[jira] [Comment Edited] (LUCENE-9488) Update release process to work with Gradle.

2021-10-13 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17428351#comment-17428351 ] Chris M. Hostetter edited comment on LUCENE-9488 at 10/13/21, 5:15 PM: ---

[GitHub] [lucene] dweiss commented on pull request #225: LUCENE-10010 Introduce NFARunAutomaton to run NFA directly

2021-10-13 Thread GitBox
dweiss commented on pull request #225: URL: https://github.com/apache/lucene/pull/225#issuecomment-941302842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [lucene] jpountz commented on pull request #7: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

2021-10-13 Thread GitBox
jpountz commented on pull request #7: URL: https://github.com/apache/lucene/pull/7#issuecomment-942138814 +1 to making these implementations final -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [lucene] jpountz commented on a change in pull request #7: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

2021-10-13 Thread GitBox
jpountz commented on a change in pull request #7: URL: https://github.com/apache/lucene/pull/7#discussion_r727845012 ## File path: lucene/core/src/java/org/apache/lucene/index/PointValues.java ## @@ -331,6 +450,9 @@ public long estimateDocCount(IntersectVisitor visitor) { /*

[GitHub] [lucene] dweiss edited a comment on pull request #225: LUCENE-10010 Introduce NFARunAutomaton to run NFA directly

2021-10-13 Thread GitBox
dweiss edited a comment on pull request #225: URL: https://github.com/apache/lucene/pull/225#issuecomment-941302842 The stack trace is interesting though - looks like access to a closed reader pool: ``` org.apache.lucene.index.TestIndexFileDeleter > testExcInDecRef FAILED org.a

[GitHub] [lucene] dweiss commented on pull request #355: LUCENE-9997 Revisit smoketester for 9.0 build

2021-10-13 Thread GitBox
dweiss commented on pull request #355: URL: https://github.com/apache/lucene/pull/355#issuecomment-941984730 > I find bugs in the gradle build, Please ping me if you do! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [lucene] janhoy commented on a change in pull request #372: LUCENE-9488: rewrite distribution assembly, signing and checksum generation

2021-10-13 Thread GitBox
janhoy commented on a change in pull request #372: URL: https://github.com/apache/lucene/pull/372#discussion_r727570779 ## File path: lucene/distribution/build.gradle ## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[GitHub] [lucene] janhoy commented on pull request #372: LUCENE-9488: rewrite distribution assembly, signing and checksum generation

2021-10-13 Thread GitBox
janhoy commented on pull request #372: URL: https://github.com/apache/lucene/pull/372#issuecomment-942078856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [lucene] janhoy commented on a change in pull request #355: LUCENE-9997 Revisit smoketester for 9.0 build

2021-10-13 Thread GitBox
janhoy commented on a change in pull request #355: URL: https://github.com/apache/lucene/pull/355#discussion_r727577690 ## File path: dev-tools/scripts/smokeTestRelease.py ## @@ -141,21 +146,19 @@ def checkJARMetaData(desc, jarFile, gitRevision, version): raise Runti

[GitHub] [lucene] jtibshirani commented on pull request #366: LUCENE-10146: Add VectorSimilarityFunction.COSINE

2021-10-13 Thread GitBox
jtibshirani commented on pull request #366: URL: https://github.com/apache/lucene/pull/366#issuecomment-941239181 @msokolov this is a good point, I will play around with this more and loop back here. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [lucene] markrmiller commented on pull request #365: GameGenie:1990JMH

2021-10-13 Thread GitBox
markrmiller commented on pull request #365: URL: https://github.com/apache/lucene/pull/365#issuecomment-941999570 Yeah, unrelated to anything but the water cooler, another branch makes the most sense, but I had unusual alterior motives to start using an organization for a few things.

[GitHub] [lucene] iverase commented on pull request #7: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

2021-10-13 Thread GitBox
iverase commented on pull request #7: URL: https://github.com/apache/lucene/pull/7#issuecomment-942120304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[jira] [Updated] (LUCENE-10172) Minor code improvements to classification module

2021-10-13 Thread Tommaso Teofili (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tommaso Teofili updated LUCENE-10172: - Description: Minor code improvements, mainly related to better usage of lambdas and dro

[GitHub] [lucene] magibney closed pull request #208: LUCENE-10023: Add support for multi-token post-analysis DocValues

2021-10-13 Thread GitBox
magibney closed pull request #208: URL: https://github.com/apache/lucene/pull/208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [lucene] iverase commented on a change in pull request #7: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

2021-10-13 Thread GitBox
iverase commented on a change in pull request #7: URL: https://github.com/apache/lucene/pull/7#discussion_r727868879 ## File path: lucene/test-framework/src/java/org/apache/lucene/index/AssertingLeafReader.java ## @@ -1090,6 +1090,13 @@ private void assertStats(int maxDoc) {

[GitHub] [lucene] dweiss merged pull request #372: LUCENE-9488: rewrite distribution assembly, signing and checksum generation

2021-10-13 Thread GitBox
dweiss merged pull request #372: URL: https://github.com/apache/lucene/pull/372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[GitHub] [lucene] magibney commented on pull request #208: LUCENE-10023: Add support for multi-token post-analysis DocValues

2021-10-13 Thread GitBox
magibney commented on pull request #208: URL: https://github.com/apache/lucene/pull/208#issuecomment-941133721 Closing; see discussion at [LUCENE-10023](https://issues.apache.org/jira/browse/LUCENE-10023). Note: I may continue to update the PR branch. -- This is an automated message f

[GitHub] [lucene] dweiss commented on a change in pull request #372: LUCENE-9488: rewrite distribution assembly, signing and checksum generation

2021-10-13 Thread GitBox
dweiss commented on a change in pull request #372: URL: https://github.com/apache/lucene/pull/372#discussion_r727758713 ## File path: lucene/distribution/build.gradle ## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[GitHub] [lucene-solr] janhoy merged pull request #2590: SOLR-15691: Admin UI raises yellow warning with case diff in host name

2021-10-13 Thread GitBox
janhoy merged pull request #2590: URL: https://github.com/apache/lucene-solr/pull/2590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu

[GitHub] [lucene] cpoerschke commented on a change in pull request #355: LUCENE-9997 Revisit smoketester for 9.0 build

2021-10-13 Thread GitBox
cpoerschke commented on a change in pull request #355: URL: https://github.com/apache/lucene/pull/355#discussion_r727204711 ## File path: dev-tools/scripts/smokeTestRelease.py ## @@ -141,21 +146,19 @@ def checkJARMetaData(desc, jarFile, gitRevision, version): raise R

[GitHub] [lucene] janhoy commented on pull request #355: LUCENE-9997 Revisit smoketester for 9.0 build

2021-10-13 Thread GitBox
janhoy commented on pull request #355: URL: https://github.com/apache/lucene/pull/355#issuecomment-941797977 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [lucene] zhaih commented on pull request #225: LUCENE-10010 Introduce NFARunAutomaton to run NFA directly

2021-10-13 Thread GitBox
zhaih commented on pull request #225: URL: https://github.com/apache/lucene/pull/225#issuecomment-941199775 Hmmm one of the test failed ``` ERROR: The following test(s) have failed: > Task :lucene:analysis:smartcn:test - org.apache.lucene.index.TestIndexFileDeleter.testExcInDec

[GitHub] [lucene] janhoy merged pull request #355: LUCENE-9997 Revisit smoketester for 9.0 build

2021-10-13 Thread GitBox
janhoy merged pull request #355: URL: https://github.com/apache/lucene/pull/355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[GitHub] [lucene] dweiss commented on pull request #372: LUCENE-9488: rewrite distribution assembly, signing and checksum generation

2021-10-13 Thread GitBox
dweiss commented on pull request #372: URL: https://github.com/apache/lucene/pull/372#issuecomment-942106263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [lucene] mikemccand merged pull request #346: LUCENE-10103 Make QueryCache respect Accountable queries

2021-10-13 Thread GitBox
mikemccand merged pull request #346: URL: https://github.com/apache/lucene/pull/346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[GitHub] [lucene] tteofili opened a new pull request #381: LUCENE-10172 - minor java code improvements to Lucene Classification

2021-10-13 Thread GitBox
tteofili opened a new pull request #381: URL: https://github.com/apache/lucene/pull/381 # Description Please provide a short description of the changes you're making with this pull request. # Solution Please provide a short description of the approach taken

[GitHub] [lucene] jpountz commented on a change in pull request #7: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

2021-10-13 Thread GitBox
jpountz commented on a change in pull request #7: URL: https://github.com/apache/lucene/pull/7#discussion_r728349433 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java ## @@ -318,20 +316,28 @@ private boolean collectNextLeaf() throws IOException { p

[GitHub] [lucene] jpountz commented on pull request #377: LUCENE-10170: Restore compression speed for LZ4.

2021-10-13 Thread GitBox
jpountz commented on pull request #377: URL: https://github.com/apache/lucene/pull/377#issuecomment-942621701 I'll merge this tomorrow if there are no objections so that I can more easily move forward and look into other possible regressions. -- This is an automated message from the Apac

[jira] [Commented] (LUCENE-10103) QueryCache not estimating query size properly

2021-10-13 Thread Haoyu Zhai (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17428455#comment-17428455 ] Haoyu Zhai commented on LUCENE-10103: - Thank you [~mikemccand], I think we should b

[jira] [Commented] (LUCENE-9488) Update release process to work with Gradle.

2021-10-13 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17428494#comment-17428494 ] Jan Høydahl commented on LUCENE-9488: - I’ll try to make buildAndPushRelease.py and w

[jira] [Commented] (LUCENE-9488) Update release process to work with Gradle.

2021-10-13 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17428496#comment-17428496 ] Dawid Weiss commented on LUCENE-9488: - Seems like I misunderstood the comments you m

[GitHub] [lucene-solr] mikemccand merged pull request #2591: Backport "LUCENE-10103 Make QueryCache respect Accountable queries (#346)"

2021-10-13 Thread GitBox
mikemccand merged pull request #2591: URL: https://github.com/apache/lucene-solr/pull/2591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[jira] [Commented] (LUCENE-10103) QueryCache not estimating query size properly

2021-10-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17428509#comment-17428509 ] ASF subversion and git services commented on LUCENE-10103: -- Co

[jira] [Resolved] (LUCENE-10103) QueryCache not estimating query size properly

2021-10-13 Thread Haoyu Zhai (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haoyu Zhai resolved LUCENE-10103. - Resolution: Fixed > QueryCache not estimating query size properly > ---

[jira] [Created] (LUCENE-10173) remove "--max-workers 1" restriction when using external GPG w/gradle build

2021-10-13 Thread Chris M. Hostetter (Jira)
Chris M. Hostetter created LUCENE-10173: --- Summary: remove "--max-workers 1" restriction when using external GPG w/gradle build Key: LUCENE-10173 URL: https://issues.apache.org/jira/browse/LUCENE-10173

[jira] [Updated] (LUCENE-10173) remove "--max-workers 1" restriction when using external GPG w/gradle build

2021-10-13 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated LUCENE-10173: Attachment: LUCENE-10173.patch Status: Open (was: Open) [~dawid.weiss]-

[jira] [Commented] (LUCENE-9488) Update release process to work with Gradle.

2021-10-13 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17428547#comment-17428547 ] Chris M. Hostetter commented on LUCENE-9488: {quote}Seems like I misundersto

[GitHub] [lucene] zhaih commented on pull request #225: LUCENE-10010 Introduce NFARunAutomaton to run NFA directly

2021-10-13 Thread GitBox
zhaih commented on pull request #225: URL: https://github.com/apache/lucene/pull/225#issuecomment-942835409 Thanks @dweiss seems this is not the first time we see this error: https://issues.apache.org/jira/browse/LUCENE-9839 -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (LUCENE-9839) TestIndexFileDeleter.testExcInDecRef test failure

2021-10-13 Thread Haoyu Zhai (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17428549#comment-17428549 ] Haoyu Zhai commented on LUCENE-9839: This same error appeared in my PR's auto check

[jira] [Commented] (LUCENE-10173) remove "--max-workers 1" restriction when using external GPG w/gradle build

2021-10-13 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17428606#comment-17428606 ] Dawid Weiss commented on LUCENE-10173: -- Looks great, thank Chris. > remove "--max

[jira] [Updated] (LUCENE-10172) Minor code improvements to classification module

2021-10-13 Thread Tommaso Teofili (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tommaso Teofili updated LUCENE-10172: - Fix Version/s: main (9.0) > Minor code improvements to classification module >

[GitHub] [lucene] iverase commented on a change in pull request #7: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

2021-10-13 Thread GitBox
iverase commented on a change in pull request #7: URL: https://github.com/apache/lucene/pull/7#discussion_r728659741 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java ## @@ -318,20 +316,28 @@ private boolean collectNextLeaf() throws IOException { p

[GitHub] [lucene] iverase commented on a change in pull request #7: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

2021-10-13 Thread GitBox
iverase commented on a change in pull request #7: URL: https://github.com/apache/lucene/pull/7#discussion_r728661706 ## File path: lucene/core/src/java/org/apache/lucene/codecs/PointsWriter.java ## @@ -74,63 +74,100 @@ public PointValues getValues(String fieldName) {

[GitHub] [lucene] iverase commented on pull request #7: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

2021-10-13 Thread GitBox
iverase commented on pull request #7: URL: https://github.com/apache/lucene/pull/7#issuecomment-942997323 I change the name from IndexTree to PointTree. I think having tree in the name is fair as the API helps to navigating a tree structure? -- This is an automated message from the Apac

[GitHub] [lucene] jpountz merged pull request #377: LUCENE-10170: Restore compression speed for LZ4.

2021-10-13 Thread GitBox
jpountz merged pull request #377: URL: https://github.com/apache/lucene/pull/377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[jira] [Commented] (LUCENE-10170) Regression in stored fields compression in 9.0

2021-10-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17428627#comment-17428627 ] ASF subversion and git services commented on LUCENE-10170: -- Co

[jira] [Commented] (LUCENE-7521) Simplify PackedInts

2021-10-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17428628#comment-17428628 ] ASF subversion and git services commented on LUCENE-7521: - Commi

[jira] [Resolved] (LUCENE-10170) Regression in stored fields compression in 9.0

2021-10-13 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10170. --- Fix Version/s: main (9.0) Resolution: Fixed > Regression in stored fields compressio

[jira] [Created] (LUCENE-10174) Update buildAndPushRelease.py for new gradle build

2021-10-13 Thread Jira
Jan Høydahl created LUCENE-10174: Summary: Update buildAndPushRelease.py for new gradle build Key: LUCENE-10174 URL: https://issues.apache.org/jira/browse/LUCENE-10174 Project: Lucene - Core