iverase commented on a change in pull request #7:
URL: https://github.com/apache/lucene/pull/7#discussion_r727882079
##########
File path: lucene/core/src/java/org/apache/lucene/index/PointValues.java
##########
@@ -331,6 +450,9 @@ public long estimateDocCount(IntersectVisitor visitor) {
/** Returns the number of bytes per dimension */
public abstract int getBytesPerDimension() throws IOException;
+ /** Returns the maximum number of points per leaf node */
+ public abstract int getMaxPointsPerLeafNode() throws IOException;
Review comment:
This is currently used for one dimensional merges. In that case we read
one at a time each leaf in the tree. In order to do so, we build buffers before
hand that are sized using this value. If we don't expose it we will need to
have more complex logic, like checking the size of a leaf every time and sizing
our buffers accordingly?
I guess a more advance solution would be to move from a visitor pattern to
returning iterators so there is no need to copy the data locally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
