iverase commented on a change in pull request #7:
URL: https://github.com/apache/lucene/pull/7#discussion_r727977619
##########
File path: lucene/core/src/java/org/apache/lucene/index/PointValues.java
##########
@@ -331,6 +450,9 @@ public long estimateDocCount(IntersectVisitor visitor) {
/** Returns the number of bytes per dimension */
public abstract int getBytesPerDimension() throws IOException;
+ /** Returns the maximum number of points per leaf node */
+ public abstract int getMaxPointsPerLeafNode() throws IOException;
Review comment:
I didn't;t thought about the grow method, nice. I removed this method
from the API.
##########
File path: lucene/core/src/java/org/apache/lucene/index/PointValues.java
##########
@@ -331,6 +450,9 @@ public long estimateDocCount(IntersectVisitor visitor) {
/** Returns the number of bytes per dimension */
public abstract int getBytesPerDimension() throws IOException;
+ /** Returns the maximum number of points per leaf node */
+ public abstract int getMaxPointsPerLeafNode() throws IOException;
Review comment:
I didn't thought about the grow method, nice. I removed this method from
the API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
