[GitHub] [lucene] jpountz commented on a change in pull request #240: LUCENE-10002: Deprecate IndexSearch#search(Query, Collector) in favor of IndexSearcher#search(Query, CollectorManager)

jpountz commented on a change in pull request #240: URL: https://github.com/apache/lucene/pull/240#discussion_r709829843 ## File path: lucene/classification/src/java/org/apache/lucene/classification/CachingNaiveBayesClassifier.java ## @@ -179,10 +179,8 @@ public CachingNaiveBa

[GitHub] [lucene] jpountz commented on pull request #240: LUCENE-10002: Deprecate IndexSearch#search(Query, Collector) in favor of IndexSearcher#search(Query, CollectorManager)

jpountz commented on pull request #240: URL: https://github.com/apache/lucene/pull/240#issuecomment-920663920 @zacharymorn @gsmiller If we try to do everything in a single PR, I worry that this will become very hard to review. I wonder if we should split by replacing the deprecation warnin

[jira] [Commented] (LUCENE-9448) Make an equivalent to Ant's "run" target for Luke module

[ https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416008#comment-17416008 ] Tomoko Uchida commented on LUCENE-9448: --- [~dweiss] thank you, it works! > Make an

[GitHub] [lucene] mocobeta commented on a change in pull request #297: LUCENE-10102: Add JapaneseCompletionFilter for Input Method-aware auto-completion

mocobeta commented on a change in pull request #297: URL: https://github.com/apache/lucene/pull/297#discussion_r709968286 ## File path: lucene/analysis/kuromoji/src/resources/org/apache/lucene/analysis/ja/completion/romaji_map.txt ## @@ -0,0 +1,335 @@ +ア,a Review comment:

[jira] [Created] (LUCENE-10110) MultiCollector should conditionally wrap single leaf collector

Jim Ferenczi created LUCENE-10110: - Summary: MultiCollector should conditionally wrap single leaf collector Key: LUCENE-10110 URL: https://issues.apache.org/jira/browse/LUCENE-10110 Project: Lucene -

[GitHub] [lucene] jimczi opened a new pull request #303: LUCENE-10110: MultiCollector should conditionally wrap single leaf collector

jimczi opened a new pull request #303: URL: https://github.com/apache/lucene/pull/303 See https://issues.apache.org/jira/browse/LUCENE-10110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [lucene-solr] madrob opened a new pull request #2575: LUCENE-10107

madrob opened a new pull request #2575: URL: https://github.com/apache/lucene-solr/pull/2575 https://issues.apache.org/jira/browse/LUCENE-10107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [lucene-solr] mayya-sharipova opened a new pull request #2576: LUCENE-10089: Disable numeric sort optimization early

mayya-sharipova opened a new pull request #2576: URL: https://github.com/apache/lucene-solr/pull/2576 This commit moves the responsibility to disable the numeric sort optimization on comparators to the SortField. This way we don't need to apply the logic on every top field collectors.

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2575: LUCENE-10107

dweiss commented on a change in pull request #2575: URL: https://github.com/apache/lucene-solr/pull/2575#discussion_r710119506 ## File path: dev-tools/scripts/smokeTestRelease.py ## @@ -1223,7 +1223,7 @@ def run_java(cmd, logfile): return jc(run_java8, java8_home, run_java9,

[GitHub] [lucene-solr] mayya-sharipova merged pull request #2576: LUCENE-10089: Disable numeric sort optimization early

mayya-sharipova merged pull request #2576: URL: https://github.com/apache/lucene-solr/pull/2576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: is

[jira] [Commented] (LUCENE-10089) Add a way to disable the sort optimizations to leverage points on numeric fields

[ https://issues.apache.org/jira/browse/LUCENE-10089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416107#comment-17416107 ] ASF subversion and git services commented on LUCENE-10089: -- Co

[jira] [Commented] (LUCENE-10089) Add a way to disable the sort optimizations to leverage points on numeric fields

[ https://issues.apache.org/jira/browse/LUCENE-10089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416110#comment-17416110 ] ASF subversion and git services commented on LUCENE-10089: -- Co

[jira] [Commented] (LUCENE-10110) MultiCollector should conditionally wrap single leaf collector

[ https://issues.apache.org/jira/browse/LUCENE-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416126#comment-17416126 ] Adrien Grand commented on LUCENE-10110: --- Another way that I can think of avoiding

[jira] [Updated] (LUCENE-10089) Add a way to disable the sort optimizations to leverage points on numeric fields

[ https://issues.apache.org/jira/browse/LUCENE-10089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-10089: - Fix Version/s: 8.10 > Add a way to disable the sort optimizations to leverage points on numeric

[GitHub] [lucene] jpountz commented on a change in pull request #303: LUCENE-10110: MultiCollector should conditionally wrap single leaf collector

jpountz commented on a change in pull request #303: URL: https://github.com/apache/lucene/pull/303#discussion_r710206139 ## File path: lucene/core/src/test/org/apache/lucene/search/TestMultiCollector.java ## @@ -220,6 +220,68 @@ public void collect(int doc) throws IOException {

[jira] [Updated] (LUCENE-10103) QueryCache not estimating query size properly

[ https://issues.apache.org/jira/browse/LUCENE-10103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haoyu Zhai updated LUCENE-10103: Attachment: query_cache_error_demo.patch > QueryCache not estimating query size properly > --

[jira] [Commented] (LUCENE-10103) QueryCache not estimating query size properly

[ https://issues.apache.org/jira/browse/LUCENE-10103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416248#comment-17416248 ] Haoyu Zhai commented on LUCENE-10103: - I've attached a unit test showing the proble

[GitHub] [lucene-solr] madrob commented on a change in pull request #2575: LUCENE-10107

madrob commented on a change in pull request #2575: URL: https://github.com/apache/lucene-solr/pull/2575#discussion_r710449952 ## File path: dev-tools/scripts/smokeTestRelease.py ## @@ -1223,7 +1223,7 @@ def run_java(cmd, logfile): return jc(run_java8, java8_home, run_java9,

[GitHub] [lucene] gsmiller commented on pull request #293: Lucene-10070: Skip deleted documents during facet counting for all do…

gsmiller commented on pull request #293: URL: https://github.com/apache/lucene/pull/293#issuecomment-921326616 Looks good. One very minor comment and I think this is good-to-go. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [lucene] gsmiller commented on a change in pull request #293: Lucene-10070: Skip deleted documents during facet counting for all do…

gsmiller commented on a change in pull request #293: URL: https://github.com/apache/lucene/pull/293#discussion_r710560496 ## File path: lucene/facet/src/java/org/apache/lucene/facet/FacetUtils.java ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [lucene] mdmarshmallow closed pull request #288: LUCENE 10080 Added FixedBitSet for one counts when counting taxonomy facet labels

mdmarshmallow closed pull request #288: URL: https://github.com/apache/lucene/pull/288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu

[GitHub] [lucene] mdmarshmallow opened a new pull request #304: LUCENE 10080 Added FixedBitSet for one counts when counting taxonomy facet labels

mdmarshmallow opened a new pull request #304: URL: https://github.com/apache/lucene/pull/304 # Description This change is a possible improvement to how we do facet counting. Today, we accumulate counts in an HPPC int/int map or an `int[]` array. However, it is possible m

[jira] [Commented] (LUCENE-10080) Use a bit set to count long-tail of singleton FacetLabels?

[ https://issues.apache.org/jira/browse/LUCENE-10080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416364#comment-17416364 ] Marc D'Mello commented on LUCENE-10080: --- I accidentally deleted my forked branch

[GitHub] [lucene] goankur commented on a change in pull request #293: Lucene-10070: Skip deleted documents during facet counting for all do…

goankur commented on a change in pull request #293: URL: https://github.com/apache/lucene/pull/293#discussion_r710606591 ## File path: lucene/facet/src/java/org/apache/lucene/facet/FacetUtils.java ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [lucene] zacharymorn commented on a change in pull request #240: LUCENE-10002: Deprecate IndexSearch#search(Query, Collector) in favor of IndexSearcher#search(Query, CollectorManager)

zacharymorn commented on a change in pull request #240: URL: https://github.com/apache/lucene/pull/240#discussion_r710741708 ## File path: lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/ReadTask.java ## @@ -180,6 +185,7 @@ protected int withTopDocs(IndexSea

[GitHub] [lucene] zacharymorn commented on a change in pull request #240: LUCENE-10002: Deprecate IndexSearch#search(Query, Collector) in favor of IndexSearcher#search(Query, CollectorManager)

zacharymorn commented on a change in pull request #240: URL: https://github.com/apache/lucene/pull/240#discussion_r710741804 ## File path: lucene/classification/src/java/org/apache/lucene/classification/SimpleNaiveBayesClassifier.java ## @@ -179,8 +178,7 @@ protected int count

[GitHub] [lucene] zacharymorn commented on a change in pull request #240: LUCENE-10002: Deprecate IndexSearch#search(Query, Collector) in favor of IndexSearcher#search(Query, CollectorManager)

zacharymorn commented on a change in pull request #240: URL: https://github.com/apache/lucene/pull/240#discussion_r710741902 ## File path: lucene/classification/src/java/org/apache/lucene/classification/SimpleNaiveBayesClassifier.java ## @@ -276,9 +274,7 @@ private int getWord

[GitHub] [lucene] zacharymorn commented on a change in pull request #240: LUCENE-10002: Deprecate IndexSearch#search(Query, Collector) in favor of IndexSearcher#search(Query, CollectorManager)

zacharymorn commented on a change in pull request #240: URL: https://github.com/apache/lucene/pull/240#discussion_r710742109 ## File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollectorManager.java ## @@ -0,0 +1,177 @@ +/* + * Licensed to the Apache Software F

[GitHub] [lucene] zacharymorn commented on pull request #240: LUCENE-10002: Deprecate IndexSearch#search(Query, Collector) in favor of IndexSearcher#search(Query, CollectorManager)

zacharymorn commented on pull request #240: URL: https://github.com/apache/lucene/pull/240#issuecomment-921456717 > I left some comments but the approach that you took so far looks good to me. I see that we still need to migrate some collectors like LargeNumHitsTopDocsCollector or the inte

[GitHub] [lucene] mocobeta commented on a change in pull request #297: LUCENE-10102: Add JapaneseCompletionFilter for Input Method-aware auto-completion

mocobeta commented on a change in pull request #297: URL: https://github.com/apache/lucene/pull/297#discussion_r710753494 ## File path: lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/completion/StringUtils.java ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apac

[jira] [Commented] (LUCENE-10102) Add JapaneseCompletionFilter for Input Method-aware auto-completion

[ https://issues.apache.org/jira/browse/LUCENE-10102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416459#comment-17416459 ] Tomoko Uchida commented on LUCENE-10102: Also, if it's ok to give the credit to

[GitHub] [lucene] johtani commented on a change in pull request #297: LUCENE-10102: Add JapaneseCompletionFilter for Input Method-aware auto-completion

johtani commented on a change in pull request #297: URL: https://github.com/apache/lucene/pull/297#discussion_r710767347 ## File path: lucene/analysis/kuromoji/src/resources/org/apache/lucene/analysis/ja/completion/romaji_map.txt ## @@ -0,0 +1,344 @@ +# mapping rules of kataka