gsmiller commented on a change in pull request #293: URL: https://github.com/apache/lucene/pull/293#discussion_r710560496
########## File path: lucene/facet/src/java/org/apache/lucene/facet/FacetUtils.java ########## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.lucene.facet; + +import java.io.IOException; +import org.apache.lucene.search.DocIdSetIterator; +import org.apache.lucene.util.Bits; + +/** Utility class with a single method for getting a DocIdSetIterator that skips deleted docs */ +public final class FacetUtils { Review comment: Thanks for going to all the work to break this out and add tests! Could you add `@lucene.experimental` to the javadoc for this class? Ideally we could make this pkg-private but I understand why that's not possible with the facet sub-packages. I'd like to avoid a situation where this becomes part of our public API though and we have to start worrying about backwards compatibility and such if we want to tweak or change it, since it's really an internal helper for faceting. By marking it "experimental", I think that gives us some flexibility to worry less about backwards compatibility here (see: https://cwiki.apache.org/confluence/display/LUCENE/BackwardsCompatibility) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
