madrob commented on a change in pull request #2575:
URL: https://github.com/apache/lucene-solr/pull/2575#discussion_r710449952
##########
File path: dev-tools/scripts/smokeTestRelease.py
##########
@@ -1223,7 +1223,7 @@ def run_java(cmd, logfile):
return jc(run_java8, java8_home, run_java9, java9_home)
version_re = re.compile(r'(\d+\.\d+\.\d+(-ALPHA|-BETA)?)')
Review comment:
This regex extracts the hash from the filename, which still has a full
sha. It looks something like
`$TMPDIR/releases-8.10/lucene-solr-8.10.0-RC3-revb473a4f88588bb1e32cff27aaee05380c42f64f1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]