jtibshirani commented on a change in pull request #204:
URL: https://github.com/apache/lucene/pull/204#discussion_r664107815
##
File path:
lucene/core/src/test/org/apache/lucene/search/TestSortOptimization.java
##
@@ -332,6 +333,71 @@ public void testFloatSortOptimization() th
dsmiley commented on a change in pull request #205:
URL: https://github.com/apache/lucene/pull/205#discussion_r664111224
##
File path: lucene/core/src/java/org/apache/lucene/index/SegmentCoreReaders.java
##
@@ -57,7 +57,7 @@
final NormsProducer normsProducer;
final Stor
zacharymorn commented on pull request #205:
URL: https://github.com/apache/lucene/pull/205#issuecomment-874499672
> I'm also okay with introducing the new/simpler TermVectorsReader
abstraction if it would reduce this PR diff a lot. Up to you.
Thanks @dsmiley for the review and approv
zacharymorn commented on a change in pull request #205:
URL: https://github.com/apache/lucene/pull/205#discussion_r664278681
##
File path: lucene/core/src/java/org/apache/lucene/index/SegmentCoreReaders.java
##
@@ -57,7 +57,7 @@
final NormsProducer normsProducer;
final
mayya-sharipova commented on a change in pull request #204:
URL: https://github.com/apache/lucene/pull/204#discussion_r664573881
##
File path:
lucene/core/src/java/org/apache/lucene/search/comparators/DocComparator.java
##
@@ -81,7 +87,12 @@ public Integer value(int slot) {
mayya-sharipova commented on pull request #204:
URL: https://github.com/apache/lucene/pull/204#issuecomment-874777903
@jtibshirani Thanks for the review. I've tried to address all your feedback
in b5af441a39611d63df30168452cdec521ce4d578
--
This is an automated message from the Apache Gi
dsmiley commented on a change in pull request #205:
URL: https://github.com/apache/lucene/pull/205#discussion_r664625324
##
File path: lucene/core/src/java/org/apache/lucene/index/SegmentCoreReaders.java
##
@@ -57,7 +57,7 @@
final NormsProducer normsProducer;
final Stor
thelabdude opened a new pull request #2522:
URL: https://github.com/apache/lucene-solr/pull/2522
Backport of https://github.com/apache/solr/pull/173 to branch_8x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jtibshirani commented on a change in pull request #204:
URL: https://github.com/apache/lucene/pull/204#discussion_r664698038
##
File path:
lucene/core/src/java/org/apache/lucene/search/comparators/DocComparator.java
##
@@ -81,7 +87,12 @@ public Integer value(int slot) {
p
thelabdude merged pull request #2522:
URL: https://github.com/apache/lucene-solr/pull/2522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-
uschindler commented on pull request #203:
URL: https://github.com/apache/lucene/pull/203#issuecomment-874900622
After reviewing the code by DocValues and DirectPackedReader, I figured out
that the alignment should be configurable. Depending of a RandomAccessInput
based on an IndexInput sl
[
https://issues.apache.org/jira/browse/LUCENE-10019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375832#comment-17375832
]
Uwe Schindler commented on LUCENE-10019:
After reviewing the code by DocValues
thelabdude opened a new pull request #2523:
URL: https://github.com/apache/lucene-solr/pull/2523
Backport of https://github.com/apache/solr/pull/168 to branch_8x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
thelabdude merged pull request #2523:
URL: https://github.com/apache/lucene-solr/pull/2523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-
[
https://issues.apache.org/jira/browse/LUCENE-10003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375864#comment-17375864
]
David Smiley commented on LUCENE-10003:
---
I did some experimentation with using a
thelabdude opened a new pull request #2524:
URL: https://github.com/apache/lucene-solr/pull/2524
Backport of https://github.com/apache/solr/pull/181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
thelabdude merged pull request #2524:
URL: https://github.com/apache/lucene-solr/pull/2524
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-
dsmiley opened a new pull request #206:
URL: https://github.com/apache/lucene/pull/206
https://issues.apache.org/jira/browse/LUCENE-10003
The first commit was purely automated by IntelliJ.
The second commit are my hand edits to other spots IntellIJ didn't find
because it was in a
rmuir commented on pull request #206:
URL: https://github.com/apache/lucene/pull/206#issuecomment-874976665
Why are we not doing this with spotless? As mentioned on the JIRA, I'm
really -1 on the approach of enforcing *formatting* with anything but spotless.
Sorry, it will just be annoying
thelabdude opened a new pull request #2525:
URL: https://github.com/apache/lucene-solr/pull/2525
Backport https://github.com/apache/solr/pull/177 to branch_8x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
markrmiller commented on pull request #2525:
URL: https://github.com/apache/lucene-solr/pull/2525#issuecomment-875004571
Didn't see anything that looks off to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
mayya-sharipova commented on a change in pull request #204:
URL: https://github.com/apache/lucene/pull/204#discussion_r664804322
##
File path:
lucene/core/src/java/org/apache/lucene/search/comparators/DocComparator.java
##
@@ -81,7 +87,12 @@ public Integer value(int slot) {
mayya-sharipova merged pull request #204:
URL: https://github.com/apache/lucene/pull/204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-un
[
https://issues.apache.org/jira/browse/LUCENE-10020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375948#comment-17375948
]
ASF subversion and git services commented on LUCENE-10020:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-9449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375950#comment-17375950
]
ASF subversion and git services commented on LUCENE-9449:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375949#comment-17375949
]
ASF subversion and git services commented on LUCENE-9449:
-
Commi
dsmiley commented on pull request #206:
URL: https://github.com/apache/lucene/pull/206#issuecomment-875011653
This PR isn't about automatic enforcement so I think your veto is intended
at the conversation in the JIRA issue about how to enforce.
--
This is an automated message from the Ap
thelabdude merged pull request #2525:
URL: https://github.com/apache/lucene-solr/pull/2525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-
thelabdude opened a new pull request #2526:
URL: https://github.com/apache/lucene-solr/pull/2526
Backport https://github.com/apache/solr/pull/191 to branch_8x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
thelabdude merged pull request #2526:
URL: https://github.com/apache/lucene-solr/pull/2526
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-
thelabdude opened a new pull request #2527:
URL: https://github.com/apache/lucene-solr/pull/2527
Backport to branch_8x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
thelabdude merged pull request #2527:
URL: https://github.com/apache/lucene-solr/pull/2527
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-
thelabdude opened a new pull request #2528:
URL: https://github.com/apache/lucene-solr/pull/2528
Backport https://github.com/apache/solr/pull/194 to branch_8x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
thelabdude merged pull request #2528:
URL: https://github.com/apache/lucene-solr/pull/2528
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-
thelabdude opened a new pull request #2529:
URL: https://github.com/apache/lucene-solr/pull/2529
Backport https://github.com/apache/solr/pull/197 to branch_8x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
thelabdude merged pull request #2529:
URL: https://github.com/apache/lucene-solr/pull/2529
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-
mayya-sharipova opened a new pull request #2530:
URL: https://github.com/apache/lucene-solr/pull/2530
DocComparator should not skip docs with the same docID on multiple
sorts with search after.
Because of the optimization introduced in LUCENE-9449, currently when
searching with
mayya-sharipova merged pull request #2530:
URL: https://github.com/apache/lucene-solr/pull/2530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: is
[
https://issues.apache.org/jira/browse/LUCENE-9449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376132#comment-17376132
]
ASF subversion and git services commented on LUCENE-9449:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376131#comment-17376131
]
ASF subversion and git services commented on LUCENE-9449:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-10020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376130#comment-17376130
]
ASF subversion and git services commented on LUCENE-10020:
--
Co
zacharymorn commented on a change in pull request #205:
URL: https://github.com/apache/lucene/pull/205#discussion_r665060449
##
File path: lucene/core/src/java/org/apache/lucene/index/SegmentCoreReaders.java
##
@@ -57,7 +57,7 @@
final NormsProducer normsProducer;
final
zacharymorn commented on a change in pull request #205:
URL: https://github.com/apache/lucene/pull/205#discussion_r665060449
##
File path: lucene/core/src/java/org/apache/lucene/index/SegmentCoreReaders.java
##
@@ -57,7 +57,7 @@
final NormsProducer normsProducer;
final
43 matches
Mail list logo
