mayya-sharipova commented on a change in pull request #204:
URL: https://github.com/apache/lucene/pull/204#discussion_r664804322
##########
File path:
lucene/core/src/java/org/apache/lucene/search/comparators/DocComparator.java
##########
@@ -81,7 +87,12 @@ public Integer value(int slot) {
public DocLeafComparator(LeafReaderContext context) {
this.docBase = context.docBase;
if (enableSkipping) {
- this.minDoc = topValue + 1;
+ // For a single sort on _doc, we want to skip all docs before topValue.
+ // For multiple fields sort on [_doc, other fields], we want to
include docs with the same
+ // docID.
+ // This is needed in a distributed search, where there are docs from
different indices with
+ // the same docID.
+ this.minDoc = singleSort ? topValue + 1 : topValue;
Review comment:
Right, `singleSort` check is used not only for search after case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
