iverase opened a new pull request #123:
URL: https://github.com/apache/lucene/pull/123
Left over from #107, we should read / write checksums using big endian in
the NRT replicator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
iverase merged pull request #123:
URL: https://github.com/apache/lucene/pull/123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please co
[
https://issues.apache.org/jira/browse/LUCENE-9047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338222#comment-17338222
]
ASF subversion and git services commented on LUCENE-9047:
-
Commi
uschindler commented on pull request #123:
URL: https://github.com/apache/lucene/pull/123#issuecomment-831209602
Hi @iverase
the merge broke tests: We fixed over the weekend the NRT tests. They had a
bug in the security policy, so no NRT Test is running at all. So you did not
see the t
uschindler commented on pull request #107:
URL: https://github.com/apache/lucene/pull/107#issuecomment-831209886
Hi @iverase
the merge broke tests: We fixed over the weekend the NRT tests. They had a
bug in the security policy, so no NRT Test is running at all. So you did not
see the te
uschindler edited a comment on pull request #107:
URL: https://github.com/apache/lucene/pull/107#issuecomment-831209886
Hi @iverase
the merge broke tests: We fixed over the weekend the NRT tests. They had a
bug in the security policy, so no NRT Test wasn't running at all. So you did
not
uschindler edited a comment on pull request #123:
URL: https://github.com/apache/lucene/pull/123#issuecomment-831209602
Hi @iverase
the merge broke tests: We fixed over the weekend the NRT tests. They had a
bug in the security policy, so no NRT Test wasn't running at all. So you did
no
iverase commented on pull request #123:
URL: https://github.com/apache/lucene/pull/123#issuecomment-831237759
Thanks @uschindler, yikes that explain it all :)
This fix seems to work, I run the test with the nightly flag and it seems
happy:
```
./gradlew :lucene:replicator:
uschindler commented on pull request #123:
URL: https://github.com/apache/lucene/pull/123#issuecomment-831256482
What did you change, or was the test failures on Jenkins only because of the
first merge on the directory API and this one fixed it?
This explains why you opened THIS pull
uschindler commented on pull request #123:
URL: https://github.com/apache/lucene/pull/123#issuecomment-831257258
It will be funny, when Solr picks the new snapshot builds!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
uschindler commented on pull request #107:
URL: https://github.com/apache/lucene/pull/107#issuecomment-831262001
This is great - by the way!
I will make a new PR based on
https://github.com/apache/lucene-solr/pull/2176 to check how the little endian
by default improves the new MMapD
mikemccand commented on pull request #123:
URL: https://github.com/apache/lucene/pull/123#issuecomment-831263447
> The NRT tests were not running since now YEARS!
OH NO!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/LUCENE-9948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338376#comment-17338376
]
Greg Miller commented on LUCENE-9948:
-
Thanks [~rcmuir], much easier (and cleaner) c
rmuir commented on pull request #122:
URL: https://github.com/apache/lucene/pull/122#issuecomment-831319155
one TODO i want to try for fun, is to look at output from `gradlew -p
lucene/facet coverage` and see if all the e.g. optimized cases here are really
tested (https://github.com/apache
rmuir commented on pull request #122:
URL: https://github.com/apache/lucene/pull/122#issuecomment-831327039
Looks good: [
](url)
--
This is an
[
https://issues.apache.org/jira/browse/LUCENE-9948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338420#comment-17338420
]
ASF subversion and git services commented on LUCENE-9948:
-
Commi
rmuir merged pull request #122:
URL: https://github.com/apache/lucene/pull/122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please cont
[
https://issues.apache.org/jira/browse/LUCENE-9948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir resolved LUCENE-9948.
-
Fix Version/s: main (9.0)
Resolution: Fixed
> Automatically detect multi- vs. single-valu
[
https://issues.apache.org/jira/browse/LUCENE-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338429#comment-17338429
]
ASF subversion and git services commented on LUCENE-9188:
-
Commi
uschindler commented on pull request #123:
URL: https://github.com/apache/lucene/pull/123#issuecomment-831347167
I backported the fixes. But I can tell you: It was only a master problm, 8.x
was fine. I still backported Dawid's fixes.
--
This is an automated message from the Apache Git Se
uschindler commented on pull request #123:
URL: https://github.com/apache/lucene/pull/123#issuecomment-831351741
the suppressAccessChecks permission got lost in master, so the NRT tests
were not able to crush the test server with SIGSEGV. It's now working in both
master and 8.x. I ran the
[
https://issues.apache.org/jira/browse/LUCENE-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338436#comment-17338436
]
ASF subversion and git services commented on LUCENE-9188:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338443#comment-17338443
]
Robert Muir commented on LUCENE-9948:
-
Thanks [~gsmiller] for taking care of this!
mikemccand commented on pull request #123:
URL: https://github.com/apache/lucene/pull/123#issuecomment-831394750
Awesome, thank you @uschindler!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
mikemccand commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-831398047
This looks awesome!
Are our Jenkins builds publishing the Jacoco reports somewhere accessible?
> Maybe I can work with @mikemccand to add reports to luceneutil, or m
[
https://issues.apache.org/jira/browse/LUCENE-9945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338500#comment-17338500
]
Michael McCandless commented on LUCENE-9945:
+1, this would enable more adva
[
https://issues.apache.org/jira/browse/LUCENE-9944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338503#comment-17338503
]
Michael McCandless commented on LUCENE-9944:
+1 to decouple concurrent versu
uschindler edited a comment on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-831406221
> Are our Jenkins builds publishing the Jacoco reports somewhere accessible?
Sure: https://ci-builds.apache.org/job/Lucene/job/Lucene-Coverage-main/
I describ
uschindler commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-831408328
Jenkins "documentation":
https://issues.apache.org/jira/browse/LUCENE-9188?focusedCommentId=17338040&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment
uschindler commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-831406221
> Are our Jenkins builds publishing the Jacoco reports somewhere accessible?
Sure: https://ci-builds.apache.org/job/Lucene/job/Lucene-Coverage-main/
I described this
mikemccand commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-831414606
Thanks @uschindler!
Do we disable assertions when running the Jacoco coverage? I see the
`assert` statements are yellow e.g. here:
https://ci-builds.apache.org/job/Lucen
Greg Miller created LUCENE-9950:
---
Summary: Support both single- and multi-value string fields in
facet counting (non-taxonomy based approaches)
Key: LUCENE-9950
URL: https://issues.apache.org/jira/browse/LUCENE-9950
[
https://issues.apache.org/jira/browse/LUCENE-9948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338524#comment-17338524
]
Greg Miller commented on LUCENE-9948:
-
Yep, thanks for the suggestion [~rcmuir]!
>
[
https://issues.apache.org/jira/browse/LUCENE-9946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338523#comment-17338523
]
Greg Miller commented on LUCENE-9946:
-
I took a look at the SSDV implementations thi
rmuir commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-831425688
There is a relevant jacoco issue: https://github.com/jacoco/jacoco/issues/324
It points to another issue (filtering feature), where you can see filtering
asserts looks like an
uschindler commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-831428448
Another tip: Never click on methods! Just go to "class" level and then
scroll down (the problem is that the many method links make you automatically
click on them). Jacoco also
rmuir commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-831430500
> This looks awesome!
>
> Are our Jenkins builds publishing the Jacoco reports somewhere accessible?
>
> > Maybe I can work with @mikemccand to add reports to luceneu
uschindler commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-831436885
> but I don't know how far it looks back (seems like only a few builds?)
Maybe it just needs tweaking. If it doesn't serve our purposes, I think there
is also a Rest API to fetc
uschindler commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-831439203
On ASF Jenkins I made the "Coverage" build to only run "daily". For testing
purposes it was "hourly".
--
This is an automated message from the Apache Git Service.
To respond t
rmuir commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-831439579
I also tried to dig and see if I could change the `Lucene: Passing` badge in
the github README.md to instead show the coverage percentage just as an easily
available tracker :) I cou
uschindler commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-831441152
> On ASF Jenkins I made the "Coverage" build to only run "daily". For
testing purposes it was "hourly".
I also changed to keep last 30 *days* of builds, instead of 5 build
rmuir commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-831442536
Thanks @uschindler . @mikemccand we could add a simple link to
https://ci-builds.apache.org/job/Lucene/job/Lucene-Coverage-main/jacoco/ to
luceneutil html, with Uwe's changes, it sho
gautamworah96 commented on a change in pull request #108:
URL: https://github.com/apache/lucene/pull/108#discussion_r625325022
##
File path: gradle/validation/jar-checks.gradle
##
@@ -242,62 +206,14 @@ subprojects {
}
}
- licenses.dependsOn validateJarChecksums, vali
[
https://issues.apache.org/jira/browse/LUCENE-9944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338586#comment-17338586
]
Greg Miller commented on LUCENE-9944:
-
Thanks for the feedback [~mikemccand]. I'll w
[
https://issues.apache.org/jira/browse/LUCENE-9945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338589#comment-17338589
]
Greg Miller commented on LUCENE-9945:
-
Thanks [~mikemccand] for the feedback! This s
dweiss commented on a change in pull request #108:
URL: https://github.com/apache/lucene/pull/108#discussion_r625331360
##
File path: gradle/validation/jar-checks.gradle
##
@@ -242,62 +206,14 @@ subprojects {
}
}
- licenses.dependsOn validateJarChecksums, validateJar
[
https://issues.apache.org/jira/browse/LUCENE-9334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338591#comment-17338591
]
Dawid Weiss commented on LUCENE-9334:
-
TestPerFieldConsistency has been failing on a
[
https://issues.apache.org/jira/browse/LUCENE-9945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller updated LUCENE-9945:
Description:
The {{DrillSideways}} logic currently encapsulates, 1) the creation of multiple
{{Fa
[
https://issues.apache.org/jira/browse/LUCENE-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jack Conradson updated LUCENE-9843:
---
Attachment: LUCENE-9843.patch
> Remove compression option on doc values
> --
[
https://issues.apache.org/jira/browse/LUCENE-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338626#comment-17338626
]
Jack Conradson commented on LUCENE-9843:
I have attached a patch ([^LUCENE-9843.
gautamworah96 commented on a change in pull request #108:
URL: https://github.com/apache/lucene/pull/108#discussion_r625420416
##
File path: gradle/validation/jar-checks.gradle
##
@@ -242,62 +206,14 @@ subprojects {
}
}
- licenses.dependsOn validateJarChecksums, vali
gautamworah96 commented on a change in pull request #108:
URL: https://github.com/apache/lucene/pull/108#discussion_r625420416
##
File path: gradle/validation/jar-checks.gradle
##
@@ -242,62 +206,14 @@ subprojects {
}
}
- licenses.dependsOn validateJarChecksums, vali
gautamworah96 closed pull request #108:
URL: https://github.com/apache/lucene/pull/108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, ple
mocobeta merged pull request #115:
URL: https://github.com/apache/lucene/pull/115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please c
[
https://issues.apache.org/jira/browse/LUCENE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338712#comment-17338712
]
ASF subversion and git services commented on LUCENE-4198:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rahul Goswami updated LUCENE-9889:
--
Description:
If one of the existing segment files is opened by another (say a 3rd party)
p
56 matches
Mail list logo
