dweiss commented on a change in pull request #108:
URL: https://github.com/apache/lucene/pull/108#discussion_r625331360
##########
File path: gradle/validation/jar-checks.gradle
##########
@@ -242,62 +206,14 @@ subprojects {
}
}
- licenses.dependsOn validateJarChecksums, validateJarLicenses
+ licenses.dependsOn validateJarLicenses
}
// Add top-project level tasks validating dangling files
// and regenerating dependency checksums.
configure(project(":lucene")) {
def validationTasks = subprojects.collectMany { it.tasks.matching { it.name
== "licenses" } }
- def jarInfoTasks = subprojects.collectMany { it.tasks.matching { it.name ==
"collectJarInfos" } }
-
- // Update dependency checksums.
- task updateLicenses() {
Review comment:
But it's the opposite of what we want: we'd like those tasks that have
detached dependencies to pass instead of fail. It's really hard to predict
where such configurations may occur and it's just not possible to list all
possible tasks to "--write-verification-metadata"...
The only way I see it as a functional substitute is if it can be passed an
explicit set of configurations from which to generate the metadata and still
work with any other configurations. Otherwise it's going to be very difficult
to work with - I don't see how we can activate all possible configurations when
writing checksums.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
