gautamworah96 commented on a change in pull request #108:
URL: https://github.com/apache/lucene/pull/108#discussion_r625325022
##########
File path: gradle/validation/jar-checks.gradle
##########
@@ -242,62 +206,14 @@ subprojects {
}
}
- licenses.dependsOn validateJarChecksums, validateJarLicenses
+ licenses.dependsOn validateJarLicenses
}
// Add top-project level tasks validating dangling files
// and regenerating dependency checksums.
configure(project(":lucene")) {
def validationTasks = subprojects.collectMany { it.tasks.matching { it.name
== "licenses" } }
- def jarInfoTasks = subprojects.collectMany { it.tasks.matching { it.name ==
"collectJarInfos" } }
-
- // Update dependency checksums.
- task updateLicenses() {
Review comment:
Alright! I tested a sample `detachedConfiguration`
```
tasks.register("checkDetachedDependencies") {
doLast {
def detachedConf =
configurations.detachedConfiguration(dependencies.create("org.aspectj:aspectjrt:1.8.6"))
println(detachedConf.files)
}
}
```
This task fails if you execute it separately with `./gradlew
checkDetachedDependencies` giving the error that it needs the checksum of
`aspectj`. However, `./gradlew check` passes because `check` does not depend on
`checkDetachedDependencies`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
