Feng Guo created LUCENE-9857:
Summary: Skip cache building if IndexOrDocValuesQuery choose the
dvQuery
Key: LUCENE-9857
URL: https://issues.apache.org/jira/browse/LUCENE-9857
Project: Lucene - Core
gf2121 opened a new pull request #29:
URL: https://github.com/apache/lucene/pull/29
IndexOrDocValuesQuery can automatically use dvQueries when the cost > 8 *l
eadcost, And the LRUQueryCache skips cache building when cost > 250(By default)
* leadcost. There is a gap between 8 and 250, which
iverase opened a new pull request #30:
URL: https://github.com/apache/lucene/pull/30
For now this is just a copy of Lucene86SegmentInfoFormat. The existing
Lucene86SegmentInfoFormat is moved to backwards-codecs.
--
This is an automated message from the Apache Git Service.
To respond t
Jan Høydahl created LUCENE-9858:
---
Summary: Remove Google Analytics from Lucene site
Key: LUCENE-9858
URL: https://issues.apache.org/jira/browse/LUCENE-9858
Project: Lucene - Core
Issue Type: Ta
[
https://issues.apache.org/jira/browse/LUCENE-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17305997#comment-17305997
]
Tomoko Uchida commented on LUCENE-9413:
---
FYI: I'm planning to change the JapaneseA
[
https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306063#comment-17306063
]
Tomoko Uchida commented on LUCENE-9855:
---
I'm inclined to DenseVectorsFormat, to di
asalamon74 opened a new pull request #31:
URL: https://github.com/apache/lucene/pull/31
Original lucene-solr pull request:
https://github.com/apache/lucene-solr/pull/1060
# Description
changes2html.pl generates invalid html
# Solution
Fix it to generate a
Ignacio Vera created LUCENE-9859:
Summary: Failure in TestXYPointQueries
Key: LUCENE-9859
URL: https://issues.apache.org/jira/browse/LUCENE-9859
Project: Lucene - Core
Issue Type: Bug
dweiss merged pull request #27:
URL: https://github.com/apache/lucene/pull/27
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please conta
[
https://issues.apache.org/jira/browse/LUCENE-9854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306128#comment-17306128
]
ASF subversion and git services commented on LUCENE-9854:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-9854.
-
Fix Version/s: main (9.0)
Resolution: Fixed
> Clean up utilities to download and extract
rmuir commented on a change in pull request #26:
URL: https://github.com/apache/lucene/pull/26#discussion_r598268124
##
File path:
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseAnalyzer.java
##
@@ -39,21 +41,28 @@
private final Mode mode;
privat
magibney commented on a change in pull request #2470:
URL: https://github.com/apache/lucene-solr/pull/2470#discussion_r598724131
##
File path: PRs.md
##
@@ -64,3 +64,45 @@ Look at the PR and create it if it looks good.
# This example's PR was at:
https://github.com/apache/luc
magibney commented on a change in pull request #15:
URL: https://github.com/apache/lucene/pull/15#discussion_r598735719
##
File path:
lucene/analysis/icu/src/java/org/apache/lucene/analysis/icu/ICUTransformCharFilterFactory.java
##
@@ -0,0 +1,391 @@
+/*
+ * Licensed to the Apa
gsmiller commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r598748091
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##
@@ -65,6 +65,38 @@
// int/float/bytes in a single indexed field:
privat
gsmiller commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r598753012
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##
@@ -371,14 +426,26 @@ private void processFacetFields(
}
gsmiller commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r598757471
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##
@@ -371,14 +426,26 @@ private void processFacetFields(
}
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306234#comment-17306234
]
Michael McCandless commented on LUCENE-9856:
I will cut a branch! Let's sta
mocobeta commented on a change in pull request #26:
URL: https://github.com/apache/lucene/pull/26#discussion_r598772602
##
File path:
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseAnalyzer.java
##
@@ -39,21 +41,28 @@
private final Mode mode;
pri
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306249#comment-17306249
]
Michael McCandless commented on LUCENE-8962:
Hi Team! This issue was so exo
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-8962:
---
Attachment: image-2021-03-22-10-36-32-201.png
> Can we merge small segments during r
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306264#comment-17306264
]
ASF subversion and git services commented on LUCENE-9856:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306265#comment-17306265
]
ASF subversion and git services commented on LUCENE-9856:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306269#comment-17306269
]
Michael McCandless commented on LUCENE-9856:
OK I think I succeeded!
https
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306271#comment-17306271
]
Dawid Weiss commented on LUCENE-9856:
-
No magic is needed as ecj runs per-module (su
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306283#comment-17306283
]
Robert Muir commented on LUCENE-9856:
-
[~dweiss] i don't want to disable *entire ecj
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306285#comment-17306285
]
Dawid Weiss commented on LUCENE-9856:
-
The pattern will be similar – apply the right
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306287#comment-17306287
]
Robert Muir commented on LUCENE-9856:
-
So in pseudocode something like this (similar
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306290#comment-17306290
]
Robert Muir commented on LUCENE-9856:
-
{quote}
This aside, maybe we should return to
Robert Muir created LUCENE-9860:
---
Summary: explore disabling ecj javadocs processing
Key: LUCENE-9860
URL: https://issues.apache.org/jira/browse/LUCENE-9860
Project: Lucene - Core
Issue Type: T
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306297#comment-17306297
]
Dawid Weiss commented on LUCENE-9856:
-
Ok, let's leave it for later. Your snippet is
[
https://issues.apache.org/jira/browse/LUCENE-9860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306298#comment-17306298
]
Dawid Weiss commented on LUCENE-9860:
-
+1 from me.
> explore disabling ecj javadocs
[
https://issues.apache.org/jira/browse/LUCENE-9860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306299#comment-17306299
]
Dawid Weiss commented on LUCENE-9860:
-
We can enable full processing on nightlies if
[
https://issues.apache.org/jira/browse/LUCENE-9860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306302#comment-17306302
]
Robert Muir commented on LUCENE-9860:
-
I think the change is to simply remove {{-ena
[
https://issues.apache.org/jira/browse/LUCENE-9860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306308#comment-17306308
]
Dawid Weiss commented on LUCENE-9860:
-
Disable this and let it bake. Those time stat
[
https://issues.apache.org/jira/browse/LUCENE-9860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306312#comment-17306312
]
Robert Muir commented on LUCENE-9860:
-
This URL didnt work (i think it was expired)
mayya-sharipova opened a new pull request #32:
URL: https://github.com/apache/lucene/pull/32
1. Add an option to supply a custom leaf sorter for IndexWriter.
A DirectoryReader opened from this IndexWriter will have its leaf
readers sorted with the provided leaf sorter. This is useful f
mayya-sharipova closed pull request #2256:
URL: https://github.com/apache/lucene-solr/pull/2256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this ser
[
https://issues.apache.org/jira/browse/LUCENE-9860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306317#comment-17306317
]
Dawid Weiss commented on LUCENE-9860:
-
Locally you can add -Ptask.times=true to show
mayya-sharipova commented on pull request #2256:
URL: https://github.com/apache/lucene-solr/pull/2256#issuecomment-804182320
I've moved this PR to a [new PR](https://github.com/apache/lucene/pull/32)
in the new Lucene github repo. Closing this PR.
--
This is an automated message from t
mayya-sharipova commented on a change in pull request #2256:
URL: https://github.com/apache/lucene-solr/pull/2256#discussion_r598854515
##
File path:
lucene/core/src/test/org/apache/lucene/index/TestIndexWriterReader.java
##
@@ -169,7 +176,7 @@ public void testUpdateDocument()
mayya-sharipova commented on a change in pull request #2256:
URL: https://github.com/apache/lucene-solr/pull/2256#discussion_r598855055
##
File path: lucene/core/src/java/org/apache/lucene/index/DirectoryReader.java
##
@@ -56,7 +57,24 @@
* @throws IOException if there is a
mayya-sharipova commented on a change in pull request #2256:
URL: https://github.com/apache/lucene-solr/pull/2256#discussion_r598857854
##
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriterConfig.java
##
@@ -478,6 +479,18 @@ public IndexWriterConfig setIndexSor
[
https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306324#comment-17306324
]
Michael Sokolov commented on LUCENE-9855:
-
Thanks for picking this up, [~tomoko]
[
https://issues.apache.org/jira/browse/LUCENE-9860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306404#comment-17306404
]
Robert Muir commented on LUCENE-9860:
-
I played around, even disabling so much javad
[
https://issues.apache.org/jira/browse/LUCENE-9860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir resolved LUCENE-9860.
-
Resolution: Won't Fix
> explore disabling ecj javadocs processing
>
Robert Muir created LUCENE-9861:
---
Summary: speed up precommit
Key: LUCENE-9861
URL: https://issues.apache.org/jira/browse/LUCENE-9861
Project: Lucene - Core
Issue Type: Task
Reporte
[
https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306439#comment-17306439
]
Robert Muir commented on LUCENE-9861:
-
For renderJavadoc this is also 2x speedup:
Be
[
https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-9861:
Attachment: LUCENE-9861_hack.patch
Status: Open (was: Open)
My current hack patch. Still
[
https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306462#comment-17306462
]
Robert Muir commented on LUCENE-9861:
-
simple bench of current hack patch
before:
{
[
https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306526#comment-17306526
]
Dawid Weiss commented on LUCENE-9861:
-
Whaaat?! :) I'll take a look tomorrow, Robert
[
https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306528#comment-17306528
]
Dawid Weiss commented on LUCENE-9861:
-
I did take a look at the patch... oh, man. Th
[
https://issues.apache.org/jira/browse/LUCENE-9860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306531#comment-17306531
]
Dawid Weiss commented on LUCENE-9860:
-
Let's close this one then?
> explore disabli
[
https://issues.apache.org/jira/browse/LUCENE-9860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306533#comment-17306533
]
Robert Muir commented on LUCENE-9860:
-
yes, i closed it as won't fix
> explore disa
[
https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306534#comment-17306534
]
Uwe Schindler commented on LUCENE-9861:
---
I would really like to look also into not
[
https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306534#comment-17306534
]
Uwe Schindler edited comment on LUCENE-9861 at 3/22/21, 8:00 PM:
-
[
https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306536#comment-17306536
]
Robert Muir commented on LUCENE-9861:
-
Not forking is fine too. But forking with C2
[
https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306540#comment-17306540
]
Uwe Schindler commented on LUCENE-9861:
---
Yes, especially also renderJavadoc should
[
https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306549#comment-17306549
]
Robert Muir commented on LUCENE-9861:
-
Also the "-times" can be removed from the pat
[
https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306558#comment-17306558
]
Robert Muir commented on LUCENE-9861:
-
{quote}
But for stuff that works perfectly fi
rmuir commented on pull request #31:
URL: https://github.com/apache/lucene/pull/31#issuecomment-804411503
Thanks @asalamon74 ! I validated the change (though i had to tweak the
comments so that the utf-8 encoding was within first 1024 bytes for
https://validator.w3.org/ to accept it, anoth
rmuir merged pull request #31:
URL: https://github.com/apache/lucene/pull/31
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contac
dweiss opened a new pull request #33:
URL: https://github.com/apache/lucene/pull/33
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
[
https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306599#comment-17306599
]
Dawid Weiss commented on LUCENE-9861:
-
I've refactored this into a somewhat more sha
[
https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306602#comment-17306602
]
Dawid Weiss commented on LUCENE-9861:
-
The problem with running javadocs in-process
[
https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306604#comment-17306604
]
Dawid Weiss commented on LUCENE-9861:
-
My results. Before:
{code}
Aggregate task tim
gsmiller commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r599105765
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##
@@ -408,7 +475,7 @@ private void processSSDVFacetFields(
doc.add(new
gsmiller commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r599106387
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##
@@ -444,12 +511,6 @@ private void processAssocFacetFields(
FacetsCon
rmuir commented on a change in pull request #33:
URL: https://github.com/apache/lucene/pull/33#discussion_r599114199
##
File path: gradle/validation/ecj-lint.gradle
##
@@ -74,9 +74,6 @@ allprojects {
args += [ "-enableJavadoc" ]
args += [ "-properties",
file(
rmuir commented on a change in pull request #33:
URL: https://github.com/apache/lucene/pull/33#discussion_r599114563
##
File path: gradle/validation/ecj-lint.gradle
##
@@ -74,9 +74,6 @@ allprojects {
args += [ "-enableJavadoc" ]
args += [ "-properties",
file(
[
https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306620#comment-17306620
]
Uwe Schindler commented on LUCENE-9861:
---
Looks slower after? 🤔
> speed up precomm
rmuir commented on pull request #33:
URL: https://github.com/apache/lucene/pull/33#issuecomment-804436499
I compared times with another PR (just looking at the github check times),
and it shaved a few minutes off
--
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306624#comment-17306624
]
ASF subversion and git services commented on LUCENE-9856:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306625#comment-17306625
]
Robert Muir commented on LUCENE-9861:
-
If you have 87 cores, you can afford to spend
[
https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306627#comment-17306627
]
Robert Muir commented on LUCENE-9861:
-
Another way to look at it, if you see that, y
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306649#comment-17306649
]
ASF subversion and git services commented on LUCENE-9856:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306650#comment-17306650
]
ASF subversion and git services commented on LUCENE-9856:
-
Commi
rmuir opened a new pull request #34:
URL: https://github.com/apache/lucene/pull/34
See the JIRA for more details.
This turns on ecj option:
`ecj.javadocs.prefs:org.eclipse.jdt.core.compiler.problem.unusedLocal=error`
But some modules have some generated code, and there is no w
rmuir commented on pull request #34:
URL: https://github.com/apache/lucene/pull/34#issuecomment-804474683
This change is largely mechanical: simply remove the unused local variables.
Try to preserve any method calls that may have side effects (e.g. throw
exception) in tests.
In gene
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306662#comment-17306662
]
ASF subversion and git services commented on LUCENE-9856:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306663#comment-17306663
]
ASF subversion and git services commented on LUCENE-9856:
-
Commi
rmuir commented on pull request #34:
URL: https://github.com/apache/lucene/pull/34#issuecomment-804487699
OK i reverted the gradle changes completely, i found a secret option so that
`SuppressWarnings` can be used. This fixes the expressions module, but we need
to apply `SuppressWarnings("
uschindler commented on a change in pull request #33:
URL: https://github.com/apache/lucene/pull/33#discussion_r599162761
##
File path: gradle/validation/ecj-lint.gradle
##
@@ -74,9 +74,6 @@ allprojects {
args += [ "-enableJavadoc" ]
args += [ "-properties",
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306673#comment-17306673
]
ASF subversion and git services commented on LUCENE-9856:
-
Commi
zacharymorn commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r599170681
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##
@@ -371,14 +426,26 @@ private void processFacetFields(
}
zacharymorn commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r599171007
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##
@@ -371,14 +426,26 @@ private void processFacetFields(
}
zacharymorn commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r599171189
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##
@@ -408,7 +475,7 @@ private void processSSDVFacetFields(
doc.add(
zacharymorn commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r599171328
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##
@@ -444,12 +511,6 @@ private void processAssocFacetFields(
Facets
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306677#comment-17306677
]
Robert Muir commented on LUCENE-9856:
-
While wrestling with the PR, I found out abou
gsmiller commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r599193102
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##
@@ -371,14 +426,26 @@ private void processFacetFields(
}
gsmiller commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r599195582
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##
@@ -408,7 +475,7 @@ private void processSSDVFacetFields(
doc.add(new
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306709#comment-17306709
]
ASF subversion and git services commented on LUCENE-9856:
-
Commi
Robert Muir created LUCENE-9862:
---
Summary: gradlew regenerate doesnt invoke
jflexStandardTokenizerImpl
Key: LUCENE-9862
URL: https://issues.apache.org/jira/browse/LUCENE-9862
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306721#comment-17306721
]
ASF subversion and git services commented on LUCENE-9856:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306738#comment-17306738
]
ASF subversion and git services commented on LUCENE-9856:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306761#comment-17306761
]
ASF subversion and git services commented on LUCENE-9856:
-
Commi
rmuir commented on pull request #34:
URL: https://github.com/apache/lucene/pull/34#issuecomment-804606020
ok, I think ecj linter is now in better shape, especially as far as dead
code goes.
But wow, the amount of dead `private` members and methods that we had was
really surprising.
[
https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306803#comment-17306803
]
Dawid Weiss commented on LUCENE-9861:
-
The improvement is clearly seen on individual
98 matches
Mail list logo
