zacharymorn commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r599171328
##########
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##########
@@ -444,12 +511,6 @@ private void processAssocFacetFields(
FacetsConfig.DimConfig ft = getDimConfig(field.dim);
// Drill down:
- int start;
- if (ft.requireDimensionDrillDown) {
- start = 1;
- } else {
- start = 2;
- }
for (int i = 1; i <= label.length; i++) {
doc.add(
Review comment:
I originally thought it doesn't need to be updated as association facet
field doesn't work with hierarchy, and the `int i = 1` in the for loop seems to
be done on purpose:
https://github.com/apache/lucene/blob/2678d68be8e1eab75706c3aedf27ca4c77182a22/lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java#L263
But on a second thought / look I think it should use the same configuration
now, particularly after `NONE` option is added. I've updated it accordingly.
Good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]