zacharymorn commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r599170681
##########
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##########
@@ -371,14 +426,26 @@ private void processFacetFields(
}
// Drill down:
- int start;
- if (ft.requireDimensionDrillDown) {
- start = 1;
- } else {
- start = 2;
- }
- for (int i = start; i <= cp.length; i++) {
- doc.add(new StringField(indexFieldName, pathToString(cp.components,
i), Field.Store.NO));
+ if (ft.drillDownTermsIndexing != DrillDownTermsIndexing.NONE) {
+ StringField fullPathField =
Review comment:
I introduced `fullPathField` here as I thought it could use some
explanation to add clarity, but I'm fine either way so I have inlined it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]