[GitHub] [lucene-solr] dweiss commented on a change in pull request #2347: LUCENE-9760: Hunspell: print total memory usage in TestAllDictionarie…

2021-02-11 Thread GitBox
dweiss commented on a change in pull request #2347: URL: https://github.com/apache/lucene-solr/pull/2347#discussion_r574309396 ## File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestAllDictionaries.java ## @@ -181,11 +188,16 @@ public void testDi

[jira] [Commented] (SOLR-15149) Learning To Rank model upload fails generically

2021-02-11 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282913#comment-17282913 ] Alessandro Benedetti commented on SOLR-15149: - Sorry [~dweiss]! You just reve

[GitHub] [lucene-solr] dweiss merged pull request #2347: LUCENE-9760: Hunspell: print total memory usage in TestAllDictionarie…

2021-02-11 Thread GitBox
dweiss merged pull request #2347: URL: https://github.com/apache/lucene-solr/pull/2347 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-9760) Hunspell: print total memory usage in TestAllDictionaries, cleanup

2021-02-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282915#comment-17282915 ] ASF subversion and git services commented on LUCENE-9760: - Commi

[jira] [Resolved] (LUCENE-9760) Hunspell: print total memory usage in TestAllDictionaries, cleanup

2021-02-11 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9760. - Fix Version/s: master (9.0) Resolution: Fixed > Hunspell: print total memory usage in Tes

[GitHub] [lucene-solr] dweiss merged pull request #2348: LUCENE-9761: Hunspell: check that FLAG and SET don't occur too far in…

2021-02-11 Thread GitBox
dweiss merged pull request #2348: URL: https://github.com/apache/lucene-solr/pull/2348 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-9761) Hunspell: check that FLAG and SET don't occur too far in the file, cleanup

2021-02-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282917#comment-17282917 ] ASF subversion and git services commented on LUCENE-9761: - Commi

[jira] [Resolved] (LUCENE-9761) Hunspell: check that FLAG and SET don't occur too far in the file, cleanup

2021-02-11 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9761. - Fix Version/s: master (9.0) Resolution: Fixed > Hunspell: check that FLAG and SET don't o

[GitHub] [lucene-solr] dweiss merged pull request #2341: LUCENE-9759: Hunspell: add more to TestHunspellRepositoryTestCases.EXPECTED_FAILURES

2021-02-11 Thread GitBox
dweiss merged pull request #2341: URL: https://github.com/apache/lucene-solr/pull/2341 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2347: LUCENE-9760: Hunspell: print total memory usage in TestAllDictionarie…

2021-02-11 Thread GitBox
donnerpeter commented on a change in pull request #2347: URL: https://github.com/apache/lucene-solr/pull/2347#discussion_r574311027 ## File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestAllDictionaries.java ## @@ -181,11 +188,16 @@ public void t

[jira] [Resolved] (LUCENE-9759) Hunspell: add more to TestHunspellRepositoryTestCases.EXPECTED_FAILURES

2021-02-11 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9759. - Fix Version/s: master (9.0) Resolution: Fixed > Hunspell: add more to TestHunspellReposit

[jira] [Commented] (LUCENE-9759) Hunspell: add more to TestHunspellRepositoryTestCases.EXPECTED_FAILURES

2021-02-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282918#comment-17282918 ] ASF subversion and git services commented on LUCENE-9759: - Commi

[jira] [Commented] (LUCENE-9758) Hunspell: support NOSUGGEST option

2021-02-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282920#comment-17282920 ] ASF subversion and git services commented on LUCENE-9758: - Commi

[GitHub] [lucene-solr] dweiss merged pull request #2340: LUCENE-9758: Hunspell: support NOSUGGEST option

2021-02-11 Thread GitBox
dweiss merged pull request #2340: URL: https://github.com/apache/lucene-solr/pull/2340 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (LUCENE-9758) Hunspell: support NOSUGGEST option

2021-02-11 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9758. - Fix Version/s: master (9.0) Resolution: Fixed > Hunspell: support NOSUGGEST option >

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2347: LUCENE-9760: Hunspell: print total memory usage in TestAllDictionarie…

2021-02-11 Thread GitBox
dweiss commented on a change in pull request #2347: URL: https://github.com/apache/lucene-solr/pull/2347#discussion_r574312611 ## File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestAllDictionaries.java ## @@ -181,11 +188,16 @@ public void testDi

[jira] [Commented] (SOLR-15149) Learning To Rank model upload fails generically

2021-02-11 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282921#comment-17282921 ] Dawid Weiss commented on SOLR-15149: Oh... did I? :) Must have been unrelated - sorry

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2347: LUCENE-9760: Hunspell: print total memory usage in TestAllDictionarie…

2021-02-11 Thread GitBox
donnerpeter commented on a change in pull request #2347: URL: https://github.com/apache/lucene-solr/pull/2347#discussion_r574316976 ## File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestAllDictionaries.java ## @@ -181,11 +188,16 @@ public void t

[jira] [Created] (LUCENE-9763) Hunspell: fix FORBIDDENWORD support

2021-02-11 Thread Peter Gromov (Jira)
Peter Gromov created LUCENE-9763: Summary: Hunspell: fix FORBIDDENWORD support Key: LUCENE-9763 URL: https://issues.apache.org/jira/browse/LUCENE-9763 Project: Lucene - Core Issue Type: Sub-t

[GitHub] [lucene-solr] donnerpeter opened a new pull request #2351: LUCENE-9763: Hunspell: fix FORBIDDENWORD support

2021-02-11 Thread GitBox
donnerpeter opened a new pull request #2351: URL: https://github.com/apache/lucene-solr/pull/2351 # Description Some Hunspell's forbiddenword-related tests were failing # Solution don't decompound if it's a simple word with a forbidden root, don't lookup the

[jira] [Created] (LUCENE-9764) Hunspell: try title case as FORCEUCASE misspelled word suggestions

2021-02-11 Thread Peter Gromov (Jira)
Peter Gromov created LUCENE-9764: Summary: Hunspell: try title case as FORCEUCASE misspelled word suggestions Key: LUCENE-9764 URL: https://issues.apache.org/jira/browse/LUCENE-9764 Project: Lucene -

[GitHub] [lucene-solr] donnerpeter opened a new pull request #2352: LUCENE-9764: Hunspell: try title case as FORCEUCASE misspelled word suggestions

2021-02-11 Thread GitBox
donnerpeter opened a new pull request #2352: URL: https://github.com/apache/lucene-solr/pull/2352 # Description Hunspell has a special branch in `suggest` for `FORCEUCASE` words # Solution Replicate that logic # Tests `forceucase.sug` from Hunsp

[GitHub] [lucene-solr] donnerpeter commented on pull request #2352: LUCENE-9764: Hunspell: try title case as FORCEUCASE misspelled word suggestions

2021-02-11 Thread GitBox
donnerpeter commented on pull request #2352: URL: https://github.com/apache/lucene-solr/pull/2352#issuecomment-777300019 Together with the PR about forbidden words, this makes `TestHunspellRepositoryTestCases` finally pass T

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2351: LUCENE-9763: Hunspell: fix FORBIDDENWORD support

2021-02-11 Thread GitBox
donnerpeter commented on a change in pull request #2351: URL: https://github.com/apache/lucene-solr/pull/2351#discussion_r574344521 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java ## @@ -51,22 +51,22 @@ } List

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2351: LUCENE-9763: Hunspell: fix FORBIDDENWORD support

2021-02-11 Thread GitBox
donnerpeter commented on a change in pull request #2351: URL: https://github.com/apache/lucene-solr/pull/2351#discussion_r574344779 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/SpellChecker.java ## @@ -68,11 +68,12 @@ private boolean spellC

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2351: LUCENE-9763: Hunspell: fix FORBIDDENWORD support

2021-02-11 Thread GitBox
donnerpeter commented on a change in pull request #2351: URL: https://github.com/apache/lucene-solr/pull/2351#discussion_r574345109 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/SpellChecker.java ## @@ -105,12 +106,9 @@ boolean checkWord(Str

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2351: LUCENE-9763: Hunspell: fix FORBIDDENWORD support

2021-02-11 Thread GitBox
donnerpeter commented on a change in pull request #2351: URL: https://github.com/apache/lucene-solr/pull/2351#discussion_r574345261 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/SpellChecker.java ## @@ -68,11 +68,12 @@ private boolean spellC

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2351: LUCENE-9763: Hunspell: fix FORBIDDENWORD support

2021-02-11 Thread GitBox
donnerpeter commented on a change in pull request #2351: URL: https://github.com/apache/lucene-solr/pull/2351#discussion_r574345261 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/SpellChecker.java ## @@ -68,11 +68,12 @@ private boolean spellC

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2351: LUCENE-9763: Hunspell: fix FORBIDDENWORD support

2021-02-11 Thread GitBox
donnerpeter commented on a change in pull request #2351: URL: https://github.com/apache/lucene-solr/pull/2351#discussion_r574346045 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Stemmer.java ## @@ -94,10 +93,6 @@ public Stemmer(Dictionary di

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2351: LUCENE-9763: Hunspell: fix FORBIDDENWORD support

2021-02-11 Thread GitBox
donnerpeter commented on a change in pull request #2351: URL: https://github.com/apache/lucene-solr/pull/2351#discussion_r574346658 ## File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestDutchIJ.java ## @@ -27,6 +27,5 @@ public static void before

[GitHub] [lucene-solr] iverase commented on pull request #2310: LUCENE-9705: Create Lucene90PostingsFormat

2021-02-11 Thread GitBox
iverase commented on pull request #2310: URL: https://github.com/apache/lucene-solr/pull/2310#issuecomment-777438974 I have a look and I have two thoughts: 1) I wonder if we should not version PFUtil classes, instead move then to a package under Util and change the visibility of the

[GitHub] [lucene-solr] iverase edited a comment on pull request #2310: LUCENE-9705: Create Lucene90PostingsFormat

2021-02-11 Thread GitBox
iverase edited a comment on pull request #2310: URL: https://github.com/apache/lucene-solr/pull/2310#issuecomment-777438974 I have a look and I have two thoughts: 1) I wonder if we should not version PFUtil classes, instead move then to a package under Util and change the visibility

[jira] [Commented] (SOLR-15114) WAND does not work correctly on multiple segments in Solr 8.6.3

2021-02-11 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283029#comment-17283029 ] Jan Høydahl commented on SOLR-15114: Thanks for the detailed bug analysis - with nice

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2021-02-11 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283033#comment-17283033 ] Jan Høydahl commented on SOLR-14920: +1 from me too. What if reference-branch also a

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2021-02-11 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283037#comment-17283037 ] Erick Erickson commented on SOLR-14920: --- My take re: the reference impl is that the

[GitHub] [lucene-solr] iverase opened a new pull request #2353: LUCENE-9322: Add Vectors format to CodecReader accounting methods

2021-02-11 Thread GitBox
iverase opened a new pull request #2353: URL: https://github.com/apache/lucene-solr/pull/2353 Take into account the new Vectors format for methods: - ramBytesUsed - getChildResources - checkIntegrity This has surfaced after #2331 as there are some test fails when nightly

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2021-02-11 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283041#comment-17283041 ] Dawid Weiss commented on SOLR-14920: bq. What if reference-branch also applies this,

[GitHub] [lucene-solr] dweiss merged pull request #2352: LUCENE-9764: Hunspell: try title case as FORCEUCASE misspelled word suggestions

2021-02-11 Thread GitBox
dweiss merged pull request #2352: URL: https://github.com/apache/lucene-solr/pull/2352 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (LUCENE-9764) Hunspell: try title case as FORCEUCASE misspelled word suggestions

2021-02-11 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9764. - Fix Version/s: master (9.0) Resolution: Fixed > Hunspell: try title case as FORCEUCASE mi

[jira] [Commented] (LUCENE-9764) Hunspell: try title case as FORCEUCASE misspelled word suggestions

2021-02-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283044#comment-17283044 ] ASF subversion and git services commented on LUCENE-9764: - Commi

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2318: SOLR-15138: PerReplicaStates does not scale to large collections as well as state.json

2021-02-11 Thread GitBox
murblanc commented on a change in pull request #2318: URL: https://github.com/apache/lucene-solr/pull/2318#discussion_r574498232 ## File path: solr/core/src/java/org/apache/solr/cloud/RefreshCollectionMessage.java ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2351: LUCENE-9763: Hunspell: fix FORBIDDENWORD support

2021-02-11 Thread GitBox
dweiss commented on a change in pull request #2351: URL: https://github.com/apache/lucene-solr/pull/2351#discussion_r574532355 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java ## @@ -51,22 +51,22 @@ } List sugge

[GitHub] [lucene-solr] dweiss merged pull request #2351: LUCENE-9763: Hunspell: fix FORBIDDENWORD support

2021-02-11 Thread GitBox
dweiss merged pull request #2351: URL: https://github.com/apache/lucene-solr/pull/2351 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-9763) Hunspell: fix FORBIDDENWORD support

2021-02-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283045#comment-17283045 ] ASF subversion and git services commented on LUCENE-9763: - Commi

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2318: SOLR-15138: PerReplicaStates does not scale to large collections as well as state.json

2021-02-11 Thread GitBox
murblanc commented on a change in pull request #2318: URL: https://github.com/apache/lucene-solr/pull/2318#discussion_r574498232 ## File path: solr/core/src/java/org/apache/solr/cloud/RefreshCollectionMessage.java ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Fou

[jira] [Resolved] (LUCENE-9763) Hunspell: fix FORBIDDENWORD support

2021-02-11 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9763. - Fix Version/s: master (9.0) Resolution: Fixed > Hunspell: fix FORBIDDENWORD support > ---

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2021-02-11 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283049#comment-17283049 ] David Eric Pugh commented on SOLR-14920: I've been relearning the code base, and

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2351: LUCENE-9763: Hunspell: fix FORBIDDENWORD support

2021-02-11 Thread GitBox
donnerpeter commented on a change in pull request #2351: URL: https://github.com/apache/lucene-solr/pull/2351#discussion_r574552151 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Stemmer.java ## @@ -94,10 +93,6 @@ public Stemmer(Dictionary di

[GitHub] [lucene-solr-operator] zhuopeng opened a new issue #215: kubectl apply -f crds.yaml fails with metadata.annotations: Too long error

2021-02-11 Thread GitBox
zhuopeng opened a new issue #215: URL: https://github.com/apache/lucene-solr-operator/issues/215 To reproduce `kubectl apply -f helm/solr-operator/crds/crds.yaml` getting error `customresourcedefinition.apiextensions.k8s.io/solrbackups.solr.bloomberg.com configured Warning:

[jira] [Commented] (SOLR-14561) Validate parameters to CoreAdminAPI

2021-02-11 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283071#comment-17283071 ] Jan Høydahl commented on SOLR-14561: Ah, I see - you'd like to allow path traversal e

[jira] [Commented] (LUCENE-9754) ICU Tokenizer: letter-space-number-letter tokenized inconsistently

2021-02-11 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283075#comment-17283075 ] Robert Muir commented on LUCENE-9754: - Yes, the issue is because of the chunking. Pu

[jira] [Commented] (LUCENE-9754) ICU Tokenizer: letter-space-number-letter tokenized inconsistently

2021-02-11 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283102#comment-17283102 ] Robert Muir commented on LUCENE-9754: - Just to be clear, I'm thinking something like

[jira] [Created] (SOLR-15151) It's not possible anymore to indicate a relative path to the core data folder

2021-02-11 Thread Thomas Mortagne (Jira)
Thomas Mortagne created SOLR-15151: -- Summary: It's not possible anymore to indicate a relative path to the core data folder Key: SOLR-15151 URL: https://issues.apache.org/jira/browse/SOLR-15151 Proje

[jira] [Commented] (SOLR-14561) Validate parameters to CoreAdminAPI

2021-02-11 Thread Thomas Mortagne (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283103#comment-17283103 ] Thomas Mortagne commented on SOLR-14561: I created SOLR-15151. I cannot work on a

[jira] [Commented] (LUCENE-9754) ICU Tokenizer: letter-space-number-letter tokenized inconsistently

2021-02-11 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283105#comment-17283105 ] Michael Sokolov commented on LUCENE-9754: - Would it make sense to have the abili

[jira] [Commented] (SOLR-15114) WAND does not work correctly on multiple segments in Solr 8.6.3

2021-02-11 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283104#comment-17283104 ] David Smiley commented on SOLR-15114: - I should second that sentiment as well; that P

[GitHub] [lucene-solr] iverase merged pull request #2353: LUCENE-9322: Add Vectors format to CodecReader accounting methods

2021-02-11 Thread GitBox
iverase merged pull request #2353: URL: https://github.com/apache/lucene-solr/pull/2353 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-9322) Discussing a unified vectors format API

2021-02-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283110#comment-17283110 ] ASF subversion and git services commented on LUCENE-9322: - Commi

[jira] [Commented] (LUCENE-9754) ICU Tokenizer: letter-space-number-letter tokenized inconsistently

2021-02-11 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283116#comment-17283116 ] Robert Muir commented on LUCENE-9754: - We just use unicode properties for that stuff

[jira] [Updated] (SOLR-15132) Add window paramater to the nodes Streaming Expression

2021-02-11 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-15132: -- Attachment: SOLR-15132.patch > Add window paramater to the nodes Streaming Expression > ---

[jira] [Commented] (SOLR-15132) Add window paramater to the nodes Streaming Expression

2021-02-11 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283120#comment-17283120 ] Joel Bernstein commented on SOLR-15132: --- First patch, tests to follow. > Add windo

[jira] [Created] (SOLR-15152) Export Tool should export nested docs cleanly in .json, .jsonl, and javabin

2021-02-11 Thread David Eric Pugh (Jira)
David Eric Pugh created SOLR-15152: -- Summary: Export Tool should export nested docs cleanly in .json, .jsonl, and javabin Key: SOLR-15152 URL: https://issues.apache.org/jira/browse/SOLR-15152 Project

[GitHub] [lucene-solr-operator] HoustonPutman closed issue #215: kubectl apply -f crds.yaml fails with metadata.annotations: Too long error

2021-02-11 Thread GitBox
HoustonPutman closed issue #215: URL: https://github.com/apache/lucene-solr-operator/issues/215 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [lucene-solr-operator] HoustonPutman commented on issue #215: kubectl apply -f crds.yaml fails with metadata.annotations: Too long error

2021-02-11 Thread GitBox
HoustonPutman commented on issue #215: URL: https://github.com/apache/lucene-solr-operator/issues/215#issuecomment-777622617 Use `kubectl replace` instead, it's what we use in the Makefile now. For CRDs, `replace` is better than `apply`, even without the annotation. -

[jira] [Commented] (SOLR-15150) add request level option to fail an atomic update if it can't be done 'in-place'

2021-02-11 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283139#comment-17283139 ] David Smiley commented on SOLR-15150: - +1 LGTM and great testing as usual RE "requir

[jira] [Commented] (SOLR-15146) Distribute Collection API command execution

2021-02-11 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283160#comment-17283160 ] David Smiley commented on SOLR-15146: - Amazing work Ilan!!! I'm especially looking f

[jira] [Commented] (SOLR-15118) Make /v2/collections APIs annotation-based

2021-02-11 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283167#comment-17283167 ] David Smiley commented on SOLR-15118: - I'm a huge fan of what you propose in your fir

[jira] [Commented] (SOLR-15150) add request level option to fail an atomic update if it can't be done 'in-place'

2021-02-11 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283179#comment-17283179 ] Ishan Chattopadhyaya commented on SOLR-15150: - +1 Hoss, this issue is very us

[jira] [Comment Edited] (SOLR-15152) Export Tool should export nested docs cleanly in .json, .jsonl, and javabin

2021-02-11 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283180#comment-17283180 ] David Eric Pugh edited comment on SOLR-15152 at 2/11/21, 4:59 PM: -

[jira] [Commented] (SOLR-15152) Export Tool should export nested docs cleanly in .json, .jsonl, and javabin

2021-02-11 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283180#comment-17283180 ] David Eric Pugh commented on SOLR-15152: [~noble]what do you think of adding an e

[jira] [Comment Edited] (SOLR-15114) WAND does not work correctly on multiple segments in Solr 8.6.3

2021-02-11 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282783#comment-17282783 ] Tomas Eduardo Fernandez Lobbe edited comment on SOLR-15114 at 2/11/21, 5:08 PM: ---

[GitHub] [lucene-solr] tflobbe merged pull request #2259: SOLR-15114: WAND does not work correctly on multiple segments in Solr 8.6.3

2021-02-11 Thread GitBox
tflobbe merged pull request #2259: URL: https://github.com/apache/lucene-solr/pull/2259 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (SOLR-15114) WAND does not work correctly on multiple segments in Solr 8.6.3

2021-02-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283192#comment-17283192 ] ASF subversion and git services commented on SOLR-15114: Commit 0

[GitHub] [lucene-solr] jtibshirani merged pull request #2339: LUCENE-9705: Reset internal version in Lucene90FieldInfosFormat.

2021-02-11 Thread GitBox
jtibshirani merged pull request #2339: URL: https://github.com/apache/lucene-solr/pull/2339 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[jira] [Commented] (LUCENE-9705) Move all codec formats to the o.a.l.codecs.Lucene90 package

2021-02-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283195#comment-17283195 ] ASF subversion and git services commented on LUCENE-9705: - Commi

[jira] [Commented] (SOLR-15114) WAND does not work correctly on multiple segments in Solr 8.6.3

2021-02-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283204#comment-17283204 ] ASF subversion and git services commented on SOLR-15114: Commit b

[jira] [Created] (LUCENE-9765) Hunspell: rename SpellChecker to Hunspell, fix test name, update javadoc and CHANGES.txt

2021-02-11 Thread Peter Gromov (Jira)
Peter Gromov created LUCENE-9765: Summary: Hunspell: rename SpellChecker to Hunspell, fix test name, update javadoc and CHANGES.txt Key: LUCENE-9765 URL: https://issues.apache.org/jira/browse/LUCENE-9765

[GitHub] [lucene-solr] thelabdude merged pull request #2346: SOLR-15145: System property to control whether base_url is stored in state.json to enable back-compat with older SolrJ versions

2021-02-11 Thread GitBox
thelabdude merged pull request #2346: URL: https://github.com/apache/lucene-solr/pull/2346 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (SOLR-15145) Older versions of SolrJ (pre-8.8.0) hit an NPE when computing the base_url for core node props

2021-02-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283218#comment-17283218 ] ASF subversion and git services commented on SOLR-15145: Commit b

[GitHub] [lucene-solr] donnerpeter opened a new pull request #2354: LUCENE-9765: Hunspell: rename SpellChecker to Hunspell, fix test name…

2021-02-11 Thread GitBox
donnerpeter opened a new pull request #2354: URL: https://github.com/apache/lucene-solr/pull/2354 …, update javadoc and CHANGES.txt # Description The class names are imperfect and the docs are outdated # Solution Fix that # Tests No behav

[jira] [Commented] (SOLR-15114) WAND does not work correctly on multiple segments in Solr 8.6.3

2021-02-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283230#comment-17283230 ] ASF subversion and git services commented on SOLR-15114: Commit 3

[jira] [Commented] (SOLR-15114) WAND does not work correctly on multiple segments in Solr 8.6.3

2021-02-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283229#comment-17283229 ] ASF subversion and git services commented on SOLR-15114: Commit 6

[jira] [Commented] (SOLR-15114) WAND does not work correctly on multiple segments in Solr 8.6.3

2021-02-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283233#comment-17283233 ] ASF subversion and git services commented on SOLR-15114: Commit 0

[jira] [Commented] (SOLR-15114) WAND does not work correctly on multiple segments in Solr 8.6.3

2021-02-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283234#comment-17283234 ] ASF subversion and git services commented on SOLR-15114: Commit 3

[jira] [Updated] (SOLR-15114) WAND does not work correctly on multiple segments in Solr 8.6.3

2021-02-11 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Eduardo Fernandez Lobbe updated SOLR-15114: - Fix Version/s: 8.9 Resolution: Fixed Status: Res

[jira] [Updated] (SOLR-15114) WAND does not work correctly on multiple segments in Solr 8.6.3

2021-02-11 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Eduardo Fernandez Lobbe updated SOLR-15114: - Affects Version/s: (was: 8.6.3) (wa

[GitHub] [lucene-solr] thelabdude opened a new pull request #2355: SOLR-15145: solr.storeBaseUrl feature flag introduced in 8.8.1 should default to false for 9.x

2021-02-11 Thread GitBox
thelabdude opened a new pull request #2355: URL: https://github.com/apache/lucene-solr/pull/2355 Align solr's changes.txt with fixes going into 8x / 8.8 and change the default value of the `solr.storeBaseUrl` sys prop for master. ---

[jira] [Commented] (LUCENE-9755) Index Segment without DocValues May Cause Search to Fail

2021-02-11 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283264#comment-17283264 ] Mayya Sharipova commented on LUCENE-9755: - {quote}>> Consider the following scen

[GitHub] [lucene-solr] jpountz commented on pull request #2310: LUCENE-9705: Create Lucene90PostingsFormat

2021-02-11 Thread GitBox
jpountz commented on pull request #2310: URL: https://github.com/apache/lucene-solr/pull/2310#issuecomment-777686222 > I wonder if we should not version PFUtil classes, instead move then to a package under Util and change the visibility of the methods. Those classes seems more like a utili

[GitHub] [lucene-solr] jpountz commented on pull request #2310: LUCENE-9705: Create Lucene90PostingsFormat

2021-02-11 Thread GitBox
jpountz commented on pull request #2310: URL: https://github.com/apache/lucene-solr/pull/2310#issuecomment-777690621 > Any thoughts on naming or package structure for these classes? What about putting the current blocktree classes into the `org.apache.lucene.backward_codecs.lucene40`

[jira] [Updated] (SOLR-15132) Add window paramater to the nodes Streaming Expression

2021-02-11 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-15132: -- Attachment: SOLR-15132.patch > Add window paramater to the nodes Streaming Expression > ---

[GitHub] [lucene-solr] anshumg commented on a change in pull request #2355: SOLR-15145: solr.storeBaseUrl feature flag introduced in 8.8.1 should default to false for 9.x

2021-02-11 Thread GitBox
anshumg commented on a change in pull request #2355: URL: https://github.com/apache/lucene-solr/pull/2355#discussion_r574731370 ## File path: solr/solr-ref-guide/src/solr-upgrade-notes.adoc ## @@ -100,6 +100,12 @@ The default Prometheus Exporter configuration includes metrics

[GitHub] [lucene-solr-operator] HoustonPutman commented on issue #212: Solr cloud never getes deleted when reclaimPolicy is set to Delete

2021-02-11 Thread GitBox
HoustonPutman commented on issue #212: URL: https://github.com/apache/lucene-solr-operator/issues/212#issuecomment-777699251 So yes, this is actually expected behavior. If you want to delete your SolrCloud after deleting the Solr Operator, you will need to remove the finalizer from the So

[jira] [Commented] (SOLR-15150) add request level option to fail an atomic update if it can't be done 'in-place'

2021-02-11 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283283#comment-17283283 ] Chris M. Hostetter commented on SOLR-15150: --- David: yeah, we probably intermix

[GitHub] [lucene-solr-operator] HoustonPutman commented on issue #214: extensions/v1beta1 Ingress is deprecated

2021-02-11 Thread GitBox
HoustonPutman commented on issue #214: URL: https://github.com/apache/lucene-solr-operator/issues/214#issuecomment-777699761 We should go ahead and make sure that all dependent resources are up to date with the most recent version.

[GitHub] [lucene-solr] gerlowskija commented on pull request #2250: SOLR-13608: Incremental backup file format

2021-02-11 Thread GitBox
gerlowskija commented on pull request #2250: URL: https://github.com/apache/lucene-solr/pull/2250#issuecomment-00507 Totally agreed that we don't want the old format to linger. I tried to convey in documentation that it was deprecated and will be going away, hopefully those notes are

[GitHub] [lucene-solr] gerlowskija edited a comment on pull request #2250: SOLR-13608: Incremental backup file format

2021-02-11 Thread GitBox
gerlowskija edited a comment on pull request #2250: URL: https://github.com/apache/lucene-solr/pull/2250#issuecomment-00507 Totally agreed @epugh that we don't want the old format to linger. I tried to convey in documentation that it was deprecated and will be going away, hopefully th

[GitHub] [lucene-solr] gerlowskija edited a comment on pull request #2250: SOLR-13608: Incremental backup file format

2021-02-11 Thread GitBox
gerlowskija edited a comment on pull request #2250: URL: https://github.com/apache/lucene-solr/pull/2250#issuecomment-00507 Totally agreed @epugh that we don't want the old format to linger. I tried to convey in documentation that it was deprecated and will be going away, hopefully th

[GitHub] [lucene-solr] epugh opened a new pull request #2356: SOLR-15152: Export Tool should export nested docs cleanly in .json, .jsonl, and javabin

2021-02-11 Thread GitBox
epugh opened a new pull request #2356: URL: https://github.com/apache/lucene-solr/pull/2356 # Description Export tool says it uses json, but it's actually a json lines format. It ignores anonymous and nested docs. # Solution * Tweaked the writer to properly handle ano

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2021-02-11 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283304#comment-17283304 ] Dawid Weiss commented on SOLR-14920: Just to follow-up to what Erick said (hi Erick,

  1   2   >