epugh opened a new pull request #2356: URL: https://github.com/apache/lucene-solr/pull/2356
# Description Export tool says it uses json, but it's actually a json lines format. It ignores anonymous and nested docs. # Solution * Tweaked the writer to properly handle anonymous and regular nested docs when exporting data. * Renamed the existing `json` format to `jsonl`, and introduced a proper `json` format. * Introduce explicit DocSinks per format, `json`, `jsonl`, and `javabin`. Now, with the `json` format you can export and then reimport the Solr docs, including with child docs. # Tests I've added a new `TestExportToolWithNestedDocs`, and extended the existing `TestExportTool` tests. The setup for the tests was quite different, so I didn't make them all one file. # Checklist Please review the following and check all that apply: - [ X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [ X] I have created a Jira issue and added the issue ID to my pull request title. - [ X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [ X] I have developed this patch against the `master` branch. - [ ] I have run `./gradlew check`. - [ X] I have added tests for my changes. - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
