[
https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283037#comment-17283037
]
Erick Erickson commented on SOLR-14920:
---------------------------------------
My take re: the reference impl is that the code formatting will not be made
more difficult by waiting for the resolution of the reference impl. However,
trying to apply the automatic code formatting _before_ the reference impl is
resolved will almost inevitably add work. I see three possibilities:
* Reconciling the ref impl will be made more difficult if we just do master,
* This is actually quite a bit of work, and doing it in parallel on the
reference impl and master is wasted effort
* Cherry picking code that isn't heavily touched on on the reference impl to
reformat on master is both uncertain and extra work.
Plus making a single commit with _all_ formatting changes so git blame and the
like doesn't get confused is harder.
We've lived with the formatting anomalies for many years, I don't see the
driver for pushing this forward before the reference impl is resolved, there
are better places to spend the effort IMO.
> Format code automatically and enforce it in Solr
> ------------------------------------------------
>
> Key: SOLR-14920
> URL: https://issues.apache.org/jira/browse/SOLR-14920
> Project: Solr
> Issue Type: Improvement
> Reporter: Erick Erickson
> Priority: Major
> Labels: codestyle, formatting
>
> See the discussion at: LUCENE-9564.
> This is a placeholder for the present, I'm reluctant to do this to the Solr
> code base until after:
> * we have some Solr-specific consensus
> * we have some clue what this means for the reference impl.
> Reconciling the reference impl will be difficult enough without a zillion
> format changes to add to the confusion.
> So my proposal is
> 1> do this.
> 2> Postpone this until after the reference impl is merged.
> 3> do this in one single commit for reasons like being able to conveniently
> have this separated out from git blame.
> Assigning to myself so it doesn't get lost, but anyone who wants to take it
> over please feel free.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
