iverase commented on pull request #2094:
URL: https://github.com/apache/lucene-solr/pull/2094#issuecomment-732735040
@jpountz @dweiss I tried again by wrapping the IndexOutput / IndexInput
unsuccessfully. I think the reason is that in some cases we use temporary
buffers via `ByteBuffersDat
dweiss commented on pull request #2094:
URL: https://github.com/apache/lucene-solr/pull/2094#issuecomment-732744204
Thanks @iverase !
I admit I grew up with big endian (assembly on M68k) and little endian
always confused the hell out of me looking at memory hex dumps... but even my
iverase commented on pull request #2094:
URL: https://github.com/apache/lucene-solr/pull/2094#issuecomment-732765973
@dweiss This should be only a temporary situation. The idea is to create
new codecs that would not wrap those calls. The current codecs will be move to
backwards codecs and
alessandrobenedetti merged pull request #2096:
URL: https://github.com/apache/lucene-solr/pull/2096
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dweiss commented on pull request #2094:
URL: https://github.com/apache/lucene-solr/pull/2094#issuecomment-732797761
But these methods are all over classes that are reused across codecs - not
just codec-specific ones (CodecUtil, etc.)... once you commit this in something
tells me they'll re
[
https://issues.apache.org/jira/browse/SOLR-15015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238013#comment-17238013
]
ASF subversion and git services commented on SOLR-15015:
Commit 4
[
https://issues.apache.org/jira/browse/SOLR-15015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238017#comment-17238017
]
ASF subversion and git services commented on SOLR-15015:
Commit c
[
https://issues.apache.org/jira/browse/SOLR-15015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238023#comment-17238023
]
ASF subversion and git services commented on SOLR-15015:
Commit 6
[
https://issues.apache.org/jira/browse/SOLR-15015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti updated SOLR-15015:
Fix Version/s: 8.8
master (9.0)
> Add support for Interleaving A
[
https://issues.apache.org/jira/browse/SOLR-15015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti resolved SOLR-15015.
-
Resolution: Fixed
Merged in master / 8.x branch
> Add support for Interleaving A
jpountz commented on a change in pull request #2094:
URL: https://github.com/apache/lucene-solr/pull/2094#discussion_r529369260
##
File path: lucene/core/src/java/org/apache/lucene/codecs/CodecUtil.java
##
@@ -570,6 +571,23 @@ static void writeCRC(IndexOutput output) throws
IO
jpountz commented on pull request #2094:
URL: https://github.com/apache/lucene-solr/pull/2094#issuecomment-732827520
> But these methods are all over classes that are reused across codecs - not
just codec-specific ones (CodecUtil, etc.)... once you commit this in something
tells me they'll
dweiss commented on pull request #2094:
URL: https://github.com/apache/lucene-solr/pull/2094#issuecomment-732846144
Sure, Adrien. Guys, don't get me wrong - I'm not vetoing the change, I'm
just saying it looks terrible with all those calls all over the place. :) But I
also can't sit on thi
s1monw merged pull request #2085:
URL: https://github.com/apache/lucene-solr/pull/2085
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/LUCENE-9508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238072#comment-17238072
]
ASF subversion and git services commented on LUCENE-9508:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simon Willnauer resolved LUCENE-9508.
-
Fix Version/s: 8.8
master (9.0)
Lucene Fields: New,Patch Available
[
https://issues.apache.org/jira/browse/LUCENE-9508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238077#comment-17238077
]
ASF subversion and git services commented on LUCENE-9508:
-
Commi
iverase commented on a change in pull request #2094:
URL: https://github.com/apache/lucene-solr/pull/2094#discussion_r529536245
##
File path: lucene/core/src/java/org/apache/lucene/codecs/CodecUtil.java
##
@@ -570,6 +571,23 @@ static void writeCRC(IndexOutput output) throws
IO
iverase commented on a change in pull request #2094:
URL: https://github.com/apache/lucene-solr/pull/2094#discussion_r529536955
##
File path: lucene/core/src/java/org/apache/lucene/search/SortField.java
##
@@ -148,12 +149,12 @@ public Provider() {
@Override
public S
iverase commented on a change in pull request #2094:
URL: https://github.com/apache/lucene-solr/pull/2094#discussion_r529537082
##
File path:
lucene/core/src/java/org/apache/lucene/search/SortedNumericSortField.java
##
@@ -106,20 +107,21 @@ public Provider() {
@Override
iverase commented on a change in pull request #2094:
URL: https://github.com/apache/lucene-solr/pull/2094#discussion_r529537298
##
File path: lucene/core/src/java/org/apache/lucene/store/DataInput.java
##
@@ -155,26 +160,25 @@ public int readZInt() throws IOException {
* @s
iverase commented on a change in pull request #2094:
URL: https://github.com/apache/lucene-solr/pull/2094#discussion_r529539404
##
File path:
lucene/replicator/src/java/org/apache/lucene/replicator/nrt/CopyOneFile.java
##
@@ -96,11 +96,12 @@ public boolean visit() throws IOExc
iverase commented on a change in pull request #2094:
URL: https://github.com/apache/lucene-solr/pull/2094#discussion_r529539703
##
File path:
lucene/core/src/java/org/apache/lucene/util/bkd/OfflinePointWriter.java
##
@@ -54,7 +54,10 @@ public void append(byte[] packedValue, in
iverase commented on a change in pull request #2094:
URL: https://github.com/apache/lucene-solr/pull/2094#discussion_r529540139
##
File path: lucene/core/src/java/org/apache/lucene/store/DataOutput.java
##
@@ -210,8 +210,14 @@ public final void writeZInt(int i) throws IOExcepti
jpountz commented on pull request #2094:
URL: https://github.com/apache/lucene-solr/pull/2094#issuecomment-732970250
@dweiss I don't think I had got you wrong, I wanted to make sure I had
understood what you meant and that I was not missing a simplification for the
backward-compatibility l
iverase commented on pull request #2094:
URL: https://github.com/apache/lucene-solr/pull/2094#issuecomment-732975608
I addressed Adrien's comments and introduce a
`EndiannessReverserIndexOutput`. This allows to remove all the reverse dancing
from the `SortFields` and those classes remain u
iverase commented on a change in pull request #2094:
URL: https://github.com/apache/lucene-solr/pull/2094#discussion_r529553632
##
File path: lucene/core/src/java/org/apache/lucene/store/DataInput.java
##
@@ -92,15 +92,20 @@ public void readBytes(byte[] b, int offset, int len,
[
https://issues.apache.org/jira/browse/LUCENE-9614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238133#comment-17238133
]
Michael Sokolov commented on LUCENE-9614:
-
> I wonder if the Query could be just
[
https://issues.apache.org/jira/browse/LUCENE-9614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238144#comment-17238144
]
Adrien Grand commented on LUCENE-9614:
--
Yes, caching relies on it though we always
[
https://issues.apache.org/jira/browse/SOLR-14990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson resolved SOLR-14990.
---
Resolution: Cannot Reproduce
Apparently fixed by LUCENE-9536
> Reproducing test failure for
[
https://issues.apache.org/jira/browse/SOLR-15010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238332#comment-17238332
]
David Smiley commented on SOLR-15010:
-
The reason this is happening is very very like
[
https://issues.apache.org/jira/browse/SOLR-15010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238340#comment-17238340
]
David Eric Pugh commented on SOLR-15010:
This would solve my frustration with see
iverase merged pull request #2093:
URL: https://github.com/apache/lucene-solr/pull/2093
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/LUCENE-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238581#comment-17238581
]
ASF subversion and git services commented on LUCENE-9606:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238582#comment-17238582
]
ASF subversion and git services commented on LUCENE-9606:
-
Commi
iverase commented on pull request #2093:
URL: https://github.com/apache/lucene-solr/pull/2093#issuecomment-733529325
Thanks @dsmiley!
This is an automated message from the Apache Git Service.
To respond to the message, pleas
[
https://issues.apache.org/jira/browse/LUCENE-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera resolved LUCENE-9606.
--
Fix Version/s: 8.8
Assignee: Ignacio Vera
Resolution: Fixed
> Wrap boolean que
37 matches
Mail list logo
