iverase commented on a change in pull request #2094:
URL: https://github.com/apache/lucene-solr/pull/2094#discussion_r529537298
##########
File path: lucene/core/src/java/org/apache/lucene/store/DataInput.java
##########
@@ -155,26 +160,25 @@ public int readZInt() throws IOException {
* @see DataOutput#writeLong(long)
*/
public long readLong() throws IOException {
- return (((long)readInt()) << 32) | (readInt() & 0xFFFFFFFFL);
+ final byte b1 = readByte();
+ final byte b2 = readByte();
+ final byte b3 = readByte();
+ final byte b4 = readByte();
+ final byte b5 = readByte();
+ final byte b6 = readByte();
+ final byte b7 = readByte();
+ final byte b8 = readByte();
+ return ((b8 & 0xFFL) << 56) | (b7 & 0xFFL) << 48 | (b6 & 0xFFL) << 40 |
(b5 & 0xFFL) << 32
+ | (b4 & 0xFFL) << 24 | (b3 & 0xFFL) << 16 | (b2 & 0xFFL) << 8 |
(b1 & 0xFFL);
}
/**
- * Read a specified number of longs with the little endian byte order.
- * <p>This method can be used to read longs whose bytes have been
- * {@link Long#reverseBytes reversed} at write time:
- * <pre class="prettyprint">
- * for (long l : longs) {
- * output.writeLong(Long.reverseBytes(l));
- * }
- * </pre>
- * @lucene.experimental
Review comment:
yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
