[jira] [Commented] (SOLR-14914) Add option to disable metrics collection

2020-10-16 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215227#comment-17215227 ] Andrzej Bialecki commented on SOLR-14914: - bq. So, you mean nobody will know what

[jira] [Commented] (SOLR-14930) remove rulebased replica placement strategy

2020-10-16 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215233#comment-17215233 ] Ilan Ginzburg commented on SOLR-14930: -- The removed package is {{org.apache.solr.clo

[GitHub] [lucene-solr] jpountz commented on pull request #1976: LUCENE-9578: TermRangeQuery empty string lower bound edge case

2020-10-16 Thread GitBox
jpountz commented on pull request #1976: URL: https://github.com/apache/lucene-solr/pull/1976#issuecomment-709879225 I had a deeper look to check whether this could be an indicator of other bugs lurking, but it doesn't seem so and the fix looks good to me. For reference here's what the aut

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1978: LUCENE-9524: Fix NPE in SpanWeight#explain when no scoring is require…

2020-10-16 Thread GitBox
jpountz commented on a change in pull request #1978: URL: https://github.com/apache/lucene-solr/pull/1978#discussion_r506130527 ## File path: lucene/core/build.gradle ## @@ -22,4 +22,5 @@ description = 'Lucene core library' dependencies { testImplementation project(':lucene

[GitHub] [lucene-solr] janhoy commented on pull request #1990: Branch 8x SSRF

2020-10-16 Thread GitBox
janhoy commented on pull request #1990: URL: https://github.com/apache/lucene-solr/pull/1990#issuecomment-709896793 This PR tries to merge branch_8x into master, which does not make sense. If you want to report a security issue, please follow the procedure at https://lucene.apache.or

[jira] [Commented] (SOLR-14914) Add option to disable metrics collection

2020-10-16 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215257#comment-17215257 ] Noble Paul commented on SOLR-14914: --- {quote}What kind of question is that??? You seem t

[GitHub] [lucene-solr] cbuescher commented on pull request #1976: LUCENE-9578: TermRangeQuery empty string lower bound edge case

2020-10-16 Thread GitBox
cbuescher commented on pull request #1976: URL: https://github.com/apache/lucene-solr/pull/1976#issuecomment-709934841 @jpountz thanks, I renamed the method. btw. would this change also be backported to the latest 8.7 branch so we can use it in ES to fix https://github.com/elastic/elastics

[jira] [Commented] (LUCENE-9576) nuke SSD detection: was IndexWriter::commit() hangs when the server has a stale NFS mount.

2020-10-16 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215291#comment-17215291 ] Michael McCandless commented on LUCENE-9576: Yup I agree.  Nice mount points

[jira] [Updated] (SOLR-13528) Rate limiting in Solr

2020-10-16 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma updated SOLR-13528: --- Fix Version/s: master (9.0) > Rate limiting in Solr > - > > Key:

[jira] [Commented] (SOLR-14615) CPU Based Circuit Breaker

2020-10-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215302#comment-17215302 ] ASF subversion and git services commented on SOLR-14615: Commit c

[jira] [Commented] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-10-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215300#comment-17215300 ] ASF subversion and git services commented on SOLR-14588: Commit 4

[jira] [Resolved] (SOLR-13528) Rate limiting in Solr

2020-10-16 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma resolved SOLR-13528. Resolution: Fixed > Rate limiting in Solr > - > > Key: SOLR-135

[jira] [Commented] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-10-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215301#comment-17215301 ] ASF subversion and git services commented on SOLR-14588: Commit 4

[GitHub] [lucene-solr] janhoy closed pull request #1990: Branch 8x SSRF

2020-10-16 Thread GitBox
janhoy closed pull request #1990: URL: https://github.com/apache/lucene-solr/pull/1990 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] poke19962008 opened a new pull request #1991: SOLR-14933: Ability to add T and P type replica from admin UI

2020-10-16 Thread GitBox
poke19962008 opened a new pull request #1991: URL: https://github.com/apache/lucene-solr/pull/1991 # Description As of now we can already add NRT replica from admin UI. Would look to add drop down listing all types of replicas along with the live nodes drop down. With my per

[jira] [Commented] (SOLR-14651) Metrics history could disable itself better

2020-10-16 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215329#comment-17215329 ] Andrzej Bialecki commented on SOLR-14651: - [~dsmiley] I think I fixed that NPE in

[jira] [Comment Edited] (SOLR-14651) Metrics history could disable itself better

2020-10-16 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215329#comment-17215329 ] Andrzej Bialecki edited comment on SOLR-14651 at 10/16/20, 10:36 AM: --

[jira] [Created] (SOLR-14939) JSON facets: range faceting to support cache=false parameter

2020-10-16 Thread Christine Poerschke (Jira)
Christine Poerschke created SOLR-14939: -- Summary: JSON facets: range faceting to support cache=false parameter Key: SOLR-14939 URL: https://issues.apache.org/jira/browse/SOLR-14939 Project: Solr

[jira] [Commented] (SOLR-14907) Support single file upload/overwrite in configSet API

2020-10-16 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215360#comment-17215360 ] David Smiley commented on SOLR-14907: - +1 to everything Noble said. V2 has been "the

[jira] [Assigned] (SOLR-14933) Ability to add T and P type replica from admin UI

2020-10-16 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Eric Pugh reassigned SOLR-14933: -- Assignee: David Eric Pugh > Ability to add T and P type replica from admin UI > --

[jira] [Commented] (SOLR-14914) Add option to disable metrics collection

2020-10-16 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215363#comment-17215363 ] David Smiley commented on SOLR-14914: - I just looked at the docs, which seem fine to

[GitHub] [lucene-solr] cpoerschke opened a new pull request #1992: SOLR-14939: JSON range faceting to support cache=false parameter

2020-10-16 Thread GitBox
cpoerschke opened a new pull request #1992: URL: https://github.com/apache/lucene-solr/pull/1992 https://issues.apache.org/jira/browse/SOLR-14939 This is an automated message from the Apache Git Service. To respond to the mes

[jira] [Commented] (SOLR-14651) Metrics history could disable itself better

2020-10-16 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215365#comment-17215365 ] David Smiley commented on SOLR-14651: - I can sympathize with ensuring /admin/metrics

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #1978: LUCENE-9524: Fix NPE in SpanWeight#explain when no scoring is require…

2020-10-16 Thread GitBox
zacharymorn commented on a change in pull request #1978: URL: https://github.com/apache/lucene-solr/pull/1978#discussion_r506355787 ## File path: lucene/core/build.gradle ## @@ -22,4 +22,5 @@ description = 'Lucene core library' dependencies { testImplementation project(':lu

[jira] [Commented] (SOLR-14651) Metrics history could disable itself better

2020-10-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215367#comment-17215367 ] ASF subversion and git services commented on SOLR-14651: Commit 6

[jira] [Commented] (SOLR-14651) Metrics history could disable itself better

2020-10-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215369#comment-17215369 ] ASF subversion and git services commented on SOLR-14651: Commit 8

[jira] [Commented] (SOLR-14483) AdminUI - Create replica - empty drop-down

2020-10-16 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215370#comment-17215370 ] David Smiley commented on SOLR-14483: - Eric, next time please write a commit message

[jira] [Commented] (LUCENE-9576) nuke SSD detection: was IndexWriter::commit() hangs when the server has a stale NFS mount.

2020-10-16 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215379#comment-17215379 ] Michael McCandless commented on LUCENE-9576: +1 for the latest patch.  The p

[GitHub] [lucene-solr] msokolov commented on pull request #1930: LUCENE-9322: add VectorValues to new Lucene90 codec

2020-10-16 Thread GitBox
msokolov commented on pull request #1930: URL: https://github.com/apache/lucene-solr/pull/1930#issuecomment-710028939 So .. this has been out for 17 days now - I'd like to commit in the next day or so in order to enable moving forward with the matching piece of this, adding some benchmarki

[jira] [Commented] (LUCENE-9575) Add PatternTypingFilter

2020-10-16 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215382#comment-17215382 ] Michael McCandless commented on LUCENE-9575: +1, this sounds cool! Would it

[GitHub] [lucene-solr] dsmiley opened a new pull request #1993: .gitignore clean up

2020-10-16 Thread GitBox
dsmiley opened a new pull request #1993: URL: https://github.com/apache/lucene-solr/pull/1993 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [lucene-solr] poke19962008 commented on pull request #1991: SOLR-14933: Ability to add T and P type replica from admin UI

2020-10-16 Thread GitBox
poke19962008 commented on pull request #1991: URL: https://github.com/apache/lucene-solr/pull/1991#issuecomment-710035112 @epugh @ErickErickson Please help reviewing this. As it's my first, time I was thinking to fix the listed feature in jira comments in small PRs with separate jira. Wdyt

[GitHub] [lucene-solr] mikemccand commented on pull request #1930: LUCENE-9322: add VectorValues to new Lucene90 codec

2020-10-16 Thread GitBox
mikemccand commented on pull request #1930: URL: https://github.com/apache/lucene-solr/pull/1930#issuecomment-710035455 > So .. this has been out for 17 days now - I'd like to commit in the next day or so in order to enable moving forward with the matching piece of this, adding some benchm

[jira] [Commented] (SOLR-14914) Add option to disable metrics collection

2020-10-16 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215387#comment-17215387 ] Noble Paul commented on SOLR-14914: --- I'm not talking about the ref guide We need to be

[GitHub] [lucene-solr] msokolov commented on a change in pull request #1993: .gitignore clean up

2020-10-16 Thread GitBox
msokolov commented on a change in pull request #1993: URL: https://github.com/apache/lucene-solr/pull/1993#discussion_r506427822 ## File path: .gitignore ## @@ -1,42 +1,30 @@ -# . -/eclipse-build -/maven-build -/classes -build -/idea-build -dist -lib -test-lib -/*~ -/build.prop

[GitHub] [lucene-solr] epugh commented on pull request #1991: SOLR-14933: Ability to add T and P type replica from admin UI

2020-10-16 Thread GitBox
epugh commented on pull request #1991: URL: https://github.com/apache/lucene-solr/pull/1991#issuecomment-710074376 I just demoed your feature to a client who is learning about Solr Cloud ;-) Live testing of the feature, and it worked great. Smaller PR's with seperate JIRA's make sen

[jira] [Created] (SOLR-14940) ReplicationHandler memory leak through SolrCore.closeHooks

2020-10-16 Thread Anver Sotnikov (Jira)
Anver Sotnikov created SOLR-14940: - Summary: ReplicationHandler memory leak through SolrCore.closeHooks Key: SOLR-14940 URL: https://issues.apache.org/jira/browse/SOLR-14940 Project: Solr Iss

[jira] [Created] (SOLR-14941) mention 'ant server' equivalent(s) in gradle's :helpAnt target

2020-10-16 Thread Christine Poerschke (Jira)
Christine Poerschke created SOLR-14941: -- Summary: mention 'ant server' equivalent(s) in gradle's :helpAnt target Key: SOLR-14941 URL: https://issues.apache.org/jira/browse/SOLR-14941 Project: Sol

[GitHub] [lucene-solr] cpoerschke opened a new pull request #1994: Mention 'ant server' equivalent(s) in help/ant.txt file.

2020-10-16 Thread GitBox
cpoerschke opened a new pull request #1994: URL: https://github.com/apache/lucene-solr/pull/1994 https://issues.apache.org/jira/browse/SOLR-14941 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [lucene-solr] epugh commented on pull request #1991: SOLR-14933: Ability to add T and P type replica from admin UI

2020-10-16 Thread GitBox
epugh commented on pull request #1991: URL: https://github.com/apache/lucene-solr/pull/1991#issuecomment-710079893 Looks good to me. This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (SOLR-14933) Ability to add T and P type replica from admin UI

2020-10-16 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215419#comment-17215419 ] David Eric Pugh commented on SOLR-14933: Can I make a vote on REINDEXCOLLECTION a

[jira] [Commented] (SOLR-14941) mention 'ant server' equivalent(s) in gradle's :helpAnt target

2020-10-16 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215421#comment-17215421 ] Christine Poerschke commented on SOLR-14941: Opened [https://github.com/apach

[jira] [Comment Edited] (SOLR-14941) mention 'ant server' equivalent(s) in gradle's :helpAnt target

2020-10-16 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215421#comment-17215421 ] Christine Poerschke edited comment on SOLR-14941 at 10/16/20, 2:30 PM:

[jira] [Comment Edited] (SOLR-14941) mention 'ant server' equivalent(s) in gradle's :helpAnt target

2020-10-16 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215421#comment-17215421 ] Christine Poerschke edited comment on SOLR-14941 at 10/16/20, 2:31 PM:

[jira] [Created] (SOLR-14942) Reduce leader election time on node shutdown

2020-10-16 Thread Shalin Shekhar Mangar (Jira)
Shalin Shekhar Mangar created SOLR-14942: Summary: Reduce leader election time on node shutdown Key: SOLR-14942 URL: https://issues.apache.org/jira/browse/SOLR-14942 Project: Solr Iss

[jira] [Commented] (LUCENE-9575) Add PatternTypingFilter

2020-10-16 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215434#comment-17215434 ] Gus Heck commented on LUCENE-9575: -- Yeah I looked at our FST based regex class, but as

[jira] [Commented] (SOLR-14933) Ability to add T and P type replica from admin UI

2020-10-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215437#comment-17215437 ] ASF subversion and git services commented on SOLR-14933: Commit 7

[jira] [Commented] (SOLR-14933) Ability to add T and P type replica from admin UI

2020-10-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215439#comment-17215439 ] ASF subversion and git services commented on SOLR-14933: Commit 5

[jira] [Resolved] (SOLR-14933) Ability to add T and P type replica from admin UI

2020-10-16 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Eric Pugh resolved SOLR-14933. Fix Version/s: 8.7 Resolution: Fixed > Ability to add T and P type replica from admi

[GitHub] [lucene-solr] epugh commented on pull request #1991: SOLR-14933: Ability to add T and P type replica from admin UI

2020-10-16 Thread GitBox
epugh commented on pull request #1991: URL: https://github.com/apache/lucene-solr/pull/1991#issuecomment-710102993 @poke19962008 did you want the hacktoberfest tag added? This is an automated message from the Apache Git Servi

[GitHub] [lucene-solr] gus-asf opened a new pull request #1995: LUCENE-9575 Add PatternTypingFilter to annotate tokens with flags and types

2020-10-16 Thread GitBox
gus-asf opened a new pull request #1995: URL: https://github.com/apache/lucene-solr/pull/1995 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[jira] [Commented] (SOLR-14483) AdminUI - Create replica - empty drop-down

2020-10-16 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215445#comment-17215445 ] David Eric Pugh commented on SOLR-14483: Just saw your above comment, so I think

[jira] [Comment Edited] (LUCENE-9575) Add PatternTypingFilter

2020-10-16 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215434#comment-17215434 ] Gus Heck edited comment on LUCENE-9575 at 10/16/20, 3:15 PM: -

[GitHub] [lucene-solr] poke19962008 commented on pull request #1991: SOLR-14933: Ability to add T and P type replica from admin UI

2020-10-16 Thread GitBox
poke19962008 commented on pull request #1991: URL: https://github.com/apache/lucene-solr/pull/1991#issuecomment-710115440 @epugh yeah sure let's add it. Tx! This is an automated message from the Apache Git Service. To respond

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1995: LUCENE-9575 Add PatternTypingFilter to annotate tokens with flags and types

2020-10-16 Thread GitBox
uschindler commented on a change in pull request #1995: URL: https://github.com/apache/lucene-solr/pull/1995#discussion_r506532094 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/pattern/PatternTypingFilter.java ## @@ -0,0 +1,78 @@ +/* + * Licensed to

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1995: LUCENE-9575 Add PatternTypingFilter to annotate tokens with flags and types

2020-10-16 Thread GitBox
uschindler commented on a change in pull request #1995: URL: https://github.com/apache/lucene-solr/pull/1995#discussion_r506550995 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/pattern/PatternTypingFilter.java ## @@ -0,0 +1,78 @@ +/* + * Licensed to

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1994: Mention 'ant server' equivalent(s) in help/ant.txt file.

2020-10-16 Thread GitBox
dweiss commented on a change in pull request #1994: URL: https://github.com/apache/lucene-solr/pull/1994#discussion_r506559096 ## File path: help/ant.txt ## @@ -38,6 +38,11 @@ ant idea=> gradlew idea [better: import as a Gradle project Solr-specific target

[GitHub] [lucene-solr] epugh commented on pull request #1989: SOLR-14549 - Fix listing of Files in a Directory on Solr Admin UI

2020-10-16 Thread GitBox
epugh commented on pull request #1989: URL: https://github.com/apache/lucene-solr/pull/1989#issuecomment-710127601 @risdenk I tested this out, and it works. Yay! I *do* see a screen flicker when you click around the tree, the whole browser window, not just the area where the jst

[jira] [Updated] (LUCENE-9573) Add back compat tests for VectorFormat to TestBackwardsCompatibility

2020-10-16 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-9573: --- Fix Version/s: master (9.0) > Add back compat tests for VectorFormat to TestBackward

[jira] [Commented] (LUCENE-9573) Add back compat tests for VectorFormat to TestBackwardsCompatibility

2020-10-16 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215467#comment-17215467 ] Michael McCandless commented on LUCENE-9573: +1, this should be a blocker fo

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1930: LUCENE-9322: add VectorValues to new Lucene90 codec

2020-10-16 Thread GitBox
mikemccand commented on a change in pull request #1930: URL: https://github.com/apache/lucene-solr/pull/1930#discussion_r506561868 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90VectorReader.java ## @@ -0,0 +1,344 @@ +/* + * Licensed to the Apache

[GitHub] [lucene-solr] jpountz merged pull request #1978: LUCENE-9524: Fix NPE in SpanWeight#explain when no scoring is require…

2020-10-16 Thread GitBox
jpountz merged pull request #1978: URL: https://github.com/apache/lucene-solr/pull/1978 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-9578) TermRangeQuery with empty string lower bound edge case

2020-10-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215514#comment-17215514 ] ASF subversion and git services commented on LUCENE-9578: - Commi

[jira] [Commented] (LUCENE-9524) NullPointerException in IndexSearcher.explain() when using ComplexPhraseQueryParser

2020-10-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215513#comment-17215513 ] ASF subversion and git services commented on LUCENE-9524: - Commi

[GitHub] [lucene-solr] epugh merged pull request #1991: SOLR-14933: Ability to add T and P type replica from admin UI

2020-10-16 Thread GitBox
epugh merged pull request #1991: URL: https://github.com/apache/lucene-solr/pull/1991 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Commented] (SOLR-14907) Support single file upload/overwrite in configSet API

2020-10-16 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215516#comment-17215516 ] Houston Putman commented on SOLR-14907: --- Working on a PR today, will likely incorpo

[GitHub] [lucene-solr] jpountz commented on pull request #1978: LUCENE-9524: Fix NPE in SpanWeight#explain when no scoring is require…

2020-10-16 Thread GitBox
jpountz commented on pull request #1978: URL: https://github.com/apache/lucene-solr/pull/1978#issuecomment-710259006 Thanks @zacharymorn ! This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [lucene-solr] jpountz commented on pull request #1976: LUCENE-9578: TermRangeQuery empty string lower bound edge case

2020-10-16 Thread GitBox
jpountz commented on pull request #1976: URL: https://github.com/apache/lucene-solr/pull/1976#issuecomment-710258539 The 8.7 branch has not been cut yet so this will be in 8.7. This change looked safe to me so I felt free to merge in spite of the branch being imminently cut.

[jira] [Commented] (LUCENE-9578) TermRangeQuery with empty string lower bound edge case

2020-10-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215540#comment-17215540 ] ASF subversion and git services commented on LUCENE-9578: - Commi

[jira] [Resolved] (LUCENE-9578) TermRangeQuery with empty string lower bound edge case

2020-10-16 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-9578. -- Fix Version/s: 8.7 Resolution: Fixed Thanks Christoph! > TermRangeQuery with empty str

[jira] [Commented] (LUCENE-9524) NullPointerException in IndexSearcher.explain() when using ComplexPhraseQueryParser

2020-10-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215541#comment-17215541 ] ASF subversion and git services commented on LUCENE-9524: - Commi

[jira] [Commented] (LUCENE-9578) TermRangeQuery with empty string lower bound edge case

2020-10-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215539#comment-17215539 ] ASF subversion and git services commented on LUCENE-9578: - Commi

[jira] [Resolved] (LUCENE-9524) NullPointerException in IndexSearcher.explain() when using ComplexPhraseQueryParser

2020-10-16 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-9524. -- Fix Version/s: 8.7 Resolution: Fixed > NullPointerException in IndexSearcher.explain()

[jira] [Commented] (LUCENE-9578) TermRangeQuery with empty string lower bound edge case

2020-10-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215550#comment-17215550 ] ASF subversion and git services commented on LUCENE-9578: - Commi

[jira] [Commented] (LUCENE-9524) NullPointerException in IndexSearcher.explain() when using ComplexPhraseQueryParser

2020-10-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215551#comment-17215551 ] ASF subversion and git services commented on LUCENE-9524: - Commi

[GitHub] [lucene-solr] HoustonPutman opened a new pull request #1996: SOLR-14907: Adding V2 API for ConfigSet Upload.

2020-10-16 Thread GitBox
HoustonPutman opened a new pull request #1996: URL: https://github.com/apache/lucene-solr/pull/1996 https://issues.apache.org/jira/browse/SOLR-14907 Adding v2 APIs. This is an automated message from the Apache Git Serv

[GitHub] [lucene-solr] msokolov commented on a change in pull request #1930: LUCENE-9322: add VectorValues to new Lucene90 codec

2020-10-16 Thread GitBox
msokolov commented on a change in pull request #1930: URL: https://github.com/apache/lucene-solr/pull/1930#discussion_r506623857 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90VectorReader.java ## @@ -0,0 +1,344 @@ +/* + * Licensed to the Apache S

[GitHub] [lucene-solr] anverus opened a new pull request #1997: SOLR-14940: Add ability to remove SolrCore.closeHooks. Keep reference…

2020-10-16 Thread GitBox
anverus opened a new pull request #1997: URL: https://github.com/apache/lucene-solr/pull/1997 …s to CloseHooks in ReplicationHandler and remove them on ReplicationHandler.shutdown() # Description Please provide a short description of the changes you're making with

[GitHub] [lucene-solr] jpountz merged pull request #1976: LUCENE-9578: TermRangeQuery empty string lower bound edge case

2020-10-16 Thread GitBox
jpountz merged pull request #1976: URL: https://github.com/apache/lucene-solr/pull/1976 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] msokolov commented on a change in pull request #1930: LUCENE-9322: add VectorValues to new Lucene90 codec

2020-10-16 Thread GitBox
msokolov commented on a change in pull request #1930: URL: https://github.com/apache/lucene-solr/pull/1930#discussion_r506677596 ## File path: lucene/core/src/java/org/apache/lucene/index/VectorValues.java ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [lucene-solr] muse-dev[bot] commented on a change in pull request #1997: SOLR-14940: Add ability to remove SolrCore.closeHooks. Keep reference…

2020-10-16 Thread GitBox
muse-dev[bot] commented on a change in pull request #1997: URL: https://github.com/apache/lucene-solr/pull/1997#discussion_r506688097 ## File path: solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java ## @@ -415,19 +415,15 @@ private void fetchIndex(SolrParams sol

[jira] [Commented] (SOLR-13654) Scary jenkins failure related to collection creation: "non legacy mode coreNodeName missing"

2020-10-16 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215631#comment-17215631 ] Erick Erickson commented on SOLR-13654: --- [~hossman] I think this can be closed? At

[GitHub] [lucene-solr] danmuzi commented on a change in pull request #1995: LUCENE-9575 Add PatternTypingFilter to annotate tokens with flags and types

2020-10-16 Thread GitBox
danmuzi commented on a change in pull request #1995: URL: https://github.com/apache/lucene-solr/pull/1995#discussion_r506695505 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/pattern/PatternTypingFilterFactory.java ## @@ -0,0 +1,120 @@ +/* + * License

[GitHub] [lucene-solr] msokolov commented on a change in pull request #1930: LUCENE-9322: add VectorValues to new Lucene90 codec

2020-10-16 Thread GitBox
msokolov commented on a change in pull request #1930: URL: https://github.com/apache/lucene-solr/pull/1930#discussion_r506729885 ## File path: lucene/core/src/test/org/apache/lucene/index/TestVectorValues.java ## @@ -0,0 +1,650 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [lucene-solr] msokolov commented on a change in pull request #1930: LUCENE-9322: add VectorValues to new Lucene90 codec

2020-10-16 Thread GitBox
msokolov commented on a change in pull request #1930: URL: https://github.com/apache/lucene-solr/pull/1930#discussion_r506736220 ## File path: lucene/core/src/java/org/apache/lucene/index/VectorValues.java ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [lucene-solr] anverus commented on a change in pull request #1997: SOLR-14940: Add ability to remove SolrCore.closeHooks. Keep reference…

2020-10-16 Thread GitBox
anverus commented on a change in pull request #1997: URL: https://github.com/apache/lucene-solr/pull/1997#discussion_r506736783 ## File path: solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java ## @@ -1372,55 +1372,55 @@ private boolean isEnabled( @SuppressWarni

[GitHub] [lucene-solr] anverus commented on a change in pull request #1997: SOLR-14940: Add ability to remove SolrCore.closeHooks. Keep reference…

2020-10-16 Thread GitBox
anverus commented on a change in pull request #1997: URL: https://github.com/apache/lucene-solr/pull/1997#discussion_r506736783 ## File path: solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java ## @@ -1372,55 +1372,55 @@ private boolean isEnabled( @SuppressWarni

[GitHub] [lucene-solr] zacharymorn opened a new pull request #1998: LUCENE-9455: ExitableTermsEnum should sample timeout and interruption check before calling next()

2020-10-16 Thread GitBox
zacharymorn opened a new pull request #1998: URL: https://github.com/apache/lucene-solr/pull/1998 # Description ExitableTermsEnum should sample timeout and interruption check before calling next() # Solution Add the same sampling logic as in https://github.com/elastic/

[jira] [Commented] (LUCENE-9455) ExitableTermsEnum (in ExitableDirectoryReader) should sample next()

2020-10-16 Thread Zach Chen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215715#comment-17215715 ] Zach Chen commented on LUCENE-9455: --- Thanks [~broustant]! I've created a PR for this c

[GitHub] [lucene-site] dsmiley merged pull request #30: GitHub: only want the squash button; not merge

2020-10-16 Thread GitBox
dsmiley merged pull request #30: URL: https://github.com/apache/lucene-site/pull/30 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (SOLR-14914) Add option to disable metrics collection

2020-10-16 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215746#comment-17215746 ] Noble Paul commented on SOLR-14914: --- [~dsmiley] I've started a discussion in the mailin

[jira] [Comment Edited] (SOLR-14914) Add option to disable metrics collection

2020-10-16 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214705#comment-17214705 ] Noble Paul edited comment on SOLR-14914 at 10/17/20, 4:50 AM: -

[jira] [Comment Edited] (SOLR-14907) Support single file upload/overwrite in configSet API

2020-10-16 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215064#comment-17215064 ] Noble Paul edited comment on SOLR-14907 at 10/17/20, 5:36 AM: -