[
https://issues.apache.org/jira/browse/SOLR-14914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215227#comment-17215227
]
Andrzej Bialecki commented on SOLR-14914:
-----------------------------------------
bq. So, you mean nobody will know what you're gonna build & commit until it's
added and committed to the ref guide?
What kind of question is that??? You seem to accuse me of sneaking in some
black-box change that nobody knows what it's doing. If that's the case then
this is simply not true - look at the facts and at the timeline.
The issue description clearly stated right from the start what is the goal of
this change and how I was going to implement it.
Then YOU YOURSELF helped me create the PR, when I couldn't do it due to some
strange Github error. The PR has the code that anyone could review and comment
on. And finally, before I merged it, I included the RefGuide documentation in
the PR that clearly shows how to use this feature. What else did you expect?
Did you actually read the docs? If it's still unclear to you how this feature
should be used or what is it's impact then I'm open to suggestions how to make
it more understandable.
> Add option to disable metrics collection
> ----------------------------------------
>
> Key: SOLR-14914
> URL: https://issues.apache.org/jira/browse/SOLR-14914
> Project: Solr
> Issue Type: Improvement
> Components: metrics
> Reporter: Andrzej Bialecki
> Assignee: Andrzej Bialecki
> Priority: Major
> Fix For: 8.7
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Some users have expressed concerns about the overhead of metrics collection,
> and consequently the need to have an option to turn off the metrics
> collection altogether.
> Metrics instrumentation in Solr cannot be itself easily removed or bypassed -
> in order to provide fine-grained metrics many code paths had to be changed
> and they now expect the metrics to be present (non-null). However, we can use
> the mechanism of {{MetricSupplier}} to provide singleton no-op
> implementations of all metrics, which would reduce the CPU overhead to
> basically the cost of an empty method call, and the memory overhead to a
> HashMap entry in a {{MetricRegistry}} (metric names still need to be tracked).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
