[
https://issues.apache.org/jira/browse/SOLR-14914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215257#comment-17215257
]
Noble Paul commented on SOLR-14914:
-----------------------------------
{quote}What kind of question is that??? You seem to accuse me of sneaking in
some black-box change that nobody knows what it's doing. If that's the case
then this is simply not true - look at the facts and at the timeline.{quote}
Not at all. I have nothing against the feature.
I'm suggesting that you are being economic with documentation.
If you are making a user facing feature it helps other committers to know how
the feature is going to be used by an end user.
Solr is notoriously hard to use. We should let others review anything that will
directly affect users. Clearly stating the changes help other committers give
early feedback.
{quote}Did you actually read the docs? {quote}
I did. But that is a part of the commit itself. When we plan to make a change
let's make our intent clear.
> Add option to disable metrics collection
> ----------------------------------------
>
> Key: SOLR-14914
> URL: https://issues.apache.org/jira/browse/SOLR-14914
> Project: Solr
> Issue Type: Improvement
> Components: metrics
> Reporter: Andrzej Bialecki
> Assignee: Andrzej Bialecki
> Priority: Major
> Fix For: 8.7
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Some users have expressed concerns about the overhead of metrics collection,
> and consequently the need to have an option to turn off the metrics
> collection altogether.
> Metrics instrumentation in Solr cannot be itself easily removed or bypassed -
> in order to provide fine-grained metrics many code paths had to be changed
> and they now expect the metrics to be present (non-null). However, we can use
> the mechanism of {{MetricSupplier}} to provide singleton no-op
> implementations of all metrics, which would reduce the CPU overhead to
> basically the cost of an empty method call, and the memory overhead to a
> HashMap entry in a {{MetricRegistry}} (metric names still need to be tracked).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
