[GitHub] [lucene-solr] mocobeta commented on pull request #1836: LUCENE-9317: Clean up split package in analyzers-common

2020-09-27 Thread GitBox
mocobeta commented on pull request #1836: URL: https://github.com/apache/lucene-solr/pull/1836#issuecomment-699613186 > I have not yet checked if the regeneration of jflex files for the classic tokenizer work with gradle, but it's more important to move the stuff. Fixing up the build can b

[GitHub] [lucene-solr] mocobeta edited a comment on pull request #1836: LUCENE-9317: Clean up split package in analyzers-common

2020-09-27 Thread GitBox
mocobeta edited a comment on pull request #1836: URL: https://github.com/apache/lucene-solr/pull/1836#issuecomment-699613186 > I have not yet checked if the regeneration of jflex files for the classic tokenizer work with gradle, but it's more important to move the stuff. Fixing up the buil

[GitHub] [lucene-solr] mocobeta commented on pull request #1836: LUCENE-9317: Clean up split package in analyzers-common

2020-09-27 Thread GitBox
mocobeta commented on pull request #1836: URL: https://github.com/apache/lucene-solr/pull/1836#issuecomment-699615254 @uschindler I hope this will catch your attention and the timing is good for you. :) I don't have enough time and energy neither to keep it up-to-date with the maste

[GitHub] [lucene-solr] uschindler commented on pull request #1836: LUCENE-9317: Clean up split package in analyzers-common

2020-09-27 Thread GitBox
uschindler commented on pull request #1836: URL: https://github.com/apache/lucene-solr/pull/1836#issuecomment-699615708 Hi, I am in hospital for an urgency with appendix. I can review stuff, but I only have my Chromebook available, so limited programming capacity. Hope to get

[GitHub] [lucene-solr] mocobeta commented on pull request #1836: LUCENE-9317: Clean up split package in analyzers-common

2020-09-27 Thread GitBox
mocobeta commented on pull request #1836: URL: https://github.com/apache/lucene-solr/pull/1836#issuecomment-699617023 > I am in hospital for an urgency with appendix. I can review stuff, but I only have my Chromebook available, so limited programming capacity. What happened, please t

[jira] [Resolved] (SOLR-10355) ref-guide "ant build-pdf" fails with jdk9 due to jigsaw blocking jruby

2020-09-27 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Rafalovitch resolved SOLR-10355. -- Resolution: Not A Problem ANT is gone. PDF is gone. Issues seems to be no longe

[jira] [Resolved] (SOLR-13424) Ref Guide PDF build throws Java warnings after requiring Java 11 on master

2020-09-27 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Rafalovitch resolved SOLR-13424. -- Resolution: Won't Fix PDF is no longer being built > Ref Guide PDF build throw

[jira] [Created] (SOLR-14900) Update ReGuide build's asciidoctor and ruby/jruby modules to the latest version

2020-09-27 Thread Alexandre Rafalovitch (Jira)
Alexandre Rafalovitch created SOLR-14900: Summary: Update ReGuide build's asciidoctor and ruby/jruby modules to the latest version Key: SOLR-14900 URL: https://issues.apache.org/jira/browse/SOLR-14900

[GitHub] [lucene-solr] dweiss commented on pull request #1836: LUCENE-9317: Clean up split package in analyzers-common

2020-09-27 Thread GitBox
dweiss commented on pull request #1836: URL: https://github.com/apache/lucene-solr/pull/1836#issuecomment-699640851 Ugh. Take care of yourself (and your appendix), Uwe. I'll review this later today. This is an automated mess

[GitHub] [lucene-solr] uschindler commented on pull request #1836: LUCENE-9317: Clean up split package in analyzers-common

2020-09-27 Thread GitBox
uschindler commented on pull request #1836: URL: https://github.com/apache/lucene-solr/pull/1836#issuecomment-699644807 Thanks Dawid, The appendix (not my wife, the part of intestine) is gone already. Unfortunately it broke before it was extracted so I have to stay a bit longer.

[GitHub] [lucene-solr] arafalov opened a new pull request #1923: SOLR-14900: Reference Guide build cleanup/module upgrade

2020-09-27 Thread GitBox
arafalov opened a new pull request #1923: URL: https://github.com/apache/lucene-solr/pull/1923 # Description buildSite task was generating some scary warnings on first build as it was getting various gems as well as a warning on each build. It was version locked before due to ant and PD

[GitHub] [lucene-solr] dweiss commented on pull request #1836: LUCENE-9317: Clean up split package in analyzers-common

2020-09-27 Thread GitBox
dweiss commented on pull request #1836: URL: https://github.com/apache/lucene-solr/pull/1836#issuecomment-699656374 Hope you'll recover soon, Uwe! This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1923: SOLR-14900: Reference Guide build cleanup/module upgrade

2020-09-27 Thread GitBox
dweiss commented on a change in pull request #1923: URL: https://github.com/apache/lucene-solr/pull/1923#discussion_r495589940 ## File path: solr/solr-ref-guide/src/_config.yml.template ## @@ -7,7 +7,7 @@ # # Gems that are included for building the site. jekyll-asciidoc all

[GitHub] [lucene-solr] dweiss commented on pull request #1836: LUCENE-9317: Clean up split package in analyzers-common

2020-09-27 Thread GitBox
dweiss commented on pull request #1836: URL: https://github.com/apache/lucene-solr/pull/1836#issuecomment-69965 That test has hardcoded classes (schema-plugins.jar.bin) referencing things before the refactoring - hence the ClassNotFoundException. I think it's a poor test considering fu

[jira] [Created] (LUCENE-9543) Symlinked repository locations fail on tests with security manager

2020-09-27 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-9543: --- Summary: Symlinked repository locations fail on tests with security manager Key: LUCENE-9543 URL: https://issues.apache.org/jira/browse/LUCENE-9543 Project: Lucene - Co

[GitHub] [lucene-solr] arafalov commented on pull request #1923: SOLR-14900: Reference Guide build cleanup/module upgrade

2020-09-27 Thread GitBox
arafalov commented on pull request #1923: URL: https://github.com/apache/lucene-solr/pull/1923#issuecomment-699660285 @dweiss Can we add all my changes to that PR/JIRA (which one?) and then we can obsolete this one. Or I can wait for it to be done and do the difference. Whatever works. -

[GitHub] [lucene-solr] dweiss commented on pull request #1923: SOLR-14900: Reference Guide build cleanup/module upgrade

2020-09-27 Thread GitBox
dweiss commented on pull request #1923: URL: https://github.com/apache/lucene-solr/pull/1923#issuecomment-699660725 It's SOLR-14889. I think it may automatically merge (because those lines are identical) but it's hard to tell in advance. Just wanted you to know Chris is working on some cle

[GitHub] [lucene-solr] arafalov commented on pull request #1923: SOLR-14900: Reference Guide build cleanup/module upgrade

2020-09-27 Thread GitBox
arafalov commented on pull request #1923: URL: https://github.com/apache/lucene-solr/pull/1923#issuecomment-699662967 Ok, I see it. Looks like Chris's work should go in first. I will sit on mine for a week and then adjust to whatever still needs to be done. There is no urgency, it was just

[jira] [Created] (LUCENE-9544) Port Nori dictionary compilation

2020-09-27 Thread Namgyu Kim (Jira)
Namgyu Kim created LUCENE-9544: -- Summary: Port Nori dictionary compilation Key: LUCENE-9544 URL: https://issues.apache.org/jira/browse/LUCENE-9544 Project: Lucene - Core Issue Type: Task

[GitHub] [lucene-solr] danmuzi opened a new pull request #1924: LUCENE-9544: Port Nori dictionary compilation

2020-09-27 Thread GitBox
danmuzi opened a new pull request #1924: URL: https://github.com/apache/lucene-solr/pull/1924 There is no script for Nori dictionary after the Ant build was deleted in [LUCENE-9433](https://issues.apache.org/jira/browse/LUCENE-9433). ---

[jira] [Updated] (LUCENE-9544) Port Nori dictionary compilation

2020-09-27 Thread Namgyu Kim (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Namgyu Kim updated LUCENE-9544: --- Description: There is no script for Nori dictionary after the Ant build was deleted in LUCENE-9433.

[GitHub] [lucene-solr] mikemccand commented on pull request #1893: LUCENE-9444 Utility class to get facet labels from taxonomy for a fac…

2020-09-27 Thread GitBox
mikemccand commented on pull request #1893: URL: https://github.com/apache/lucene-solr/pull/1893#issuecomment-699702003 Thanks @goankur I think this is ready! I'll confirm all tests pass and squash/merge soon. This is an au

[jira] [Commented] (LUCENE-9535) Investigate recent indexing slowdown for wikimedium documents

2020-09-27 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202935#comment-17202935 ] Michael McCandless commented on LUCENE-9535: Thanks for digging and fixing [

[jira] [Commented] (SOLR-14701) Deprecate Schemaless Mode (Discussion)

2020-09-27 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202942#comment-17202942 ] Noble Paul commented on SOLR-14701: --- [~hossman] I like  SOLR-11741   . I have a prob

[jira] [Commented] (SOLR-14701) Deprecate Schemaless Mode (Discussion)

2020-09-27 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202961#comment-17202961 ] Alexandre Rafalovitch commented on SOLR-14701: -- I don't see why we need anot

[jira] [Updated] (SOLR-14701) Deprecate Schemaless Mode (Discussion)

2020-09-27 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Rafalovitch updated SOLR-14701: - Priority: Blocker (was: Major) > Deprecate Schemaless Mode (Discussion) > --

[jira] [Assigned] (SOLR-14701) Deprecate Schemaless Mode (Discussion)

2020-09-27 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Rafalovitch reassigned SOLR-14701: Assignee: (was: Alexandre Rafalovitch) > Deprecate Schemaless Mode (Di

[jira] [Updated] (SOLR-14701) Deprecate Schemaless Mode (Discussion)

2020-09-27 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Rafalovitch updated SOLR-14701: - Fix Version/s: master (9.0) > Deprecate Schemaless Mode (Discussion) > --

[jira] [Created] (SOLR-14901) Analysis factory FQDNs are hard coded in TestPackages

2020-09-27 Thread Tomoko Uchida (Jira)
Tomoko Uchida created SOLR-14901: Summary: Analysis factory FQDNs are hard coded in TestPackages Key: SOLR-14901 URL: https://issues.apache.org/jira/browse/SOLR-14901 Project: Solr Issue Type

[jira] [Updated] (SOLR-14901) Analysis factory FQDNs are hard coded in TestPackages

2020-09-27 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated SOLR-14901: - Affects Version/s: master (9.0) > Analysis factory FQDNs are hard coded in TestPackages > ---

[jira] [Updated] (SOLR-14901) Analysis factory FQDNs are hard coded in TestPackages

2020-09-27 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated SOLR-14901: - Issue Type: Bug (was: Task) > Analysis factory FQDNs are hard coded in TestPackages > --

[jira] [Updated] (SOLR-14901) Analysis factory FQDNs are hard coded in TestPackages

2020-09-27 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated SOLR-14901: - Description: Base analysis factories' package name were renamed in [LUCENE-9317]. {{o.a.s.pkg.Te

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #1836: LUCENE-9317: Clean up split package in analyzers-common

2020-09-27 Thread GitBox
mocobeta commented on a change in pull request #1836: URL: https://github.com/apache/lucene-solr/pull/1836#discussion_r495706327 ## File path: lucene/test-framework/src/java/org/apache/lucene/analysis/BaseTokenStreamFactoryTestCase.java ## @@ -39,10 +39,6 @@ * assertTokenS

[GitHub] [lucene-solr] mocobeta commented on pull request #1836: LUCENE-9317: Clean up split package in analyzers-common

2020-09-27 Thread GitBox
mocobeta commented on pull request #1836: URL: https://github.com/apache/lucene-solr/pull/1836#issuecomment-699798786 Thanks @dweiss for review. > I'd add an entry to CHANGES.txt too (both for Solr and Lucene maybe). I added a changes entry for Lucene https://github.com/apach

[jira] [Assigned] (SOLR-14901) TestPackages uses binary precompiled classes to refer to analysis factory FQDNs

2020-09-27 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss reassigned SOLR-14901: -- Assignee: Dawid Weiss > TestPackages uses binary precompiled classes to refer to analysis fact

[jira] [Updated] (SOLR-14901) TestPackages uses binary precompiled classes to refer to analysis factory FQDNs

2020-09-27 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated SOLR-14901: --- Summary: TestPackages uses binary precompiled classes to refer to analysis factory FQDNs (was: Analy

[GitHub] [lucene-solr] dweiss commented on pull request #1836: LUCENE-9317: Clean up split package in analyzers-common

2020-09-27 Thread GitBox
dweiss commented on pull request #1836: URL: https://github.com/apache/lucene-solr/pull/1836#issuecomment-699812085 I think this is fine, Tomoko. I'll take care of the Solr test issue in a spare moment. This is an automated

[jira] [Updated] (SOLR-14901) TestPackages uses binary precompiled classes to refer to analysis factory FQDNs

2020-09-27 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated SOLR-14901: --- Priority: Minor (was: Major) > TestPackages uses binary precompiled classes to refer to analysis fac

[GitHub] [lucene-solr] dweiss merged pull request #1924: LUCENE-9544: Port Nori dictionary compilation

2020-09-27 Thread GitBox
dweiss merged pull request #1924: URL: https://github.com/apache/lucene-solr/pull/1924 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (LUCENE-9544) Port Nori dictionary compilation

2020-09-27 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9544. - Resolution: Fixed > Port Nori dictionary compilation > > >

[jira] [Commented] (LUCENE-9544) Port Nori dictionary compilation

2020-09-27 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203037#comment-17203037 ] Dawid Weiss commented on LUCENE-9544: - Hmm... I merged it in, [~danmuzi] - hope it's