arafalov opened a new pull request #1923:
URL: https://github.com/apache/lucene-solr/pull/1923


   # Description
   buildSite task was generating some scary warnings on first build as it was 
getting various gems as well as a warning on each build. It was version locked 
before due to ant and PDF, but that's no longer part of Solr 9.
   
   # Solution
   Upgraded all explicit versions to the latest available.
   Everything seems to build the same, the only changes were for the source 
block styles. We were supposed to be using thankful-eyes theme but the correct 
name of that theme is actually thankful_eyes and it is a dark theme, so we were 
falling back to 'github' theme. Made that more clear and explicit.
   Switched to using stylesheets as well instead of embedded styles, as upgrade 
module was generating more markup for better dark-themes support (I guess).
   
   There is still an old warning during build about _Illegal reflective access_ 
and a new one about _Improper use of Lexer#lex_ . It may be worth repeating the 
upgrade process in another couple of months to see if that had been fixed in 
relevant libraries.
   
   # Tests
   There were no code changes, but I visually and 'diff' checked the old and 
new html output.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [X I have reviewed the guidelines for [How to 
Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms 
to the standards described there to the best of my ability.
   - [X] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [X] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended)
   - [X] I have developed this patch against the `master` branch.
   - [X] I have run `./gradlew check`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to