mocobeta commented on pull request #1836: URL: https://github.com/apache/lucene-solr/pull/1836#issuecomment-699798786
Thanks @dweiss for review. > I'd add an entry to CHANGES.txt too (both for Solr and Lucene maybe). I added a changes entry for Lucene https://github.com/apache/lucene-solr/pull/1836/commits/a31632d17703803b23883323ea974d24842759e5. (There is no Solr issue, though its internal was refactored.) > I would file an issue and add an AwaitsFix to it so that it can be corrected as a separate issue. Those binary classes are not very convenient anyway so perhaps there is a different way of implementing that test (like compiling that ZIP on the fly from classes available in test classpath). I opened https://issues.apache.org/jira/browse/SOLR-14901 and referred it from `@AwaitsFix` https://github.com/apache/lucene-solr/pull/1836/commits/2fdeb7ff5cded3fe9f9a7aaaa36bfd42e997fd17, then this branch now passes `./gradlew -p solr/ tests`. I'm not sure the title or description of SOLR-14901 is appropriate. Can you please fix it if needed? I'll merge it to master after running whole tests again. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
