[GitHub] [lucene-solr] janhoy commented on a change in pull request #1572: SOLR-14561 CoreAdminAPI's parameters instanceDir and dataDir are now validated

2020-06-15 Thread GitBox
janhoy commented on a change in pull request #1572: URL: https://github.com/apache/lucene-solr/pull/1572#discussion_r440028825 ## File path: solr/core/src/java/org/apache/solr/core/SolrPaths.java ## @@ -128,4 +130,33 @@ private static void logOnceInfo(String key, String msg) {

[GitHub] [lucene-solr] janhoy commented on pull request #1572: SOLR-14561 CoreAdminAPI's parameters instanceDir and dataDir are now validated

2020-06-15 Thread GitBox
janhoy commented on pull request #1572: URL: https://github.com/apache/lucene-solr/pull/1572#issuecomment-644006967 Ran the whole test suite and uncovered various tests that use "illegal" temp test folders, that now fail. That was expected. So the last commit ba0b544 addresses these tests:

[GitHub] [lucene-solr] janhoy edited a comment on pull request #1572: SOLR-14561 CoreAdminAPI's parameters instanceDir and dataDir are now validated

2020-06-15 Thread GitBox
janhoy edited a comment on pull request #1572: URL: https://github.com/apache/lucene-solr/pull/1572#issuecomment-644006967 Ran the whole test suite and uncovered various tests that use "illegal" temp test folders, that now fail. That was expected. So the last commit ba0b544 addresses these

[jira] [Commented] (SOLR-14516) NPE during Realtime GET

2020-06-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135654#comment-17135654 ] ASF subversion and git services commented on SOLR-14516: Commit f

[GitHub] [lucene-solr] mayya-sharipova commented on pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-06-15 Thread GitBox
mayya-sharipova commented on pull request #1351: URL: https://github.com/apache/lucene-solr/pull/1351#issuecomment-644051324 @jpountz I am wondering if you have any further feedback for this PR? This is an automated message f

[jira] [Created] (SOLR-14570) Round Off in MM Edismax

2020-06-15 Thread Lucky Sharma (Jira)
Lucky Sharma created SOLR-14570: --- Summary: Round Off in MM Edismax Key: SOLR-14570 URL: https://issues.apache.org/jira/browse/SOLR-14570 Project: Solr Issue Type: Improvement Security Le

[GitHub] [lucene-solr] MighTguY opened a new pull request #1578: SOLR-14570: Edismax round plugin

2020-06-15 Thread GitBox
MighTguY opened a new pull request #1578: URL: https://github.com/apache/lucene-solr/pull/1578 # Description To make the rounding of the Match mode in Edismax, i.e if the mm.roundOff is true, it will round off the Edismax Match mode queries # Solution In thi

[jira] [Commented] (SOLR-14516) NPE during Realtime GET

2020-06-15 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135794#comment-17135794 ] Ishan Chattopadhyaya commented on SOLR-14516: - This is just silently suppress

[jira] [Commented] (SOLR-14516) NPE during Realtime GET

2020-06-15 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135797#comment-17135797 ] Ishan Chattopadhyaya commented on SOLR-14516: - Here is the way to reproduce i

[jira] [Commented] (SOLR-14516) NPE during Realtime GET

2020-06-15 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135801#comment-17135801 ] Ishan Chattopadhyaya commented on SOLR-14516: - The underlying reason for this

[jira] [Commented] (SOLR-14516) NPE during Realtime GET

2020-06-15 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135807#comment-17135807 ] Erick Erickson commented on SOLR-14516: --- See the e-mail I just sent about using you

[jira] [Commented] (SOLR-13971) Velocity custom template RCE vulnerability

2020-06-15 Thread Szilard Antal (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135847#comment-17135847 ] Szilard Antal commented on SOLR-13971: -- [~ichattopadhyaya]  are you planning to back

[jira] [Comment Edited] (SOLR-13971) Velocity custom template RCE vulnerability

2020-06-15 Thread Szilard Antal (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135847#comment-17135847 ] Szilard Antal edited comment on SOLR-13971 at 6/15/20, 1:24 PM: ---

[jira] [Commented] (SOLR-13971) Velocity custom template RCE vulnerability

2020-06-15 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135851#comment-17135851 ] Ishan Chattopadhyaya commented on SOLR-13971: - [~sziszo], unfortunately not.

[GitHub] [lucene-solr] mikemccand commented on pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-06-15 Thread GitBox
mikemccand commented on pull request #1351: URL: https://github.com/apache/lucene-solr/pull/1351#issuecomment-644139389 Do we expect the nightly benchmarks (`luceneutil`) to move from this? Does it speed up any non-relevance (e.g. field'd) sort by default? ---

[jira] [Commented] (SOLR-13971) Velocity custom template RCE vulnerability

2020-06-15 Thread Szilard Antal (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135869#comment-17135869 ] Szilard Antal commented on SOLR-13971: -- [~ichattopadhyaya] thanks for the quick info

[jira] [Commented] (LUCENE-9395) ConstantValuesSource creates more than one DoubleValues unnecessarily

2020-06-15 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135876#comment-17135876 ] Michael McCandless commented on LUCENE-9395: {quote}Hello! {{org.apache.luce

[GitHub] [lucene-solr] murblanc commented on pull request #1504: SOLR-14462: cache more than one autoscaling session

2020-06-15 Thread GitBox
murblanc commented on pull request #1504: URL: https://github.com/apache/lucene-solr/pull/1504#issuecomment-644156063 @noblepaul this PR seems to have fallen through the cracks... I'm looking at other aspects of Autoscaling issues and this being merged would make my life easier.

[jira] [Commented] (SOLR-14569) HTTP 401 when searching on alias in secured Solr

2020-06-15 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135915#comment-17135915 ] Jason Gerlowski commented on SOLR-14569: Hi Isabelle, thanks for reporting, sorry

[GitHub] [lucene-solr] ErickErickson opened a new pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-15 Thread GitBox
ErickErickson opened a new pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579 I've created new hashCode methods for all of the classes that implement equals but not hashCode and removed associated SuppressWarnings. I've marked certain of them with TODOs where I'm real

[jira] [Commented] (SOLR-14541) Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-15 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135920#comment-17135920 ] Erick Erickson commented on SOLR-14541: --- The linked PR implements straw-man hashCod

[jira] [Commented] (SOLR-14524) Harden MultiThreadedOCPTest

2020-06-15 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135943#comment-17135943 ] Ilan Ginzburg commented on SOLR-14524: -- I believe this test is good as is, so would

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1567: LUCENE-9402: Let MultiCollector handle minCompetitiveScore

2020-06-15 Thread GitBox
jpountz commented on a change in pull request #1567: URL: https://github.com/apache/lucene-solr/pull/1567#discussion_r440242303 ## File path: lucene/core/src/java/org/apache/lucene/search/MultiCollector.java ## @@ -134,69 +134,110 @@ public LeafCollector getLeafCollector(LeafRe

[jira] [Commented] (SOLR-14566) Record "NOW" on "coordinator" log messages

2020-06-15 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135960#comment-17135960 ] Jason Gerlowski commented on SOLR-14566: Interesting, I guess you could build som

[jira] [Comment Edited] (SOLR-14569) HTTP 401 when searching on alias in secured Solr

2020-06-15 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135915#comment-17135915 ] Jason Gerlowski edited comment on SOLR-14569 at 6/15/20, 3:45 PM: -

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-15 Thread GitBox
murblanc commented on a change in pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r440281749 ## File path: solr/core/src/java/org/apache/solr/cloud/rule/Rule.java ## @@ -365,7 +365,7 @@ public boolean equals(Object obj) { @Override

[jira] [Created] (SOLR-14571) Index download speed while replicating is fixed at 5.1 in replication.html

2020-06-15 Thread Florin Babes (Jira)
Florin Babes created SOLR-14571: --- Summary: Index download speed while replicating is fixed at 5.1 in replication.html Key: SOLR-14571 URL: https://issues.apache.org/jira/browse/SOLR-14571 Project: Solr

[jira] [Commented] (SOLR-14569) HTTP 401 when searching on alias in secured Solr

2020-06-15 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135974#comment-17135974 ] Jason Gerlowski commented on SOLR-14569: A quick attempt at reproducing didn't wo

[jira] [Commented] (SOLR-14566) Record "NOW" on "coordinator" log messages

2020-06-15 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135976#comment-17135976 ] Robert Muir commented on SOLR-14566: IMO, there are two separate concerns: 1) propaga

[GitHub] [lucene-solr] mikemccand commented on pull request #1552: LUCENE-8962: merge small segments on commit

2020-06-15 Thread GitBox
mikemccand commented on pull request #1552: URL: https://github.com/apache/lucene-solr/pull/1552#issuecomment-644226072 Just for my sanity to keep track of all the exciting PRs here :) Here is the original PR (that was pushed, then reverted, then led to this PR): https://github.com/apache

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-15 Thread GitBox
murblanc commented on a change in pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r440284972 ## File path: solr/core/src/java/org/apache/solr/pkg/PackageAPI.java ## @@ -211,7 +211,7 @@ public boolean equals(Object obj) { @Override

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-15 Thread GitBox
murblanc commented on a change in pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r440287813 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/AutoScalingConfig.java ## @@ -305,10 +303,10 @@ public boolean equa

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-15 Thread GitBox
murblanc commented on a change in pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r440289119 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/AutoScalingConfig.java ## @@ -587,11 +585,11 @@ public boolean equa

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-15 Thread GitBox
murblanc commented on a change in pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r440291350 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/Policy.java ## @@ -288,10 +287,11 @@ public boolean equals(Object o

[jira] [Updated] (SOLR-14571) Index download speed while replicating is fixed at 5.1 in replication.html

2020-06-15 Thread Florin Babes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Florin Babes updated SOLR-14571: Status: Patch Available (was: Open) > Index download speed while replicating is fixed at 5.1 in re

[jira] [Updated] (SOLR-14571) Index download speed while replicating is fixed at 5.1 in replication.html

2020-06-15 Thread Florin Babes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Florin Babes updated SOLR-14571: Attachment: SOLR-14571.patch > Index download speed while replicating is fixed at 5.1 in replicatio

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-15 Thread GitBox
murblanc commented on a change in pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r440301532 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java ## @@ -383,10 +382,12 @@ public boolean equals(Object that) {

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-15 Thread GitBox
murblanc commented on a change in pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r440302683 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java ## @@ -153,10 +152,12 @@ public boolean equals(Object o) { return

[jira] [Commented] (SOLR-13132) Improve JSON "terms" facet performance when sorted by relatedness

2020-06-15 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136007#comment-17136007 ] Michael Gibney commented on SOLR-13132: --- I just pushed some commits that should add

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-15 Thread GitBox
murblanc commented on a change in pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r440304468 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/ZkNodeProps.java ## @@ -171,8 +167,10 @@ public boolean getBool(String key, boolean b)

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1552: LUCENE-8962: merge small segments on commit

2020-06-15 Thread GitBox
mikemccand commented on a change in pull request #1552: URL: https://github.com/apache/lucene-solr/pull/1552#discussion_r440298695 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -4483,6 +4593,7 @@ public int length() { // Merge would

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-15 Thread GitBox
murblanc commented on a change in pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r440306014 ## File path: solr/solrj/src/java/org/apache/solr/common/util/ValidatingJsonMap.java ## @@ -348,10 +348,12 @@ public boolean equals(Object that) {

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-15 Thread GitBox
murblanc commented on a change in pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r440301532 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java ## @@ -383,10 +382,12 @@ public boolean equals(Object that) {

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1576: Alternative approach to LUCENE-8962

2020-06-15 Thread GitBox
dsmiley commented on a change in pull request #1576: URL: https://github.com/apache/lucene-solr/pull/1576#discussion_r440309711 ## File path: lucene/core/src/java/org/apache/lucene/index/MergePolicy.java ## @@ -399,8 +423,19 @@ public String segString(Directory dir) { }

[jira] [Updated] (SOLR-14570) Round Off in MM Edismax

2020-06-15 Thread Lucky Sharma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucky Sharma updated SOLR-14570: Priority: Minor (was: Major) > Round Off in MM Edismax > > >

[jira] [Created] (LUCENE-9405) IndexWriter incorrectly calls closeMergeReaders twice when the merged segment is 100% deleted

2020-06-15 Thread Michael McCandless (Jira)
Michael McCandless created LUCENE-9405: -- Summary: IndexWriter incorrectly calls closeMergeReaders twice when the merged segment is 100% deleted Key: LUCENE-9405 URL: https://issues.apache.org/jira/browse/LUCE

[jira] [Updated] (SOLR-14569) HTTP 401 when searching on alias in secured Solr

2020-06-15 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Isabelle Giguere updated SOLR-14569: Attachment: security.json > HTTP 401 when searching on alias in secured Solr >

[jira] [Commented] (SOLR-14569) HTTP 401 when searching on alias in secured Solr

2020-06-15 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136056#comment-17136056 ] Isabelle Giguere commented on SOLR-14569: - Hi [~gerlowskija] Good catches.  Sorr

[jira] [Comment Edited] (SOLR-14569) HTTP 401 when searching on alias in secured Solr

2020-06-15 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136056#comment-17136056 ] Isabelle Giguere edited comment on SOLR-14569 at 6/15/20, 5:42 PM:

[jira] [Comment Edited] (SOLR-14569) HTTP 401 when searching on alias in secured Solr

2020-06-15 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136056#comment-17136056 ] Isabelle Giguere edited comment on SOLR-14569 at 6/15/20, 5:43 PM:

[jira] [Comment Edited] (SOLR-14569) HTTP 401 when searching on alias in secured Solr

2020-06-15 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136056#comment-17136056 ] Isabelle Giguere edited comment on SOLR-14569 at 6/15/20, 5:45 PM:

[jira] [Updated] (SOLR-11973) Fail compilation on precommit warnings

2020-06-15 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated SOLR-11973: -- Summary: Fail compilation on precommit warnings (was: Selectively fail on precommit WARN messa

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1576: Alternative approach to LUCENE-8962

2020-06-15 Thread GitBox
s1monw commented on a change in pull request #1576: URL: https://github.com/apache/lucene-solr/pull/1576#discussion_r440359230 ## File path: lucene/core/src/java/org/apache/lucene/index/MergePolicy.java ## @@ -399,8 +423,19 @@ public String segString(Directory dir) { }

[jira] [Updated] (SOLR-14569) HTTP 401 when searching on alias in secured Solr

2020-06-15 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Isabelle Giguere updated SOLR-14569: Description: The issue was first noticed on an instance of Solr 8.5.0, after securing Solr

[jira] [Updated] (SOLR-14569) HTTP 401 when searching on alias in secured Solr

2020-06-15 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Isabelle Giguere updated SOLR-14569: Attachment: SOLR-14569.patch > HTTP 401 when searching on alias in secured Solr > -

[jira] [Updated] (SOLR-14569) HTTP 401 when searching on alias in secured Solr

2020-06-15 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Isabelle Giguere updated SOLR-14569: Description: The issue was first noticed on an instance of Solr 8.5.0, after securing Solr

[jira] [Created] (LUCENE-9406) Make it simpler to track IndexWriter's events

2020-06-15 Thread Michael McCandless (Jira)
Michael McCandless created LUCENE-9406: -- Summary: Make it simpler to track IndexWriter's events Key: LUCENE-9406 URL: https://issues.apache.org/jira/browse/LUCENE-9406 Project: Lucene - Core

[GitHub] [lucene-solr] mikemccand commented on pull request #1552: LUCENE-8962: merge small segments on commit

2020-06-15 Thread GitBox
mikemccand commented on pull request #1552: URL: https://github.com/apache/lucene-solr/pull/1552#issuecomment-644317157 OK I opened [this issue](https://issues.apache.org/jira/browse/LUCENE-9406) to explore how to know what specifically `IndexWriter` is doing for merge-on-commit and other

[jira] [Assigned] (LUCENE-9405) IndexWriter incorrectly calls closeMergeReaders twice when the merged segment is 100% deleted

2020-06-15 Thread Simon Willnauer (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Willnauer reassigned LUCENE-9405: --- Assignee: Simon Willnauer I will try to look at this > IndexWriter incorrectly ca

[GitHub] [lucene-solr] s1monw opened a new pull request #1580: LUCENE-9405: Ensure IndexWriter only closes merge readers once.

2020-06-15 Thread GitBox
s1monw opened a new pull request #1580: URL: https://github.com/apache/lucene-solr/pull/1580 IndexWriter incorrectly calls closeMergeReaders twice when the merged segment is 100% deleted ie. would produce a fully deleted segment. --

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1580: LUCENE-9405: Ensure IndexWriter only closes merge readers once.

2020-06-15 Thread GitBox
mikemccand commented on a change in pull request #1580: URL: https://github.com/apache/lucene-solr/pull/1580#discussion_r440403479 ## File path: lucene/CHANGES.txt ## @@ -266,6 +266,9 @@ Bug Fixes * LUCENE-9362: Fix equality check in ExpressionValueSource#rewrite. This fixes

[GitHub] [lucene-solr] msokolov commented on a change in pull request #1580: LUCENE-9405: Ensure IndexWriter only closes merge readers once.

2020-06-15 Thread GitBox
msokolov commented on a change in pull request #1580: URL: https://github.com/apache/lucene-solr/pull/1580#discussion_r440405226 ## File path: lucene/CHANGES.txt ## @@ -266,6 +266,9 @@ Bug Fixes * LUCENE-9362: Fix equality check in ExpressionValueSource#rewrite. This fixes re

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1580: LUCENE-9405: Ensure IndexWriter only closes merge readers once.

2020-06-15 Thread GitBox
s1monw commented on a change in pull request #1580: URL: https://github.com/apache/lucene-solr/pull/1580#discussion_r440405474 ## File path: lucene/CHANGES.txt ## @@ -266,6 +266,9 @@ Bug Fixes * LUCENE-9362: Fix equality check in ExpressionValueSource#rewrite. This fixes rewr

[GitHub] [lucene-solr] msokolov commented on a change in pull request #1580: LUCENE-9405: Ensure IndexWriter only closes merge readers once.

2020-06-15 Thread GitBox
msokolov commented on a change in pull request #1580: URL: https://github.com/apache/lucene-solr/pull/1580#discussion_r440405613 ## File path: lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java ## @@ -4167,4 +4167,38 @@ public void testSegmentCommitInfoId() throw

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1580: LUCENE-9405: Ensure IndexWriter only closes merge readers once.

2020-06-15 Thread GitBox
s1monw commented on a change in pull request #1580: URL: https://github.com/apache/lucene-solr/pull/1580#discussion_r440405692 ## File path: lucene/CHANGES.txt ## @@ -266,6 +266,9 @@ Bug Fixes * LUCENE-9362: Fix equality check in ExpressionValueSource#rewrite. This fixes rewr

[jira] [Commented] (LUCENE-9405) IndexWriter incorrectly calls closeMergeReaders twice when the merged segment is 100% deleted

2020-06-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136130#comment-17136130 ] ASF subversion and git services commented on LUCENE-9405: - Commi

[GitHub] [lucene-solr] s1monw merged pull request #1580: LUCENE-9405: Ensure IndexWriter only closes merge readers once.

2020-06-15 Thread GitBox
s1monw merged pull request #1580: URL: https://github.com/apache/lucene-solr/pull/1580 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-9405) IndexWriter incorrectly calls closeMergeReaders twice when the merged segment is 100% deleted

2020-06-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136131#comment-17136131 ] ASF subversion and git services commented on LUCENE-9405: - Commi

[jira] [Resolved] (LUCENE-9405) IndexWriter incorrectly calls closeMergeReaders twice when the merged segment is 100% deleted

2020-06-15 Thread Simon Willnauer (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Willnauer resolved LUCENE-9405. - Fix Version/s: 8.6 master (9.0) Resolution: Fixed > IndexWrite

[jira] [Commented] (LUCENE-8574) ExpressionFunctionValues should cache per-hit value

2020-06-15 Thread Haoyu Zhai (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136136#comment-17136136 ] Haoyu Zhai commented on LUCENE-8574: I've checked the current release and couldn't s

[jira] [Created] (SOLR-14572) Ref Guide doesn't cover all SearchComponents on the Search Components page

2020-06-15 Thread David Eric Pugh (Jira)
David Eric Pugh created SOLR-14572: -- Summary: Ref Guide doesn't cover all SearchComponents on the Search Components page Key: SOLR-14572 URL: https://issues.apache.org/jira/browse/SOLR-14572 Project:

[GitHub] [lucene-solr] epugh opened a new pull request #1581: SOLR-14572 document missing SearchComponents

2020-06-15 Thread GitBox
epugh opened a new pull request #1581: URL: https://github.com/apache/lucene-solr/pull/1581 # Description Learned about a existing SearchComponent from 2012. Went to look at the related Ref Guide page and saw it was missing, plus two other components. # Solution Add a

[GitHub] [lucene-solr] mayya-sharipova commented on pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-06-15 Thread GitBox
mayya-sharipova commented on pull request #1351: URL: https://github.com/apache/lucene-solr/pull/1351#issuecomment-644394269 @mikemccand We should see speed-ups by default on sort for numeric fields, as long as these fields are indexed both with docValues and points, and a full total hits

[jira] [Updated] (SOLR-14569) HTTP 401 when searching on alias in secured Solr

2020-06-15 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Isabelle Giguere updated SOLR-14569: Attachment: solr.log > HTTP 401 when searching on alias in secured Solr > -

[jira] [Updated] (SOLR-14569) HTTP 401 when searching on alias in secured Solr

2020-06-15 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Isabelle Giguere updated SOLR-14569: Attachment: updated_solr_conf.zip > HTTP 401 when searching on alias in secured Solr >

[jira] [Updated] (SOLR-14569) HTTP 401 when searching on alias in secured Solr

2020-06-15 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Isabelle Giguere updated SOLR-14569: Attachment: curl_requests-responses.txt > HTTP 401 when searching on alias in secured Solr

[jira] [Commented] (SOLR-14569) HTTP 401 when searching on alias in secured Solr

2020-06-15 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136158#comment-17136158 ] Isabelle Giguere commented on SOLR-14569: - Attached: - updated_solr_conf.zip : "

[jira] [Comment Edited] (SOLR-14569) HTTP 401 when searching on alias in secured Solr

2020-06-15 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136158#comment-17136158 ] Isabelle Giguere edited comment on SOLR-14569 at 6/15/20, 9:40 PM:

[jira] [Commented] (SOLR-14571) Index download speed while replicating is fixed at 5.1 in replication.html

2020-06-15 Thread Lucene/Solr QA (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136170#comment-17136170 ] Lucene/Solr QA commented on SOLR-14571: --- | (x) *{color:red}-1 overall{color}* | \\

[GitHub] [lucene-solr] dsmiley opened a new pull request #1582: Remove some needless toAbsolutePath calls

2020-06-15 Thread GitBox
dsmiley opened a new pull request #1582: URL: https://github.com/apache/lucene-solr/pull/1582 Continuation of #1546 Here, we avoid calling toAbsolutePath when not needed because we know it's already absolute. Look carefully; there's a few other changes. I liken this to pointless

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1567: LUCENE-9402: Let MultiCollector handle minCompetitiveScore

2020-06-15 Thread GitBox
tflobbe commented on a change in pull request #1567: URL: https://github.com/apache/lucene-solr/pull/1567#discussion_r440492115 ## File path: lucene/core/src/java/org/apache/lucene/search/MultiCollector.java ## @@ -134,69 +134,110 @@ public LeafCollector getLeafCollector(LeafRe

[jira] [Updated] (LUCENE-8723) Bad interaction bewteen WordDelimiterGraphFilter, StopFilter and FlattenGraphFilter

2020-06-15 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-8723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolás Lichtmaier updated LUCENE-8723: --- Affects Version/s: 8.3 > Bad interaction bewteen WordDelimiterGraphFilter, StopFilte

[jira] [Commented] (SOLR-14566) Record "NOW" on "coordinator" log messages

2020-06-15 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136192#comment-17136192 ] Tomas Eduardo Fernandez Lobbe commented on SOLR-14566: -- Note that So

[jira] [Commented] (LUCENE-8723) Bad interaction bewteen WordDelimiterGraphFilter, StopFilter and FlattenGraphFilter

2020-06-15 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-8723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136193#comment-17136193 ] Nicolás Lichtmaier commented on LUCENE-8723: This is slightly different, but

[jira] [Commented] (SOLR-14569) HTTP 401 when searching on alias in secured Solr

2020-06-15 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136195#comment-17136195 ] Isabelle Giguere commented on SOLR-14569: - It took a lot of trial and error, but.

[jira] [Comment Edited] (SOLR-14569) HTTP 401 when searching on alias in secured Solr

2020-06-15 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136195#comment-17136195 ] Isabelle Giguere edited comment on SOLR-14569 at 6/15/20, 11:21 PM: ---

[jira] [Updated] (SOLR-14569) Configuring a shardHandlerFactory on the /select requestHandler results in HTTP 401 when searching on alias in secured Solr

2020-06-15 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Isabelle Giguere updated SOLR-14569: Summary: Configuring a shardHandlerFactory on the /select requestHandler results in HTTP 40

[jira] [Created] (SOLR-14573) Fix or suppress warnings in solrj/src/test

2020-06-15 Thread Erick Erickson (Jira)
Erick Erickson created SOLR-14573: - Summary: Fix or suppress warnings in solrj/src/test Key: SOLR-14573 URL: https://issues.apache.org/jira/browse/SOLR-14573 Project: Solr Issue Type: Sub-tas

[jira] [Created] (SOLR-14574) Fix or suppress warnings in solr/core/src/test

2020-06-15 Thread Erick Erickson (Jira)
Erick Erickson created SOLR-14574: - Summary: Fix or suppress warnings in solr/core/src/test Key: SOLR-14574 URL: https://issues.apache.org/jira/browse/SOLR-14574 Project: Solr Issue Type: Sub

[jira] [Created] (SOLR-14575) Solr restore is failing when basic authentication is enabled

2020-06-15 Thread Yaswanth (Jira)
Yaswanth created SOLR-14575: --- Summary: Solr restore is failing when basic authentication is enabled Key: SOLR-14575 URL: https://issues.apache.org/jira/browse/SOLR-14575 Project: Solr Issue Type:

[jira] [Commented] (SOLR-14516) NPE during Realtime GET

2020-06-15 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136308#comment-17136308 ] Noble Paul commented on SOLR-14516: --- Ishan Chattopadhyaya You are right. There are 2 p

[jira] [Commented] (SOLR-14384) Stack SolrRequestInfo

2020-06-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136323#comment-17136323 ] ASF subversion and git services commented on SOLR-14384: Commit 2

[GitHub] [lucene-solr] dsmiley closed pull request #1527: SOLR-14384 Stack SolrRequestInfo

2020-06-15 Thread GitBox
dsmiley closed pull request #1527: URL: https://github.com/apache/lucene-solr/pull/1527 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (SOLR-14384) Stack SolrRequestInfo

2020-06-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136333#comment-17136333 ] ASF subversion and git services commented on SOLR-14384: Commit 3

[jira] [Updated] (SOLR-14384) Stack SolrRequestInfo

2020-06-15 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-14384: Fix Version/s: 8.6 Resolution: Fixed Status: Resolved (was: Patch Available) > S

[jira] [Updated] (SOLR-14571) Index download speed while replicating is fixed at 5.1 in replication.html

2020-06-15 Thread Florin Babes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Florin Babes updated SOLR-14571: Attachment: (was: SOLR-14571.patch) > Index download speed while replicating is fixed at 5.1 in

[jira] [Updated] (SOLR-14571) Index download speed while replicating is fixed at 5.1 in replication.html

2020-06-15 Thread Florin Babes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Florin Babes updated SOLR-14571: Status: Open (was: Patch Available) > Index download speed while replicating is fixed at 5.1 in re

[jira] [Updated] (SOLR-14571) Index download speed while replicating is fixed at 5.1 in replication.html

2020-06-15 Thread Florin Babes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Florin Babes updated SOLR-14571: Status: Patch Available (was: Open) > Index download speed while replicating is fixed at 5.1 in re

[jira] [Updated] (SOLR-14571) Index download speed while replicating is fixed at 5.1 in replication.html

2020-06-15 Thread Florin Babes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Florin Babes updated SOLR-14571: Attachment: SOLR-14571.patch > Index download speed while replicating is fixed at 5.1 in replicatio

[jira] [Commented] (SOLR-8274) Add per-request MDC logging based on user-provided value.

2020-06-15 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136353#comment-17136353 ] David Smiley commented on SOLR-8274: Note a recent issue SOLR-14566 proposes a particu

  1   2   >