dsmiley commented on a change in pull request #1576:
URL: https://github.com/apache/lucene-solr/pull/1576#discussion_r440309711
##########
File path: lucene/core/src/java/org/apache/lucene/index/MergePolicy.java
##########
@@ -399,8 +423,19 @@ public String segString(Directory dir) {
}
return b.toString();
}
+
+ boolean await(long timeout, TimeUnit unit) {
+ for (OneMerge merge : merges) {
+ if (merge.await(timeout, unit) == false) {
Review comment:
This looks suspicious when there is more than one merge. Shouldn't the
timeout decrease as time is used up by earlier merges?
In practice, when is there more than one? I've been confused on this matter
when I developed a custom MP/MS.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
