[GitHub] [lucene-solr] NazerkeBS commented on a change in pull request #1527: SOLR-14384 Stack SolrRequestInfo

2020-05-25 Thread GitBox
NazerkeBS commented on a change in pull request #1527: URL: https://github.com/apache/lucene-solr/pull/1527#discussion_r429763566 ## File path: solr/core/src/java/org/apache/solr/request/SolrRequestInfo.java ## @@ -38,7 +40,13 @@ public class SolrRequestInfo { - protected

[jira] [Commented] (LUCENE-9286) FST arc.copyOf clones BitTables and this can lead to excessive memory use

2020-05-25 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17115802#comment-17115802 ] Adrien Grand commented on LUCENE-9286: -- FYI I was just digging a Kuromoji regressio

[jira] [Commented] (LUCENE-9286) FST arc.copyOf clones BitTables and this can lead to excessive memory use

2020-05-25 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17115809#comment-17115809 ] Bruno Roustant commented on LUCENE-9286: Thanks for the info Adrien. > FST arc.

[GitHub] [lucene-solr] janhoy commented on a change in pull request #1528: SOLR-12823: remove /clusterstate.json

2020-05-25 Thread GitBox
janhoy commented on a change in pull request #1528: URL: https://github.com/apache/lucene-solr/pull/1528#discussion_r429775163 ## File path: solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimClusterStateProvider.java ## @@ -790,6 +790,33 @@ public void simRemoveRepli

[jira] [Commented] (SOLR-14347) Autoscaling placement wrong when concurrent replica placements are calculated

2020-05-25 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17115821#comment-17115821 ] Andrzej Bialecki commented on SOLR-14347: - [~murblanc] sure, please go ahead. >

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1528: SOLR-12823: remove /clusterstate.json

2020-05-25 Thread GitBox
murblanc commented on a change in pull request #1528: URL: https://github.com/apache/lucene-solr/pull/1528#discussion_r429812067 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/RestoreCmd.java ## @@ -160,9 +159,6 @@ public void call(ClusterState state, Z

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1528: SOLR-12823: remove /clusterstate.json

2020-05-25 Thread GitBox
murblanc commented on a change in pull request #1528: URL: https://github.com/apache/lucene-solr/pull/1528#discussion_r429811700 ## File path: solr/core/src/java/org/apache/solr/cloud/ZkController.java ## @@ -491,6 +494,41 @@ public boolean isClosed() { assert ObjectReleas

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1528: SOLR-12823: remove /clusterstate.json

2020-05-25 Thread GitBox
murblanc commented on a change in pull request #1528: URL: https://github.com/apache/lucene-solr/pull/1528#discussion_r429815739 ## File path: solr/core/src/test/org/apache/solr/cloud/OverseerTest.java ## @@ -181,16 +180,21 @@ public void close() { zkStateReader.close();

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1528: SOLR-12823: remove /clusterstate.json

2020-05-25 Thread GitBox
murblanc commented on a change in pull request #1528: URL: https://github.com/apache/lucene-solr/pull/1528#discussion_r429816694 ## File path: solr/core/src/test/org/apache/solr/cloud/TestZkChroot.java ## @@ -27,8 +27,10 @@ import org.apache.solr.core.CoreContainer; import or

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1528: SOLR-12823: remove /clusterstate.json

2020-05-25 Thread GitBox
murblanc commented on a change in pull request #1528: URL: https://github.com/apache/lucene-solr/pull/1528#discussion_r429817130 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java ## @@ -138,8 +138,7 @@ private ClusterState fe

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1528: SOLR-12823: remove /clusterstate.json

2020-05-25 Thread GitBox
murblanc commented on a change in pull request #1528: URL: https://github.com/apache/lucene-solr/pull/1528#discussion_r429817725 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java ## @@ -210,47 +200,42 @@ public boolean liveNodesContain(String name

[GitHub] [lucene-solr] janhoy commented on a change in pull request #1528: SOLR-12823: remove /clusterstate.json

2020-05-25 Thread GitBox
janhoy commented on a change in pull request #1528: URL: https://github.com/apache/lucene-solr/pull/1528#discussion_r429829357 ## File path: solr/core/src/java/org/apache/solr/cloud/ZkController.java ## @@ -491,6 +494,41 @@ public boolean isClosed() { assert ObjectReleaseT

[GitHub] [lucene-solr] janhoy commented on a change in pull request #1528: SOLR-12823: remove /clusterstate.json

2020-05-25 Thread GitBox
janhoy commented on a change in pull request #1528: URL: https://github.com/apache/lucene-solr/pull/1528#discussion_r429830491 ## File path: solr/core/src/test/org/apache/solr/cloud/OverseerTest.java ## @@ -181,16 +180,21 @@ public void close() { zkStateReader.close();

[GitHub] [lucene-solr] janhoy commented on a change in pull request #1528: SOLR-12823: remove /clusterstate.json

2020-05-25 Thread GitBox
janhoy commented on a change in pull request #1528: URL: https://github.com/apache/lucene-solr/pull/1528#discussion_r429831171 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java ## @@ -210,47 +200,42 @@ public boolean liveNodesContain(String name)

[jira] [Commented] (LUCENE-9378) Configurable compression for BinaryDocValues

2020-05-25 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17115885#comment-17115885 ] Adrien Grand commented on LUCENE-9378: -- bq. Another factor that probably plays a ro

[jira] [Commented] (SOLR-14498) BlockCache gets stuck not accepting new stores

2020-05-25 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17115903#comment-17115903 ] Andrzej Bialecki commented on SOLR-14498: - [~jakubzytka] If I understand this cor

[GitHub] [lucene-solr] sigram commented on a change in pull request #1506: SOLR-14470: Add streaming expressions to /export handler

2020-05-25 Thread GitBox
sigram commented on a change in pull request #1506: URL: https://github.com/apache/lucene-solr/pull/1506#discussion_r429847378 ## File path: solr/core/src/java/org/apache/solr/handler/export/ExportWriter.java ## @@ -216,14 +376,53 @@ public void write(OutputStream os) throws IO

[GitHub] [lucene-solr] sigram commented on a change in pull request #1506: SOLR-14470: Add streaming expressions to /export handler

2020-05-25 Thread GitBox
sigram commented on a change in pull request #1506: URL: https://github.com/apache/lucene-solr/pull/1506#discussion_r429849300 ## File path: solr/core/src/java/org/apache/solr/handler/export/ExportWriter.java ## @@ -285,22 +484,48 @@ protected void addDocsToItemWriter(List lea

[GitHub] [lucene-solr] sigram commented on a change in pull request #1506: SOLR-14470: Add streaming expressions to /export handler

2020-05-25 Thread GitBox
sigram commented on a change in pull request #1506: URL: https://github.com/apache/lucene-solr/pull/1506#discussion_r429849300 ## File path: solr/core/src/java/org/apache/solr/handler/export/ExportWriter.java ## @@ -285,22 +484,48 @@ protected void addDocsToItemWriter(List lea

[GitHub] [lucene-solr] sigram commented on a change in pull request #1506: SOLR-14470: Add streaming expressions to /export handler

2020-05-25 Thread GitBox
sigram commented on a change in pull request #1506: URL: https://github.com/apache/lucene-solr/pull/1506#discussion_r429852167 ## File path: solr/core/src/java/org/apache/solr/handler/sql/FilterCalciteConnection.java ## @@ -0,0 +1,382 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene-solr] sigram commented on a change in pull request #1506: SOLR-14470: Add streaming expressions to /export handler

2020-05-25 Thread GitBox
sigram commented on a change in pull request #1506: URL: https://github.com/apache/lucene-solr/pull/1506#discussion_r429854938 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/Tuple.java ## @@ -44,24 +45,35 @@ public boolean EOF; public boolean EXCEPTION;

[GitHub] [lucene-solr] sigram commented on a change in pull request #1506: SOLR-14470: Add streaming expressions to /export handler

2020-05-25 Thread GitBox
sigram commented on a change in pull request #1506: URL: https://github.com/apache/lucene-solr/pull/1506#discussion_r429854808 ## File path: solr/solrj/src/java/org/apache/solr/common/params/StreamParams.java ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [lucene-solr] sigram commented on a change in pull request #1506: SOLR-14470: Add streaming expressions to /export handler

2020-05-25 Thread GitBox
sigram commented on a change in pull request #1506: URL: https://github.com/apache/lucene-solr/pull/1506#discussion_r429854601 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/StatsStream.java ## @@ -266,91 +252,106 @@ public void close() throws IOExcep

[GitHub] [lucene-solr] radu-gheorghe opened a new pull request #1536: Documented node.sysprop shard preference

2020-05-25 Thread GitBox
radu-gheorghe opened a new pull request #1536: URL: https://github.com/apache/lucene-solr/pull/1536 For https://issues.apache.org/jira/browse/SOLR-13445 This is an automated message from the Apache Git Service. To respond

[jira] [Created] (SOLR-14511) Add documentation for node.sysprop shard preference

2020-05-25 Thread Radu Gheorghe (Jira)
Radu Gheorghe created SOLR-14511: Summary: Add documentation for node.sysprop shard preference Key: SOLR-14511 URL: https://issues.apache.org/jira/browse/SOLR-14511 Project: Solr Issue Type:

[jira] [Commented] (LUCENE-9352) Add cost function to Scorable

2020-05-25 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116086#comment-17116086 ] Adrien Grand commented on LUCENE-9352: -- +1 > Add cost function to Scorable > -

[jira] [Commented] (SOLR-14498) BlockCache gets stuck not accepting new stores

2020-05-25 Thread Jakub Zytka (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116144#comment-17116144 ] Jakub Zytka commented on SOLR-14498: Upgrading to caffeine 2.8.4 should solve the pro

[jira] [Commented] (LUCENE-9378) Configurable compression for BinaryDocValues

2020-05-25 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116167#comment-17116167 ] Michael Sokolov commented on LUCENE-9378: - {quote}... binary doc values at Amazo

[jira] [Commented] (LUCENE-9352) Add cost function to Scorable

2020-05-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116201#comment-17116201 ] David Smiley commented on LUCENE-9352: -- Is this about the cost of the score() call

[jira] [Commented] (LUCENE-9352) Add cost function to Scorable

2020-05-25 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116236#comment-17116236 ] Adrien Grand commented on LUCENE-9352: -- It would be the same cost as DocIdSetIterat

[jira] [Commented] (LUCENE-9352) Add cost function to Scorable

2020-05-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116242#comment-17116242 ] David Smiley commented on LUCENE-9352: -- Okay; all the more reason for a unambiguous

[jira] [Created] (SOLR-14512) Require java 8 upgrade

2020-05-25 Thread Akhila John (Jira)
Akhila John created SOLR-14512: -- Summary: Require java 8 upgrade Key: SOLR-14512 URL: https://issues.apache.org/jira/browse/SOLR-14512 Project: Solr Issue Type: Task Security Level: Public