[jira] [Commented] (LUCENE-9058) IntervalQuery.matches() does't emit alt field under I.or(I.fixField()) at least

2019-11-25 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981415#comment-16981415 ] Alan Woodward commented on LUCENE-9058: --- Thinking about this, I think it's actuall

[jira] [Created] (LUCENE-9062) Extend QueryVisitor to support multi-term queries

2019-11-25 Thread Alan Woodward (Jira)
Alan Woodward created LUCENE-9062: - Summary: Extend QueryVisitor to support multi-term queries Key: LUCENE-9062 URL: https://issues.apache.org/jira/browse/LUCENE-9062 Project: Lucene - Core I

[GitHub] [lucene-solr] romseygeek opened a new pull request #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching

2019-11-25 Thread GitBox
romseygeek opened a new pull request #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching URL: https://github.com/apache/lucene-solr/pull/1037 This commit adds a `consumeTermsMatching()` method to QueryVisitor, allowing queries that match against a class of terms to report this back to

[GitHub] [lucene-solr] romseygeek commented on issue #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching

2019-11-25 Thread GitBox
romseygeek commented on issue #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching URL: https://github.com/apache/lucene-solr/pull/1037#issuecomment-558080788 I've gone back and forth on the best implementation here, particularly in terms of what we should actually be passing back to `con

[jira] [Commented] (LUCENE-9062) Extend QueryVisitor to support multi-term queries

2019-11-25 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981419#comment-16981419 ] Alan Woodward commented on LUCENE-9062: --- cc [~mkhl] [~dsmiley] > Extend QueryVisi

[jira] [Created] (LUCENE-9063) Speed up computation of impacts

2019-11-25 Thread Adrien Grand (Jira)
Adrien Grand created LUCENE-9063: Summary: Speed up computation of impacts Key: LUCENE-9063 URL: https://issues.apache.org/jira/browse/LUCENE-9063 Project: Lucene - Core Issue Type: Improveme

[GitHub] [lucene-solr] jpountz opened a new pull request #1038: LUCENE-9063: Speed up computation of impacts.

2019-11-25 Thread GitBox
jpountz opened a new pull request #1038: LUCENE-9063: Speed up computation of impacts. URL: https://github.com/apache/lucene-solr/pull/1038 The current design of CompetitiveImpactAccumulator treats norms in -128..127 as a special case that should be optimized. This commit goes a bit furt

[jira] [Commented] (LUCENE-9058) IntervalQuery.matches() does't emit alt field under I.or(I.fixField()) at least

2019-11-25 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981427#comment-16981427 ] Mikhail Khludnev commented on LUCENE-9058: -- These considerations makes really m

[GitHub] [lucene-solr] mkhludnev commented on a change in pull request #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching

2019-11-25 Thread GitBox
mkhludnev commented on a change in pull request #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching URL: https://github.com/apache/lucene-solr/pull/1037#discussion_r350105918 ## File path: lucene/core/src/java/org/apache/lucene/search/FuzzyQuery.java ## @@ -156,9 +159,14

[jira] [Created] (SOLR-13968) Support postingsFormat and docValuesFormat in schema fields

2019-11-25 Thread Bruno Roustant (Jira)
Bruno Roustant created SOLR-13968: - Summary: Support postingsFormat and docValuesFormat in schema fields Key: SOLR-13968 URL: https://issues.apache.org/jira/browse/SOLR-13968 Project: Solr I

[jira] [Updated] (SOLR-13968) Support postingsFormat and docValuesFormat in schema fields

2019-11-25 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant updated SOLR-13968: -- Description: Currently it is only possible to declare the postingsFormat and/opr docValuesForm

[GitHub] [lucene-solr] bruno-roustant opened a new pull request #1039: SOLR-13968: Support postingsFormat and docValuesFormat in schema fields

2019-11-25 Thread GitBox
bruno-roustant opened a new pull request #1039: SOLR-13968: Support postingsFormat and docValuesFormat in schema fields URL: https://github.com/apache/lucene-solr/pull/1039 This is an automated message from the Apache Git Se

[jira] [Updated] (SOLR-13968) Support postingsFormat and docValuesFormat in schema fields

2019-11-25 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant updated SOLR-13968: -- Description: Currently it is only possible to declare the postingsFormat and/or docValuesForma

[jira] [Commented] (LUCENE-9058) IntervalQuery.matches() does't emit alt field under I.or(I.fixField()) at least

2019-11-25 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981481#comment-16981481 ] Alan Woodward commented on LUCENE-9058: --- I'd say that IntervalQuery works implicit

[GitHub] [lucene-solr] romseygeek commented on a change in pull request #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching

2019-11-25 Thread GitBox
romseygeek commented on a change in pull request #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching URL: https://github.com/apache/lucene-solr/pull/1037#discussion_r350142799 ## File path: lucene/core/src/java/org/apache/lucene/search/FuzzyQuery.java ## @@ -156,9 +159,1

[jira] [Created] (LUCENE-9064) Can we remove the FST cache in Kuromoji and Nori analyzers?

2019-11-25 Thread Bruno Roustant (Jira)
Bruno Roustant created LUCENE-9064: -- Summary: Can we remove the FST cache in Kuromoji and Nori analyzers? Key: LUCENE-9064 URL: https://issues.apache.org/jira/browse/LUCENE-9064 Project: Lucene - Cor

[jira] [Commented] (LUCENE-9049) Remove FST cachedRootArcs now redundant with direct-addressing

2019-11-25 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981548#comment-16981548 ] Bruno Roustant commented on LUCENE-9049: I created LUCENE-9064 (Can we remove th

[jira] [Commented] (LUCENE-9064) Can we remove the FST cache in Kuromoji and Nori analyzers?

2019-11-25 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981549#comment-16981549 ] Bruno Roustant commented on LUCENE-9064: [~rcmuir] is there a benchmark somewher

[GitHub] [lucene-solr] juanka588 commented on a change in pull request #1039: SOLR-13968: Support postingsFormat and docValuesFormat in schema fields

2019-11-25 Thread GitBox
juanka588 commented on a change in pull request #1039: SOLR-13968: Support postingsFormat and docValuesFormat in schema fields URL: https://github.com/apache/lucene-solr/pull/1039#discussion_r350199696 ## File path: solr/core/src/java/org/apache/solr/schema/FieldProperties.java ###

[jira] [Updated] (SOLR-13963) JavaBinCodec has concurrent modification of CharArr resulting in corrupt intranode updates

2019-11-25 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya updated SOLR-13963: Priority: Blocker (was: Major) > JavaBinCodec has concurrent modification of CharA

[jira] [Updated] (SOLR-13963) JavaBinCodec has concurrent modification of CharArr resulting in corrupt intranode updates

2019-11-25 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya updated SOLR-13963: Fix Version/s: 8.3.1 > JavaBinCodec has concurrent modification of CharArr resultin

[jira] [Created] (LUCENE-9065) Luke displays weird characters for binary payloads

2019-11-25 Thread Dmitry Kan (Jira)
Dmitry Kan created LUCENE-9065: -- Summary: Luke displays weird characters for binary payloads Key: LUCENE-9065 URL: https://issues.apache.org/jira/browse/LUCENE-9065 Project: Lucene - Core Issue

[jira] [Updated] (LUCENE-9065) Luke displays weird characters for binary payloads

2019-11-25 Thread Dmitry Kan (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Kan updated LUCENE-9065: --- Description: When payloads are binary, like short int, Luke displays some unreadable characters.  

[jira] [Commented] (LUCENE-8983) PhraseWildcardQuery - new query to control and optimize wildcard expansions in phrase

2019-11-25 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981638#comment-16981638 ] Bruno Roustant commented on LUCENE-8983: I'll merge this PR within 2 days if the

[GitHub] [lucene-solr] dsmiley closed pull request #1030: SOLR-13961: Fix Atomic Update unset nested documents

2019-11-25 Thread GitBox
dsmiley closed pull request #1030: SOLR-13961: Fix Atomic Update unset nested documents URL: https://github.com/apache/lucene-solr/pull/1030 This is an automated message from the Apache Git Service. To respond to the message

[jira] [Commented] (SOLR-13961) Unsetting Nested Documents using Atomic Update leads to SolrException: undefined field

2019-11-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981644#comment-16981644 ] ASF subversion and git services commented on SOLR-13961: Commit b

[jira] [Assigned] (LUCENE-9049) Remove FST cachedRootArcs now redundant with direct-addressing

2019-11-25 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant reassigned LUCENE-9049: -- Assignee: Bruno Roustant > Remove FST cachedRootArcs now redundant with direct-addres

[jira] [Commented] (LUCENE-9049) Remove FST cachedRootArcs now redundant with direct-addressing

2019-11-25 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981646#comment-16981646 ] Bruno Roustant commented on LUCENE-9049: I'm going to merge this patch tomorrow

[jira] [Assigned] (LUCENE-8983) PhraseWildcardQuery - new query to control and optimize wildcard expansions in phrase

2019-11-25 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant reassigned LUCENE-8983: -- Assignee: Bruno Roustant > PhraseWildcardQuery - new query to control and optimize wi

[jira] [Commented] (SOLR-13961) Unsetting Nested Documents using Atomic Update leads to SolrException: undefined field

2019-11-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981648#comment-16981648 ] ASF subversion and git services commented on SOLR-13961: Commit 5

[jira] [Updated] (SOLR-13961) Unsetting Nested Documents using Atomic Update leads to SolrException: undefined field

2019-11-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-13961: Component/s: (was: UpdateRequestProcessors) (was: Tests) Af

[jira] [Resolved] (SOLR-13961) Unsetting Nested Documents using Atomic Update leads to SolrException: undefined field

2019-11-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-13961. - Fix Version/s: 8.4 Resolution: Fixed Thanks Thomas! > Unsetting Nested Documents using At

[jira] [Commented] (SOLR-13952) Added SuppressWarnings and similar minor matters

2019-11-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981701#comment-16981701 ] ASF subversion and git services commented on SOLR-13952: Commit 0

[jira] [Commented] (SOLR-13952) Added SuppressWarnings and similar minor matters

2019-11-25 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981725#comment-16981725 ] Erick Erickson commented on SOLR-13952: --- OK, Dawid and I talked and he volunteered

[jira] [Updated] (SOLR-11706) JSON FacetModule can't compute stats (min,max,etc...) on multivalued fields

2019-11-25 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N updated SOLR-11706: Attachment: SOLR-11706.patch > JSON FacetModule can't compute stats (min,max,etc...) on multivalued

[jira] [Comment Edited] (LUCENE-9064) Can we remove the FST cache in Kuromoji and Nori analyzers?

2019-11-25 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981739#comment-16981739 ] Michael Sokolov edited comment on LUCENE-9064 at 11/25/19 5:43 PM: ---

[jira] [Commented] (LUCENE-9064) Can we remove the FST cache in Kuromoji and Nori analyzers?

2019-11-25 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981739#comment-16981739 ] Michael Sokolov commented on LUCENE-9064: - [~bruno.roustant] there is \{TestJapa

[jira] [Commented] (LUCENE-9049) Remove FST cachedRootArcs now redundant with direct-addressing

2019-11-25 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981740#comment-16981740 ] Michael Sokolov commented on LUCENE-9049: - I just re-ran tests locally (I was pl

[jira] [Updated] (SOLR-11706) JSON FacetModule can't compute stats (min,max,etc...) on multivalued fields

2019-11-25 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N updated SOLR-11706: Status: Patch Available (was: Open) > JSON FacetModule can't compute stats (min,max,etc...) on mul

[jira] [Commented] (SOLR-11706) JSON FacetModule can't compute stats (min,max,etc...) on multivalued fields

2019-11-25 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981752#comment-16981752 ] Munendra S N commented on SOLR-11706: - [^SOLR-11706.patch] This patch contains aggr

[jira] [Updated] (SOLR-13283) when facet with certain terms via {!terms}, facet.limit, facet.offset does not work

2019-11-25 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N updated SOLR-13283: Component/s: faceting > when facet with certain terms via {!terms}, facet.limit, facet.offset does

[jira] [Updated] (SOLR-13094) NPE while doing regular Facet

2019-11-25 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N updated SOLR-13094: Component/s: faceting FacetComponent > NPE while doing regular Facet > ---

[jira] [Updated] (SOLR-13283) when facet with certain terms via {!terms}, facet.limit, facet.offset does not work

2019-11-25 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N updated SOLR-13283: Component/s: (was: Facet Module) > when facet with certain terms via {!terms}, facet.limit, fac

[jira] [Updated] (SOLR-13094) NPE while doing regular Facet

2019-11-25 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N updated SOLR-13094: Component/s: (was: Facet Module) > NPE while doing regular Facet >

[jira] [Commented] (LUCENE-9064) Can we remove the FST cache in Kuromoji and Nori analyzers?

2019-11-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981773#comment-16981773 ] Robert Muir commented on LUCENE-9064: - That one is probably easiest because you woul

[jira] [Updated] (SOLR-11533) Limit/offset on the number of buckets returned in Analytical facets

2019-11-25 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N updated SOLR-11533: Component/s: (was: Facet Module) > Limit/offset on the number of buckets returned in Analytical

[jira] [Commented] (LUCENE-9058) IntervalQuery.matches() does't emit alt field under I.or(I.fixField()) at least

2019-11-25 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981789#comment-16981789 ] Mikhail Khludnev commented on LUCENE-9058: -- Ok. It's fair. Despite {{WeightedSp

[jira] [Resolved] (LUCENE-9058) IntervalQuery.matches() does't emit alt field under I.or(I.fixField()) at least

2019-11-25 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev resolved LUCENE-9058. -- Resolution: Won't Fix Thanks, [~romseygeek] > IntervalQuery.matches() does't emit alt

[GitHub] [lucene-solr] pinkeshsharma commented on issue #908: Change the file format of README files from README.txt to README.md a…

2019-11-25 Thread GitBox
pinkeshsharma commented on issue #908: Change the file format of README files from README.txt to README.md a… URL: https://github.com/apache/lucene-solr/pull/908#issuecomment-558315238 Should we move forward with this? On Thu, Nov 14, 2019 at 3:19 AM Jan Høydahl wrote: > +

[jira] [Commented] (SOLR-13662) Package manager CLI

2019-11-25 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-13662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981859#comment-16981859 ] Jan Høydahl commented on SOLR-13662: +1 David. Everything you say makes sense. We sho

[jira] [Resolved] (SOLR-13952) Added SuppressWarnings and similar minor matters

2019-11-25 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-13952. --- Resolution: Won't Fix AFAIC, this is more effort than it's worth just to remove some warnings

[jira] [Commented] (LUCENE-9049) Remove FST cachedRootArcs now redundant with direct-addressing

2019-11-25 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981874#comment-16981874 ] Bruno Roustant commented on LUCENE-9049: Thanks [~sokolov], that will be my firs

[jira] [Commented] (SOLR-13963) JavaBinCodec has concurrent modification of CharArr resulting in corrupt intranode updates

2019-11-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981898#comment-16981898 ] ASF subversion and git services commented on SOLR-13963: Commit c

[jira] [Updated] (SOLR-13963) JavaBinCodec has concurrent modification of CharArr resulting in corrupt intranode updates

2019-11-25 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-13963: -- Resolution: Fixed Status: Resolved (was: Patch Available) Thanks [~cjcowie] > JavaBinCodec h

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1039: SOLR-13968: Support postingsFormat and docValuesFormat in schema fields

2019-11-25 Thread GitBox
bruno-roustant commented on a change in pull request #1039: SOLR-13968: Support postingsFormat and docValuesFormat in schema fields URL: https://github.com/apache/lucene-solr/pull/1039#discussion_r350431085 ## File path: solr/core/src/java/org/apache/solr/schema/FieldProperties.java

[jira] [Commented] (SOLR-13963) JavaBinCodec has concurrent modification of CharArr resulting in corrupt intranode updates

2019-11-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981901#comment-16981901 ] ASF subversion and git services commented on SOLR-13963: Commit 4

[jira] [Commented] (LUCENE-9031) UnsupportedOperationException on highlighting Interval Query

2019-11-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981957#comment-16981957 ] David Smiley commented on LUCENE-9031: -- Wow; this is large tech-debt to basically d

[jira] [Commented] (SOLR-13932) Review directory locking and Blob interactions

2019-11-25 Thread Bilal Waheed (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16982001#comment-16982001 ] Bilal Waheed commented on SOLR-13932: - _>>Pushes should instead be done from the exis

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching

2019-11-25 Thread GitBox
dsmiley commented on a change in pull request #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching URL: https://github.com/apache/lucene-solr/pull/1037#discussion_r350488231 ## File path: lucene/core/src/java/org/apache/lucene/search/FuzzyQuery.java ## @@ -156,9 +160,13 @

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching

2019-11-25 Thread GitBox
dsmiley commented on a change in pull request #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching URL: https://github.com/apache/lucene-solr/pull/1037#discussion_r350486377 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/CharArrayMatcher.java ## @@ -

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching

2019-11-25 Thread GitBox
dsmiley commented on a change in pull request #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching URL: https://github.com/apache/lucene-solr/pull/1037#discussion_r350481687 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/MultiTermHighlighting.java #

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching

2019-11-25 Thread GitBox
dsmiley commented on a change in pull request #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching URL: https://github.com/apache/lucene-solr/pull/1037#discussion_r350484060 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/MemoryIndexOffsetStrategy.jav

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching

2019-11-25 Thread GitBox
dsmiley commented on a change in pull request #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching URL: https://github.com/apache/lucene-solr/pull/1037#discussion_r350480886 ## File path: lucene/core/src/java/org/apache/lucene/search/QueryVisitor.java ## @@ -37,8 +39,9 @@

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching

2019-11-25 Thread GitBox
dsmiley commented on a change in pull request #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching URL: https://github.com/apache/lucene-solr/pull/1037#discussion_r350480355 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/CharArrayMatcher.java ## @@ -

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching

2019-11-25 Thread GitBox
dsmiley commented on a change in pull request #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching URL: https://github.com/apache/lucene-solr/pull/1037#discussion_r350480740 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/ByteRunAutomaton.java ## @@ -

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching

2019-11-25 Thread GitBox
dsmiley commented on a change in pull request #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching URL: https://github.com/apache/lucene-solr/pull/1037#discussion_r350479779 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/CharArrayMatcher.java ## @@ -

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching

2019-11-25 Thread GitBox
dsmiley commented on a change in pull request #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching URL: https://github.com/apache/lucene-solr/pull/1037#discussion_r350479038 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/FieldOffsetStrategy.java ###

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching

2019-11-25 Thread GitBox
dsmiley commented on a change in pull request #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching URL: https://github.com/apache/lucene-solr/pull/1037#discussion_r350484695 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/MultiTermHighlighting.java #

[jira] [Comment Edited] (SOLR-13932) Review directory locking and Blob interactions

2019-11-25 Thread Bilal Waheed (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16982001#comment-16982001 ] Bilal Waheed edited comment on SOLR-13932 at 11/26/19 12:25 AM: ---

[jira] [Assigned] (SOLR-13926) Document CompositeIDRouter.java

2019-11-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley reassigned SOLR-13926: --- Assignee: David Smiley > Document CompositeIDRouter.java > --- >

[jira] [Updated] (LUCENE-9038) Improve LruQueryCache's concurrency

2019-11-25 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Manes updated LUCENE-9038: -- Summary: Improve LruQueryCache's concurrency (was: Evaluate Caffeine for LruQueryCache) > Improve Lr

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1039: SOLR-13968: Support postingsFormat and docValuesFormat in schema fields

2019-11-25 Thread GitBox
dsmiley commented on a change in pull request #1039: SOLR-13968: Support postingsFormat and docValuesFormat in schema fields URL: https://github.com/apache/lucene-solr/pull/1039#discussion_r350497400 ## File path: solr/core/src/test/org/apache/solr/schema/TestSchemaField.java #

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1039: SOLR-13968: Support postingsFormat and docValuesFormat in schema fields

2019-11-25 Thread GitBox
dsmiley commented on a change in pull request #1039: SOLR-13968: Support postingsFormat and docValuesFormat in schema fields URL: https://github.com/apache/lucene-solr/pull/1039#discussion_r350496520 ## File path: solr/core/src/java/org/apache/solr/schema/SchemaField.java #

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1039: SOLR-13968: Support postingsFormat and docValuesFormat in schema fields

2019-11-25 Thread GitBox
dsmiley commented on a change in pull request #1039: SOLR-13968: Support postingsFormat and docValuesFormat in schema fields URL: https://github.com/apache/lucene-solr/pull/1039#discussion_r350495197 ## File path: solr/core/src/java/org/apache/solr/schema/SchemaField.java #

[GitHub] [lucene-solr] atris commented on issue #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache

2019-11-25 Thread GitBox
atris commented on issue #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/916#issuecomment-558481996 Ran test suite again, and beasted LRUQueryCache tests 20 odd times -- no failure. Thanks @jpountz ! -

[GitHub] [lucene-solr] atris merged pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache

2019-11-25 Thread GitBox
atris merged pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/916 This is an automated message from the Apache Git Service. To respond to the message, plea

[jira] [Commented] (LUCENE-8213) Cache costly subqueries asynchronously

2019-11-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16982171#comment-16982171 ] ASF subversion and git services commented on LUCENE-8213: - Commi

[jira] [Commented] (LUCENE-8213) Cache costly subqueries asynchronously

2019-11-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16982172#comment-16982172 ] ASF subversion and git services commented on LUCENE-8213: - Commi

[jira] [Commented] (SOLR-11706) JSON FacetModule can't compute stats (min,max,etc...) on multivalued fields

2019-11-25 Thread Lucene/Solr QA (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16982190#comment-16982190 ] Lucene/Solr QA commented on SOLR-11706: --- | (x) *{color:red}-1 overall{color}* | \\

[jira] [Created] (LUCENE-9066) Modal Strategy In Concurrent Query Execution

2019-11-25 Thread Atri Sharma (Jira)
Atri Sharma created LUCENE-9066: --- Summary: Modal Strategy In Concurrent Query Execution Key: LUCENE-9066 URL: https://issues.apache.org/jira/browse/LUCENE-9066 Project: Lucene - Core Issue Type