jainankitk commented on PR #14413:
URL: https://github.com/apache/lucene/pull/14413#issuecomment-2762048902
> You just need to replace ctx with _.
Ah, my bad! I tried `.`, but we can't use that as part of variable name.
Thanks for the suggestion @jpountz.
At a high level, I hav
jpountz commented on PR #14413:
URL: https://github.com/apache/lucene/pull/14413#issuecomment-2761334037
You just need to replace `ctx` with `_`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
jainankitk commented on PR #14413:
URL: https://github.com/apache/lucene/pull/14413#issuecomment-2760401254
One of the failing check is:
```
--
1. ERROR in
/home/runner/work/lucene/lucene/lucene/sandbox/src/java/org/apache/lucene/sandbox/search/QueryProfilerBreakdown.jav
jpountz commented on PR #14413:
URL: https://github.com/apache/lucene/pull/14413#issuecomment-2759377415
@jainankitk OK. In my opinion, it's more important to handle the concurrent
and non-concurrent cases consistently than to save some overhead when searches
are not concurrent. I'd really
jainankitk commented on PR #14413:
URL: https://github.com/apache/lucene/pull/14413#issuecomment-2759709664
> In my opinion, it's more important to handle the concurrent and
non-concurrent cases consistently than to save some overhead when searches are
not concurrent. I'd really like non-co
jainankitk commented on PR #14413:
URL: https://github.com/apache/lucene/pull/14413#issuecomment-2759703236
> Does it make sense to create a separate QueryProfilerBreakDown per leaf?
Or should it create one per slice?
Actually, create one per slice makes lot of sense.
> Can thi
msfroh commented on PR #14413:
URL: https://github.com/apache/lucene/pull/14413#issuecomment-2759357863
Does it make sense to create a separate `QueryProfilerBreakDown` per leaf?
Or should it create one per slice?
Can this be implemented as part of the `CollectorManager#newCollector`
jainankitk commented on PR #14413:
URL: https://github.com/apache/lucene/pull/14413#issuecomment-2758741304
> Can you explain why we need two impls? I would have assumed that the
ConcurrentQueryProfilerBreakdown could also be used for searches that are not
concurrent?
`ConcurrentQuer
jpountz commented on PR #14413:
URL: https://github.com/apache/lucene/pull/14413#issuecomment-2756886264
Can you explain why we need two impls? I would have assumed that the
`ConcurrentQueryProfilerBreakdown` could also be used for searches that are not
concurrent?
--
This is an automate
