jainankitk commented on PR #14413: URL: https://github.com/apache/lucene/pull/14413#issuecomment-2759703236
> Does it make sense to create a separate QueryProfilerBreakDown per leaf? Or should it create one per slice? Actually, create one per slice makes lot of sense. > Can this be implemented as part of the ProfilerCollectorManager#newCollector logic? Maybe not, since we would also need to profile the work done by the Weight + Scorer on each slice We can always use `ThreadId` for correctly tracking the mapping from slice to `QueryProfilerBreakdown` object. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
