Re: [PR] Get rid of deprecated assertThat() usages [lucene]

dweiss merged PR #12982: URL: https://github.com/apache/lucene/pull/12982 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [PR] Get rid of deprecated assertThat() usages [lucene]

dweiss commented on PR #12982: URL: https://github.com/apache/lucene/pull/12982#issuecomment-1885048582 Thank you! Please use regular merges, not force-pushes, unless absolutely necessary. A linear merge/change commit is easier to follow-up to (compared to a new forced commit). All pull req

Re: [PR] Get rid of deprecated assertThat() usages [lucene]

sabi0 commented on code in PR #12982: URL: https://github.com/apache/lucene/pull/12982#discussion_r1447230132 ## lucene/suggest/src/test/org/apache/lucene/search/suggest/document/TestSuggestField.java: ## @@ -485,7 +470,7 @@ public void testNRTDeletedDocFiltering() throws Except

Re: [PR] Get rid of deprecated assertThat() usages [lucene]

sabi0 commented on code in PR #12982: URL: https://github.com/apache/lucene/pull/12982#discussion_r1447229488 ## lucene/suggest/src/test/org/apache/lucene/search/suggest/document/TestSuggestField.java: ## @@ -766,12 +749,12 @@ public void testScoring() throws Exception {

Re: [PR] Get rid of deprecated assertThat() usages [lucene]

sabi0 commented on code in PR #12982: URL: https://github.com/apache/lucene/pull/12982#discussion_r1447229233 ## lucene/core/src/test/org/apache/lucene/geo/TestTessellator.java: ## @@ -841,20 +839,19 @@ public void testComplexPolygon50() throws Exception { public void testCom

Re: [PR] Get rid of deprecated assertThat() usages [lucene]

dweiss commented on code in PR #12982: URL: https://github.com/apache/lucene/pull/12982#discussion_r1445940966 ## lucene/core/src/test/org/apache/lucene/geo/TestTessellator.java: ## @@ -841,20 +839,19 @@ public void testComplexPolygon50() throws Exception { public void testCo

Re: [PR] Get rid of deprecated assertThat() usages [lucene]

sabi0 commented on code in PR #12982: URL: https://github.com/apache/lucene/pull/12982#discussion_r1445888566 ## lucene/suggest/src/test/org/apache/lucene/search/suggest/document/TestSuggestField.java: ## @@ -485,7 +470,7 @@ public void testNRTDeletedDocFiltering() throws Except

Re: [PR] Get rid of deprecated assertThat() usages [lucene]

dweiss commented on code in PR #12982: URL: https://github.com/apache/lucene/pull/12982#discussion_r1445883098 ## lucene/suggest/src/test/org/apache/lucene/search/suggest/document/TestSuggestField.java: ## @@ -766,12 +749,12 @@ public void testScoring() throws Exception {

Re: [PR] Get rid of deprecated assertThat() usages [lucene]

dweiss commented on code in PR #12982: URL: https://github.com/apache/lucene/pull/12982#discussion_r1445882248 ## lucene/suggest/src/test/org/apache/lucene/search/suggest/document/TestSuggestField.java: ## @@ -485,7 +470,7 @@ public void testNRTDeletedDocFiltering() throws Excep

Re: [PR] Get rid of deprecated assertThat() usages [lucene]

sabi0 commented on code in PR #12982: URL: https://github.com/apache/lucene/pull/12982#discussion_r1445816935 ## lucene/suggest/src/test/org/apache/lucene/search/suggest/document/TestSuggestField.java: ## @@ -485,7 +470,7 @@ public void testNRTDeletedDocFiltering() throws Except

Re: [PR] Get rid of deprecated assertThat() usages [lucene]

sabi0 commented on code in PR #12982: URL: https://github.com/apache/lucene/pull/12982#discussion_r1445839349 ## lucene/suggest/src/test/org/apache/lucene/search/suggest/document/TestSuggestField.java: ## @@ -766,12 +749,12 @@ public void testScoring() throws Exception {

Re: [PR] Get rid of deprecated assertThat() usages [lucene]

sabi0 commented on code in PR #12982: URL: https://github.com/apache/lucene/pull/12982#discussion_r1445839349 ## lucene/suggest/src/test/org/apache/lucene/search/suggest/document/TestSuggestField.java: ## @@ -766,12 +749,12 @@ public void testScoring() throws Exception {

Re: [PR] Get rid of deprecated assertThat() usages [lucene]

sabi0 commented on code in PR #12982: URL: https://github.com/apache/lucene/pull/12982#discussion_r1445816935 ## lucene/suggest/src/test/org/apache/lucene/search/suggest/document/TestSuggestField.java: ## @@ -485,7 +470,7 @@ public void testNRTDeletedDocFiltering() throws Except

Re: [PR] Get rid of deprecated assertThat() usages [lucene]

dweiss commented on code in PR #12982: URL: https://github.com/apache/lucene/pull/12982#discussion_r1437821648 ## lucene/suggest/src/test/org/apache/lucene/search/suggest/document/TestSuggestField.java: ## @@ -485,7 +470,7 @@ public void testNRTDeletedDocFiltering() throws Excep

Re: [PR] Get rid of deprecated assertThat() usages [lucene]

sabi0 commented on code in PR #12982: URL: https://github.com/apache/lucene/pull/12982#discussion_r1437800293 ## lucene/suggest/src/test/org/apache/lucene/search/suggest/document/TestSuggestField.java: ## @@ -485,7 +470,7 @@ public void testNRTDeletedDocFiltering() throws Except

Re: [PR] Get rid of deprecated assertThat() usages [lucene]

dweiss commented on code in PR #12982: URL: https://github.com/apache/lucene/pull/12982#discussion_r1437797850 ## lucene/suggest/src/test/org/apache/lucene/search/suggest/document/TestSuggestField.java: ## @@ -485,7 +470,7 @@ public void testNRTDeletedDocFiltering() throws Excep

Re: [PR] Get rid of deprecated assertThat() usages [lucene]

sabi0 commented on code in PR #12982: URL: https://github.com/apache/lucene/pull/12982#discussion_r1437788437 ## lucene/suggest/src/test/org/apache/lucene/search/suggest/document/TestSuggestField.java: ## @@ -485,7 +470,7 @@ public void testNRTDeletedDocFiltering() throws Except

Re: [PR] Get rid of deprecated assertThat() usages [lucene]

dweiss commented on code in PR #12982: URL: https://github.com/apache/lucene/pull/12982#discussion_r1437755617 ## lucene/suggest/src/test/org/apache/lucene/search/suggest/document/TestSuggestField.java: ## @@ -685,8 +669,8 @@ public void testMultipleSegments() throws Exception {