sabi0 commented on code in PR #12982:
URL: https://github.com/apache/lucene/pull/12982#discussion_r1445839349
##########
lucene/suggest/src/test/org/apache/lucene/search/suggest/document/TestSuggestField.java:
##########
@@ -766,12 +749,12 @@ public void testScoring() throws Exception {
assertTrue(topScore >= scoreDoc.score);
}
topScore = scoreDoc.score;
- assertThat((float) mappings.get(scoreDoc.key.toString()),
equalTo(scoreDoc.score));
+ assertEquals(scoreDoc.score, (float)
mappings.get(scoreDoc.key.toString()), 1.0e-8);
Review Comment:
There are 33 usages of `assertEquals(String, double, double, double)` and
653 usages of `assertEquals(String, float, float, float)` across the project.
The deltas vary considerably, from 0 to 0.0001 to 0.0000001 to 1e-10.
Maybe I should just use 0 delta in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
