sabi0 commented on code in PR #12982:
URL: https://github.com/apache/lucene/pull/12982#discussion_r1437788437
##########
lucene/suggest/src/test/org/apache/lucene/search/suggest/document/TestSuggestField.java:
##########
@@ -485,7 +470,7 @@ public void testNRTDeletedDocFiltering() throws Exception {
PrefixCompletionQuery query =
new PrefixCompletionQuery(analyzer, new Term("suggest_field", "abc_"));
TopSuggestDocs suggest = indexSearcher.suggest(query, numLive, false);
- assertSuggestions(suggest, expectedEntries.toArray(new
Entry[expectedEntries.size()]));
+ assertSuggestions(suggest, expectedEntries.toArray(new Entry[0]));
Review Comment:
I am not sure how do you expect `Entry::new` to be used here?
`toArray()` accepts an array and not an allocator.
As for the 0 size - it's more performant and generally safer since Java 6
than an array with a pre-calculated size.
See https://shipilev.net/blog/2016/arrays-wisdom-ancients/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
