Re: [PR] Add reopen method in PerThreadPKLookup [lucene]

2024-10-10 Thread via GitHub
jpountz merged PR #13596: URL: https://github.com/apache/lucene/pull/13596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Add reopen method in PerThreadPKLookup [lucene]

2024-09-18 Thread via GitHub
vsop-479 commented on PR #13596: URL: https://github.com/apache/lucene/pull/13596#issuecomment-2359833789 This change looks clearer, Thanks @jpountz . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Add reopen method in PerThreadPKLookup [lucene]

2024-09-11 Thread via GitHub
vsop-479 commented on code in PR #13596: URL: https://github.com/apache/lucene/pull/13596#discussion_r1756202375 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/PerThreadPKLookup.java: ## @@ -97,5 +174,28 @@ public int lookup(BytesRef id) throws IOException {

Re: [PR] Add reopen method in PerThreadPKLookup [lucene]

2024-09-11 Thread via GitHub
vsop-479 commented on code in PR #13596: URL: https://github.com/apache/lucene/pull/13596#discussion_r1756202375 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/PerThreadPKLookup.java: ## @@ -97,5 +174,28 @@ public int lookup(BytesRef id) throws IOException {

Re: [PR] Add reopen method in PerThreadPKLookup [lucene]

2024-09-11 Thread via GitHub
jpountz commented on code in PR #13596: URL: https://github.com/apache/lucene/pull/13596#discussion_r1754382040 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/PerThreadPKLookup.java: ## @@ -97,5 +174,28 @@ public int lookup(BytesRef id) throws IOException {

Re: [PR] Add reopen method in PerThreadPKLookup [lucene]

2024-09-11 Thread via GitHub
vsop-479 commented on code in PR #13596: URL: https://github.com/apache/lucene/pull/13596#discussion_r1754191570 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/PerThreadPKLookup.java: ## @@ -97,5 +174,28 @@ public int lookup(BytesRef id) throws IOException {

Re: [PR] Add reopen method in PerThreadPKLookup [lucene]

2024-09-11 Thread via GitHub
vsop-479 commented on code in PR #13596: URL: https://github.com/apache/lucene/pull/13596#discussion_r1753977199 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/PerThreadPKLookup.java: ## @@ -97,5 +174,28 @@ public int lookup(BytesRef id) throws IOException {

Re: [PR] Add reopen method in PerThreadPKLookup [lucene]

2024-09-11 Thread via GitHub
jpountz commented on code in PR #13596: URL: https://github.com/apache/lucene/pull/13596#discussion_r1753802080 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/PerThreadPKLookup.java: ## @@ -97,5 +174,28 @@ public int lookup(BytesRef id) throws IOException {

Re: [PR] Add reopen method in PerThreadPKLookup [lucene]

2024-09-11 Thread via GitHub
jpountz commented on code in PR #13596: URL: https://github.com/apache/lucene/pull/13596#discussion_r1753788413 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/PerThreadPKLookup.java: ## @@ -97,5 +174,28 @@ public int lookup(BytesRef id) throws IOException {

Re: [PR] Add reopen method in PerThreadPKLookup [lucene]

2024-09-11 Thread via GitHub
vsop-479 commented on code in PR #13596: URL: https://github.com/apache/lucene/pull/13596#discussion_r1753771874 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/PerThreadPKLookup.java: ## @@ -97,5 +174,28 @@ public int lookup(BytesRef id) throws IOException {

Re: [PR] Add reopen method in PerThreadPKLookup [lucene]

2024-09-11 Thread via GitHub
jpountz commented on code in PR #13596: URL: https://github.com/apache/lucene/pull/13596#discussion_r1753388629 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/PerThreadPKLookup.java: ## @@ -97,5 +174,28 @@ public int lookup(BytesRef id) throws IOException {

Re: [PR] Add reopen method in PerThreadPKLookup [lucene]

2024-08-30 Thread via GitHub
vsop-479 commented on PR #13596: URL: https://github.com/apache/lucene/pull/13596#issuecomment-2320609552 I can't figure out what can we reuse from prior `PostingsEnum`. If we want reuse prior `PostingsEnum`'s docBuffer( if it still stay in first block), we should not reset `docBuffe

Re: [PR] Add reopen method in PerThreadPKLookup [lucene]

2024-08-19 Thread via GitHub
vsop-479 commented on PR #13596: URL: https://github.com/apache/lucene/pull/13596#issuecomment-2296249587 @jpountz Please take a look when you get a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Add reopen method in PerThreadPKLookup [lucene]

2024-08-16 Thread via GitHub
github-actions[bot] commented on PR #13596: URL: https://github.com/apache/lucene/pull/13596#issuecomment-2294481436 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Add reopen method in PerThreadPKLookup [lucene]

2024-08-05 Thread via GitHub
vsop-479 commented on code in PR #13596: URL: https://github.com/apache/lucene/pull/13596#discussion_r1701382048 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/PerThreadPKLookup.java: ## @@ -97,5 +111,82 @@ public int lookup(BytesRef id) throws IOException {

Re: [PR] Add reopen method in PerThreadPKLookup [lucene]

2024-08-01 Thread via GitHub
vsop-479 commented on code in PR #13596: URL: https://github.com/apache/lucene/pull/13596#discussion_r1701382048 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/PerThreadPKLookup.java: ## @@ -97,5 +111,82 @@ public int lookup(BytesRef id) throws IOException {

Re: [PR] Add reopen method in PerThreadPKLookup [lucene]

2024-07-31 Thread via GitHub
jpountz commented on code in PR #13596: URL: https://github.com/apache/lucene/pull/13596#discussion_r1698176820 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/PerThreadPKLookup.java: ## @@ -97,5 +111,82 @@ public int lookup(BytesRef id) throws IOException {

Re: [PR] Add reopen method in PerThreadPKLookup [lucene]

2024-07-24 Thread via GitHub
vsop-479 commented on PR #13596: URL: https://github.com/apache/lucene/pull/13596#issuecomment-2247188517 @jpountz Please take a look when you get a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U