vsop-479 commented on code in PR #13596:
URL: https://github.com/apache/lucene/pull/13596#discussion_r1756202375
##########
lucene/test-framework/src/java/org/apache/lucene/tests/index/PerThreadPKLookup.java:
##########
@@ -97,5 +174,28 @@ public int lookup(BytesRef id) throws IOException {
return -1;
}
- // TODO: add reopen method to carry over re-used enums...?
+ /**
+ * Reuse loaded segments' termsEnum and postingsEnum.
+ *
+ * @return null if there are no changes; else, a new PerThreadPKLookup
instance which you must
+ * eventually close its reader by {@link #closeReader}.
+ * @throws IOException if there is a low-level IO error.
+ */
+ public PerThreadPKLookup reopen() throws IOException {
+ DirectoryReader newReader =
DirectoryReader.openIfChanged((DirectoryReader) reader);
+ if (newReader == null) {
+ return null;
+ }
+
+ return new PerThreadPKLookup(this, newReader);
Review Comment:
> we could factor the two constructors together, e.g. by having a private
constructor take a Map<CacheKey, PerSegmentCorePKLookup> cache
I merged the two constructors into one, but didn't add a split
`PerSegmentCorePKLookup` for cache. Since I just cached the index(Integer) of
enums array in current version, the cache is: `Map<IndexReader.CacheKey,
Integer> enumIndexes`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
